Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-11 16:05:44 +01:00
Code Issues Packages Projects Releases Activity

Cleanup smells

Browse Source
This commit is contained in:
René Pfeuffer
2018-09-14 12:11:07 +02:00
parent cd344664aa
commit 37ea231340
4 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scm-webapp/src/main/java/sonia/scm/api/v2/resources/RepositoryToRepositoryDtoMapper.java
View File

@@ -29,8 +29,6 @@ public abstract class RepositoryToRepositoryDtoMapper extends BaseMapper<Reposit
private ResourceLinks resourceLinks;
@Inject
private RepositoryServiceFactory serviceFactory;
@Inject
private ScmPathInfoStore scmPathInfoStore;
abstract HealthCheckFailureDto toDto(HealthCheckFailure failure);
@@ -47,7 +45,7 @@ public abstract class RepositoryToRepositoryDtoMapper extends BaseMapper<Reposit
try (RepositoryService repositoryService = serviceFactory.create(repository)) {
if (RepositoryPermissions.pull(repository).isPermitted()) {
List<Link> protocolLinks = repositoryService.getSupportedProtocols()
.map(protocol -> createProtocolLink(protocol, repository))
.map(this::createProtocolLink)
.collect(toList());
linksBuilder.array(protocolLinks);
}
@@ -63,7 +61,7 @@ public abstract class RepositoryToRepositoryDtoMapper extends BaseMapper<Reposit
target.add(linksBuilder.build());
}
private Link createProtocolLink(ScmProtocol protocol, Repository repository) {
private Link createProtocolLink(ScmProtocol protocol) {
return Link.linkBuilder("protocol", protocol.getUrl()).withName(protocol.getType()).build();
}
}