cancel installation on pending plugins

scm-webapp/src/main/java/sonia/scm/api/v2/resources/InstalledPluginResource.java

@@ -67,7 +67,7 @@ public class InstalledPluginResource {
   })
   @TypeHint(CollectionDto.class)
   public Response updateAll(@QueryParam("restart") boolean restartAfterInstallation) {
-    pluginManager.updateAll(restartAfterInstallation);
+    pluginManager.updateAll();
     return Response.ok().build();
   }
 

scm-webapp/src/main/java/sonia/scm/plugin/DefaultPluginManager.java

@@ -288,17 +288,19 @@ public class DefaultPluginManager implements PluginManager {
   }
 
   @Override
-  public void updateAll(boolean restartAfterInstallation) {
+  public void updateAll() {
     PluginPermissions.manage().check();
+    boolean pluginUpdated = false;
 
     for (InstalledPlugin installedPlugin : getInstalled()) {
       String pluginName = installedPlugin.getDescriptor().getInformation().getName();
       if (isUpdatable(pluginName)) {
         install(pluginName, false);
+        pluginUpdated = true;
       }
-      if (restartAfterInstallation) {
-        restart("update all plugin");
-      }
+    }
+    if (pluginUpdated) {
+      restart("update all plugins");
     }
   }
 }

scm-webapp/src/main/java/sonia/scm/plugin/PendingPluginInstallation.java

@@ -28,6 +28,7 @@ class PendingPluginInstallation {
     LOG.info("cancel installation of plugin {}", name);
     try {
       Files.delete(file);
+      plugin.cancelInstallation();
     } catch (IOException ex) {
       throw new PluginFailedToCancelInstallationException("failed to cancel installation of plugin " + name, ex);
     }