Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-10 23:45:44 +01:00
Code Issues Packages Projects Releases Activity

use final field and fixed a precondition check

Browse Source
This commit is contained in:
Sebastian Sdorra
2014-01-09 19:27:09 +01:00
parent a7e84bbe3c
commit 2e6748cb23
5 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scm-dao-xml/src/main/java/sonia/scm/store/FileBasedStore.java
View File

@@ -199,5 +199,5 @@ public abstract class FileBasedStore<T> implements StoreBase<T>
protected File directory; protected File directory;
/** Field description */ /** Field description */
private String suffix; private final String suffix;
} }

4
scm-dao-xml/src/main/java/sonia/scm/store/FileBasedStoreFactory.java
View File

@@ -105,11 +105,11 @@ public class FileBasedStoreFactory
//~--- fields --------------------------------------------------------------- //~--- fields ---------------------------------------------------------------
/** Field description */ /** Field description */
private SCMContextProvider context; private final SCMContextProvider context;
/** Field description */ /** Field description */
private File dataDirectory; private File dataDirectory;
/** Field description */ /** Field description */
private String dataDirectoryName; private final String dataDirectoryName;
} }

6
scm-dao-xml/src/main/java/sonia/scm/store/FileBlob.java
View File

@@ -46,7 +46,7 @@ import java.io.OutputStream;
* *
* @author Sebastian Sdorra * @author Sebastian Sdorra
*/ */
public class FileBlob implements Blob public final class FileBlob implements Blob
{ {
/** /**
@@ -122,8 +122,8 @@ public class FileBlob implements Blob
//~--- fields --------------------------------------------------------------- //~--- fields ---------------------------------------------------------------
/** Field description */ /** Field description */
private File file; private final File file;
/** Field description */ /** Field description */
private String id; private final String id;
} }

6
scm-dao-xml/src/main/java/sonia/scm/store/FileBlobStore.java
View File

@@ -142,7 +142,7 @@ public class FileBlobStore extends FileBasedStore<Blob> implements BlobStore
@Override @Override
public void remove(Blob blob) public void remove(Blob blob)
{ {
Preconditions.checkNotNull("blob argument is required"); Preconditions.checkNotNull(blob, "blob argument is required");
remove(blob.getId()); remove(blob.getId());
} }
@@ -196,6 +196,6 @@ public class FileBlobStore extends FileBasedStore<Blob> implements BlobStore
//~--- fields --------------------------------------------------------------- //~--- fields ---------------------------------------------------------------
/** Field description */ /** key generator */
private KeyGenerator keyGenerator; private final KeyGenerator keyGenerator;
} }

4
scm-dao-xml/src/main/java/sonia/scm/store/FileBlobStoreFactory.java
View File

@@ -98,6 +98,6 @@ public class FileBlobStoreFactory extends FileBasedStoreFactory
//~--- fields --------------------------------------------------------------- //~--- fields ---------------------------------------------------------------
/** Field description */ /** key generator */
private KeyGenerator keyGenerator; private final KeyGenerator keyGenerator;
} }