Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-07 22:15:45 +01:00
Code Issues Packages Projects Releases Activity

use index of char instead of index of string, if possible

Browse Source
This commit is contained in:
Sebastian Sdorra
2013-01-30 10:10:20 +01:00
parent d165baffe9
commit 2d5fa22ca4
16 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
maven/scm-maven-plugin/src/main/java/sonia/scm/maven/PackageMojo.java
View File

@@ -340,7 +340,7 @@ public class PackageMojo extends AbstractBaseScmMojo
if (resolveMetadata)
{
String path = localRepository.pathOf(artifact);
int lastIndex = path.lastIndexOf(".");
int lastIndex = path.lastIndexOf('.');
if (lastIndex > 0)
{

2
scm-core/src/main/java/sonia/scm/io/INIConfigurationReader.java
View File

@@ -101,7 +101,7 @@ public class INIConfigurationReader extends AbstractReader<INIConfiguration>
else if ((section != null) &&!line.startsWith(";")
&&!line.startsWith("#"))
{
int index = line.indexOf("=");
int index = line.indexOf('=');
if (index > 0)
{

2
scm-core/src/main/java/sonia/scm/net/Proxies.java
View File

@@ -84,7 +84,7 @@ public class Proxies
url = url.substring(index + 3);
}
index = url.indexOf("/");
index = url.indexOf('/');
if (index > 0)
{

2
scm-core/src/main/java/sonia/scm/plugin/PluginVersion.java
View File

@@ -68,7 +68,7 @@ public class PluginVersion implements Comparable<PluginVersion>
{
this.unparsedVersion = versionString;
int index = versionString.indexOf("-");
int index = versionString.indexOf('-');
String versionPart = null;
String qualifierPart = null;

4
scm-core/src/main/java/sonia/scm/repository/Person.java
View File

@@ -115,8 +115,8 @@ public class Person implements Validateable, Serializable
{
String name = value;
String mail = null;
int s = value.indexOf("<");
int e = value.indexOf(">");
int s = value.indexOf('<');
int e = value.indexOf('>');
if ((s > 0) && (e > 0))
{

2
scm-core/src/main/java/sonia/scm/url/UrlUtil.java
View File

@@ -59,7 +59,7 @@ public class UrlUtil
if (Util.isNotEmpty(revision))
{
int index = revision.indexOf(":");
int index = revision.indexOf(':');
if (index > 0)
{

2
scm-core/src/main/java/sonia/scm/util/HttpUtil.java
View File

@@ -331,7 +331,7 @@ public class HttpUtil
*/
public static String removeMatrixParameter(String uri)
{
int index = uri.indexOf(";");
int index = uri.indexOf(';');
if (index > 0)
{

2
scm-core/src/main/java/sonia/scm/util/RegistryUtil.java
View File

@@ -133,7 +133,7 @@ public class RegistryUtil
if (value.startsWith("\""))
{
value = value.substring(1);
value = value.substring(0, value.indexOf("\""));
value = value.substring(0, value.indexOf('"'));
}
if (logger.isDebugEnabled())

2
scm-core/src/main/java/sonia/scm/web/cgi/CGIRunner.java
View File

@@ -217,7 +217,7 @@ public class CGIRunner
// into exec here...
String execCmd = path;
if ((execCmd.charAt(0) != '"') && (execCmd.indexOf(" ") >= 0))
if ((execCmd.charAt(0) != '"') && (execCmd.indexOf(' ') >= 0))
{
execCmd = "\"" + execCmd + "\"";
}

2
scm-plugins/scm-hg-plugin/src/main/java/sonia/scm/repository/spi/javahg/HgFileviewCommand.java
View File

@@ -332,7 +332,7 @@ public class HgFileviewCommand extends AbstractCommand
*/
private String getNameFromPath(String path)
{
int index = path.lastIndexOf("/");
int index = path.lastIndexOf('/');
if (index > 0)
{

2
scm-webapp/src/main/java/sonia/scm/api/rest/resources/RepositoryResource.java
View File

@@ -1089,7 +1089,7 @@ public class RepositoryResource
private String getContentDispositionNameFromPath(String path)
{
String name = path;
int index = path.lastIndexOf("/");
int index = path.lastIndexOf('/');
if (index >= 0)
{

2
scm-webapp/src/main/java/sonia/scm/plugin/DefaultPluginLoader.java
View File

@@ -299,7 +299,7 @@ public class DefaultPluginLoader implements PluginLoader
{
// jar:file:/some/path/file.jar!/META-INF/scm/plugin.xml
path = path.substring("jar:file:".length(), path.lastIndexOf("!"));
path = path.substring("jar:file:".length(), path.lastIndexOf('!'));
path = decodePath(path);
}

2
scm-webapp/src/main/java/sonia/scm/plugin/DefaultPluginManager.java
View File

@@ -673,7 +673,7 @@ public class DefaultPluginManager
*/
private String getPluginIdPrefix(String pluginId)
{
return pluginId.substring(0, pluginId.lastIndexOf(":"));
return pluginId.substring(0, pluginId.lastIndexOf(':'));
}
/**

2
scm-webapp/src/main/java/sonia/scm/template/TemplateServlet.java
View File

@@ -156,7 +156,7 @@ public class TemplateServlet extends HttpServlet
params.put("locale", locale);
String country = locale;
int i = country.indexOf("_");
int i = country.indexOf('_');
if (i > 0)
{

2
scm-webapp/src/main/java/sonia/scm/web/cgi/DefaultCGIExecutor.java
View File

@@ -158,7 +158,7 @@ public class DefaultCGIExecutor extends AbstractCGIExecutor
String execCmd = path;
if ((execCmd.charAt(0) != '"') && (execCmd.indexOf(" ") >= 0))
if ((execCmd.charAt(0) != '"') && (execCmd.indexOf(' ') >= 0))
{
execCmd = "\"".concat(execCmd).concat("\"");
}