use index of char instead of index of string, if possible

maven/scm-maven-plugin/src/main/java/sonia/scm/maven/PackageMojo.java

@@ -340,7 +340,7 @@ public class PackageMojo extends AbstractBaseScmMojo
       if (resolveMetadata)
       {
         String path = localRepository.pathOf(artifact);
-        int lastIndex = path.lastIndexOf(".");
+        int lastIndex = path.lastIndexOf('.');
 
         if (lastIndex > 0)
         {

scm-core/src/main/java/sonia/scm/io/INIConfigurationReader.java

@@ -101,7 +101,7 @@ public class INIConfigurationReader extends AbstractReader<INIConfiguration>
         else if ((section != null) &&!line.startsWith(";")
                  &&!line.startsWith("#"))
         {
-          int index = line.indexOf("=");
+          int index = line.indexOf('=');
 
           if (index > 0)
           {

scm-core/src/main/java/sonia/scm/net/Proxies.java

@@ -84,7 +84,7 @@ public class Proxies
         url = url.substring(index + 3);
       }
 
-      index = url.indexOf("/");
+      index = url.indexOf('/');
 
       if (index > 0)
       {

scm-core/src/main/java/sonia/scm/plugin/PluginVersion.java

@@ -68,7 +68,7 @@ public class PluginVersion implements Comparable<PluginVersion>
   {
     this.unparsedVersion = versionString;
 
-    int index = versionString.indexOf("-");
+    int index = versionString.indexOf('-');
     String versionPart = null;
     String qualifierPart = null;
 

scm-core/src/main/java/sonia/scm/repository/Person.java

@@ -115,8 +115,8 @@ public class Person implements Validateable, Serializable
     {
       String name = value;
       String mail = null;
-      int s = value.indexOf("<");
+      int s = value.indexOf('<');
-      int e = value.indexOf(">");
+      int e = value.indexOf('>');
 
       if ((s > 0) && (e > 0))
       {

scm-core/src/main/java/sonia/scm/url/UrlUtil.java

@@ -59,7 +59,7 @@ public class UrlUtil
 
     if (Util.isNotEmpty(revision))
     {
-      int index = revision.indexOf(":");
+      int index = revision.indexOf(':');
 
       if (index > 0)
       {

scm-core/src/main/java/sonia/scm/util/HttpUtil.java

@@ -331,7 +331,7 @@ public class HttpUtil
    */
   public static String removeMatrixParameter(String uri)
   {
-    int index = uri.indexOf(";");
+    int index = uri.indexOf(';');
 
     if (index > 0)
     {

scm-core/src/main/java/sonia/scm/util/RegistryUtil.java

@@ -133,7 +133,7 @@ public class RegistryUtil
             if (value.startsWith("\""))
             {
               value = value.substring(1);
-              value = value.substring(0, value.indexOf("\""));
+              value = value.substring(0, value.indexOf('"'));
             }
 
             if (logger.isDebugEnabled())

scm-core/src/main/java/sonia/scm/web/cgi/CGIRunner.java

@@ -217,7 +217,7 @@ public class CGIRunner
     // into exec here...
     String execCmd = path;
 
-    if ((execCmd.charAt(0) != '"') && (execCmd.indexOf(" ") >= 0))
+    if ((execCmd.charAt(0) != '"') && (execCmd.indexOf(' ') >= 0))
     {
       execCmd = "\"" + execCmd + "\"";
     }

scm-plugins/scm-hg-plugin/src/main/java/sonia/scm/repository/spi/javahg/HgFileviewCommand.java

@@ -332,7 +332,7 @@ public class HgFileviewCommand extends AbstractCommand
    */
   private String getNameFromPath(String path)
   {
-    int index = path.lastIndexOf("/");
+    int index = path.lastIndexOf('/');
 
     if (index > 0)
     {

scm-webapp/src/main/java/sonia/scm/api/rest/resources/RepositoryResource.java

@@ -1089,7 +1089,7 @@ public class RepositoryResource
   private String getContentDispositionNameFromPath(String path)
   {
     String name = path;
-    int index = path.lastIndexOf("/");
+    int index = path.lastIndexOf('/');
 
     if (index >= 0)
     {

scm-webapp/src/main/java/sonia/scm/plugin/DefaultPluginLoader.java

@@ -299,7 +299,7 @@ public class DefaultPluginLoader implements PluginLoader
     {
 
       // jar:file:/some/path/file.jar!/META-INF/scm/plugin.xml
-      path = path.substring("jar:file:".length(), path.lastIndexOf("!"));
+      path = path.substring("jar:file:".length(), path.lastIndexOf('!'));
       path = decodePath(path);
     }
 

scm-webapp/src/main/java/sonia/scm/plugin/DefaultPluginManager.java

@@ -673,7 +673,7 @@ public class DefaultPluginManager
    */
   private String getPluginIdPrefix(String pluginId)
   {
-    return pluginId.substring(0, pluginId.lastIndexOf(":"));
+    return pluginId.substring(0, pluginId.lastIndexOf(':'));
   }
 
   /**

scm-webapp/src/main/java/sonia/scm/template/TemplateServlet.java

@@ -156,7 +156,7 @@ public class TemplateServlet extends HttpServlet
     params.put("locale", locale);
 
     String country = locale;
-    int i = country.indexOf("_");
+    int i = country.indexOf('_');
 
     if (i > 0)
     {

scm-webapp/src/main/java/sonia/scm/web/cgi/DefaultCGIExecutor.java

@@ -158,7 +158,7 @@ public class DefaultCGIExecutor extends AbstractCGIExecutor
 
     String execCmd = path;
 
-    if ((execCmd.charAt(0) != '"') && (execCmd.indexOf(" ") >= 0))
+    if ((execCmd.charAt(0) != '"') && (execCmd.indexOf(' ') >= 0))
     {
       execCmd = "\"".concat(execCmd).concat("\"");
     }