Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-17 10:41:06 +01:00
Code Issues Packages Projects Releases Activity

Extract base class for collection mappers

Browse Source
This commit is contained in:
René Pfeuffer
2018-06-25 09:57:59 +02:00
parent f9a094e1b9
commit 2d32b24e48
10 changed files with 128 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
scm-webapp/src/test/java/sonia/scm/api/v2/resources/GroupCollectionToDtoMapperTest.java
View File

@@ -56,29 +56,29 @@ public class GroupCollectionToDtoMapperTest {
@Test
public void shouldSetPageNumber() {
PageResult<Group> pageResult = mockPageResult("nobodies");
GroupCollectionDto groupCollectionDto = mapper.map(1, 1, pageResult);
assertEquals(1, groupCollectionDto.getPage());
CollectionDto collectionDto = mapper.map(1, 1, pageResult);
assertEquals(1, collectionDto.getPage());
}
@Test
public void shouldHaveSelfLink() {
PageResult<Group> pageResult = mockPageResult("nobodies");
GroupCollectionDto groupCollectionDto = mapper.map(1, 1, pageResult);
assertTrue(groupCollectionDto.getLinks().getLinkBy("self").get().getHref().startsWith(expectedBaseUri.toString()));
CollectionDto collectionDto = mapper.map(1, 1, pageResult);
assertTrue(collectionDto.getLinks().getLinkBy("self").get().getHref().startsWith(expectedBaseUri.toString()));
}
@Test
public void shouldCreateNextPageLink_whenHasMore() {
PageResult<Group> pageResult = createPage(createGroups("nobodies", "bosses"), 0, 1);
GroupCollectionDto groupCollectionDto = mapper.map(0, 1, pageResult);
assertTrue(groupCollectionDto.getLinks().getLinkBy("next").get().getHref().contains("page=1"));
CollectionDto collectionDto = mapper.map(0, 1, pageResult);
assertTrue(collectionDto.getLinks().getLinkBy("next").get().getHref().contains("page=1"));
}
@Test
public void shouldNotCreateNextPageLink_whenNoMore() {
PageResult<Group> pageResult = mockPageResult("nobodies");
GroupCollectionDto groupCollectionDto = mapper.map(1, 1, pageResult);
assertFalse(groupCollectionDto.getLinks().stream().anyMatch(link -> link.getHref().contains("page=2")));
CollectionDto collectionDto = mapper.map(1, 1, pageResult);
assertFalse(collectionDto.getLinks().stream().anyMatch(link -> link.getHref().contains("page=2")));
}
@Test
@@ -86,9 +86,9 @@ public class GroupCollectionToDtoMapperTest {
PageResult<Group> pageResult = mockPageResult("nobodies");
when(subject.isPermitted("group:create")).thenReturn(true);
GroupCollectionDto groupCollectionDto = mapper.map(1, 1, pageResult);
CollectionDto collectionDto = mapper.map(1, 1, pageResult);
assertTrue(groupCollectionDto.getLinks().getLinkBy("create").isPresent());
assertTrue(collectionDto.getLinks().getLinkBy("create").isPresent());
}
@Test
@@ -96,16 +96,16 @@ public class GroupCollectionToDtoMapperTest {
PageResult<Group> pageResult = mockPageResult("nobodies");
when(subject.isPermitted("group:create")).thenReturn(false);
GroupCollectionDto groupCollectionDto = mapper.map(1, 1, pageResult);
CollectionDto collectionDto = mapper.map(1, 1, pageResult);
assertFalse(groupCollectionDto.getLinks().getLinkBy("create").isPresent());
assertFalse(collectionDto.getLinks().getLinkBy("create").isPresent());
}
@Test
public void shouldMapGroups() {
PageResult<Group> pageResult = mockPageResult("nobodies", "bosses");
GroupCollectionDto groupCollectionDto = mapper.map(1, 2, pageResult);
List<HalRepresentation> groups = groupCollectionDto.getEmbedded().getItemsBy("groups");
CollectionDto collectionDto = mapper.map(1, 2, pageResult);
List<HalRepresentation> groups = collectionDto.getEmbedded().getItemsBy("groups");
assertEquals(2, groups.size());
assertEquals("nobodies", ((GroupDto) groups.get(0)).getName());
assertEquals("bosses", ((GroupDto) groups.get(1)).getName());

28
scm-webapp/src/test/java/sonia/scm/api/v2/resources/UserCollectionToDtoMapperTest.java
View File

@@ -63,30 +63,30 @@ public class UserCollectionToDtoMapperTest {
@Test
public void shouldSetPageNumber() {
PageResult<User> pageResult = mockPageResult("Hannes");
UserCollectionDto userCollectionDto = mapper.map(0, 1, pageResult);
assertEquals(0, userCollectionDto.getPage());
CollectionDto collectionDto = mapper.map(0, 1, pageResult);
assertEquals(0, collectionDto.getPage());
}
@Test
public void shouldHaveSelfLink() {
PageResult<User> pageResult = mockPageResult("Hannes");
UserCollectionDto userCollectionDto = mapper.map(0, 1, pageResult);
assertTrue(userCollectionDto.getLinks().getLinkBy("self").get().getHref().startsWith(expectedBaseUri.toString()));
CollectionDto collectionDto = mapper.map(0, 1, pageResult);
assertTrue(collectionDto.getLinks().getLinkBy("self").get().getHref().startsWith(expectedBaseUri.toString()));
}
@Test
public void shouldCreateNextPageLink_whenHasMore() {
PageResult<User> pageResult = createPage(createUsers("Hannes", "Karl"), 0, 1);
UserCollectionDto userCollectionDto = mapper.map(0, 1, pageResult);
assertTrue(userCollectionDto.getLinks().getLinkBy("next").get().getHref().contains("page=1"));
CollectionDto collectionDto = mapper.map(0, 1, pageResult);
assertTrue(collectionDto.getLinks().getLinkBy("next").get().getHref().contains("page=1"));
}
@Test
public void shouldNotCreateNextPageLink_whenNoMore() {
PageResult<User> pageResult = mockPageResult("Hannes", "Wurst", "X");
UserCollectionDto userCollectionDto = mapper.map(0, 10, pageResult);
assertFalse(userCollectionDto.getLinks().getLinkBy("next").isPresent());
CollectionDto collectionDto = mapper.map(0, 10, pageResult);
assertFalse(collectionDto.getLinks().getLinkBy("next").isPresent());
}
@Test
@@ -94,9 +94,9 @@ public class UserCollectionToDtoMapperTest {
PageResult<User> pageResult = mockPageResult("Hannes");
when(subject.isPermitted("user:create")).thenReturn(true);
UserCollectionDto userCollectionDto = mapper.map(0, 1, pageResult);
CollectionDto collectionDto = mapper.map(0, 1, pageResult);
assertTrue(userCollectionDto.getLinks().getLinkBy("create").isPresent());
assertTrue(collectionDto.getLinks().getLinkBy("create").isPresent());
}
@Test
@@ -104,16 +104,16 @@ public class UserCollectionToDtoMapperTest {
PageResult<User> pageResult = mockPageResult("Hannes");
when(subject.isPermitted("user:create")).thenReturn(false);
UserCollectionDto userCollectionDto = mapper.map(0, 1, pageResult);
CollectionDto collectionDto = mapper.map(0, 1, pageResult);
assertFalse(userCollectionDto.getLinks().getLinkBy("create").isPresent());
assertFalse(collectionDto.getLinks().getLinkBy("create").isPresent());
}
@Test
public void shouldMapUsers() {
PageResult<User> pageResult = mockPageResult("Hannes", "Wurst");
UserCollectionDto userCollectionDto = mapper.map(0, 2, pageResult);
List<HalRepresentation> users = userCollectionDto.getEmbedded().getItemsBy("users");
CollectionDto collectionDto = mapper.map(0, 2, pageResult);
List<HalRepresentation> users = collectionDto.getEmbedded().getItemsBy("users");
assertEquals(2, users.size());
assertEquals("Hannes", ((UserDto) users.get(0)).getName());
assertEquals("Wurst", ((UserDto) users.get(1)).getName());