fix out of scope exception on access hgcontext

This commit is contained in:
Sebastian Sdorra
2013-09-27 17:59:53 +02:00
parent 69715bf7d3
commit 2b91053909
2 changed files with 30 additions and 2 deletions

View File

@@ -30,12 +30,17 @@
*/
package sonia.scm.repository;
//~--- non-JDK imports --------------------------------------------------------
import com.google.inject.Inject;
import com.google.inject.Provider;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
*
* @author Sebastian Sdorra
@@ -43,6 +48,14 @@ import com.google.inject.Provider;
public class HgContextProvider implements Provider<HgContext>
{
/**
* the logger for HgContextProvider
*/
private static final Logger logger =
LoggerFactory.getLogger(HgContextProvider.class);
//~--- get methods ----------------------------------------------------------
/**
* Method description
*
@@ -52,6 +65,20 @@ public class HgContextProvider implements Provider<HgContext>
@Override
public HgContext get()
{
return new HgContext();
HgContext ctx = context;
if (ctx == null)
{
ctx = new HgContext();
logger.trace("context is null, we are probably out of request scope");
}
return ctx;
}
//~--- fields ---------------------------------------------------------------
/** Field description */
@Inject(optional = true)
private HgContext context;
}

View File

@@ -40,6 +40,7 @@ import com.google.inject.servlet.ServletModule;
import sonia.scm.installer.HgPackageReader;
import sonia.scm.plugin.ext.Extension;
import sonia.scm.repository.HgContext;
import sonia.scm.repository.HgContextProvider;
import sonia.scm.repository.HgHookManager;
import sonia.scm.web.filter.BasicAuthenticationFilter;
@@ -66,7 +67,7 @@ public class HgServletModule extends ServletModule
@Override
protected void configureServlets()
{
bind(HgContext.class);
bind(HgContext.class).toProvider(HgContextProvider.class);
bind(HgHookManager.class);
bind(HgPackageReader.class);