Added auto-login filter system.

scm-core/src/main/java/sonia/scm/web/filter/AutoLoginFilter.java

@@ -0,0 +1,137 @@
+/**
+ * Copyright (c) 2013, Clemens Rabe
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ */
+package sonia.scm.web.filter;
+
+import java.io.IOException;
+import java.util.Set;
+
+import javax.servlet.FilterChain;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.apache.shiro.SecurityUtils;
+import org.apache.shiro.subject.Subject;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import sonia.scm.user.User;
+
+import com.google.inject.Inject;
+import com.google.inject.Singleton;
+
+/**
+ * This filter calls all AutoLoginModule objects to try an auto-login. It can be
+ * used on its own, usually at the global context ('/*') or as a base class like
+ * BasicAuthenticationFilter.
+ * 
+ * @author Clemens Rabe
+ */
+@Singleton
+public class AutoLoginFilter extends HttpFilter {
+
+	/** the logger for AutoLoginFilter */
+	private static final Logger logger = LoggerFactory
+			.getLogger(AutoLoginFilter.class);
+
+	@Deprecated
+	public AutoLoginFilter() {
+	}
+
+	/**
+	 * Constructor.
+	 * 
+	 * @param autoLoginModules
+	 *            - The auto-login modules.
+	 */
+	@Inject
+	public AutoLoginFilter(Set<AutoLoginModule> autoLoginModules) {
+		this.autoLoginModules = autoLoginModules;
+	}
+
+	@Override
+	protected void doFilter(HttpServletRequest request,
+			HttpServletResponse response, FilterChain chain)
+			throws IOException, ServletException {
+		User user = getAuthenticatedUser(request, response);
+
+		if (user == null)
+			chain.doFilter(request, response);
+		else
+			chain.doFilter(
+					new SecurityHttpServletRequestWrapper(request, user),
+					response);
+	}
+
+	/**
+	 * Check all known AutoLoginModule objects to authenticate the user using
+	 * the current request.
+	 * 
+	 * @param request
+	 *            - The servlet request.
+	 * @param response
+	 *            - The servlet response.
+	 * @return The user or null if no user was found.
+	 */
+	protected User getAuthenticatedUser(HttpServletRequest request,
+			HttpServletResponse response) {
+		Subject subject = SecurityUtils.getSubject();
+		User user = null;
+
+		if (subject.isAuthenticated() || subject.isRemembered()) {
+			if (logger.isTraceEnabled()) {
+				logger.trace("user is allready authenticated");
+			}
+
+			user = subject.getPrincipals().oneByType(User.class);
+		} else {
+			// Try the known filters first
+			for (AutoLoginModule filter : autoLoginModules) {
+				user = filter.authenticate(request, response, subject);
+
+				if (user != null) {
+					if (logger.isTraceEnabled()) {
+						logger.trace(
+								"user {} successfully authenticated by authentication filter",
+								user.getName());
+					}
+					break;
+				}
+			}
+		}
+
+		return user;
+	}
+
+	/**
+	 * Set of AutoLoginModule objects.
+	 */
+	private Set<AutoLoginModule> autoLoginModules;
+
+}

scm-core/src/main/java/sonia/scm/web/filter/AutoLoginModule.java

@@ -0,0 +1,64 @@
+/**
+ * Copyright (c) 2013, Clemens Rabe
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ */
+package sonia.scm.web.filter;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.apache.shiro.subject.Subject;
+
+import sonia.scm.plugin.ExtensionPoint;
+import sonia.scm.user.User;
+
+/**
+ * Classes implementing this interface are called by the
+ * BasicAuthenticationFilter before the default basic authentication takes
+ * place. This allows to implement auto-login methods.
+ * 
+ * @author Clemens Rabe
+ */
+@ExtensionPoint
+public interface AutoLoginModule {
+
+	/**
+	 * Authenticate a user using the given request object. If the user can not
+	 * be authenticated, e.g., because required headers are not set null must be
+	 * returned.
+	 * 
+	 * @param request
+	 *            The HTTP request.
+	 * @param response
+	 *            The HTTP response. Use only if absolutely necessary.
+	 * @param subject
+	 *            The subject object.
+	 * @return Return a User object or null.
+	 */
+	public User authenticate(HttpServletRequest request,
+			HttpServletResponse response, Subject subject);
+}

scm-core/src/main/java/sonia/scm/web/filter/BasicAuthenticationFilter.java

@@ -29,8 +29,6 @@
  *
  */
 
-
-
 package sonia.scm.web.filter;
 
 //~--- non-JDK imports --------------------------------------------------------
@@ -43,7 +41,6 @@ import org.apache.shiro.SecurityUtils;
 import org.apache.shiro.authc.AuthenticationException;
 import org.apache.shiro.authc.UsernamePasswordToken;
 import org.apache.shiro.subject.Subject;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -52,6 +49,7 @@ import sonia.scm.config.ScmConfiguration;
 import sonia.scm.user.User;
 import sonia.scm.util.HttpUtil;
 import sonia.scm.util.Util;
+import sonia.scm.web.security.AuthenticationHandler;
 import sonia.scm.web.security.WebSecurityContext;
 
 //~--- JDK imports ------------------------------------------------------------
@@ -59,6 +57,7 @@ import sonia.scm.web.security.WebSecurityContext;
 import com.sun.jersey.core.util.Base64;
 
 import java.io.IOException;
+import java.util.Set;
 
 import javax.servlet.FilterChain;
 import javax.servlet.ServletException;
@@ -70,8 +69,7 @@ import javax.servlet.http.HttpServletResponse;
  * @author Sebastian Sdorra
  */
 @Singleton
-public class BasicAuthenticationFilter extends HttpFilter
+public class BasicAuthenticationFilter extends AutoLoginFilter {
-{
 
 	/** Field description */
 	public static final String AUTHORIZATION_BASIC_PREFIX = "BASIC";
@@ -83,10 +81,11 @@ public class BasicAuthenticationFilter extends HttpFilter
 	public static final String HEADER_AUTHORIZATION = "Authorization";
 
 	/** the logger for BasicAuthenticationFilter */
-  private static final Logger logger =
+	private static final Logger logger = LoggerFactory
-    LoggerFactory.getLogger(BasicAuthenticationFilter.class);
+			.getLogger(BasicAuthenticationFilter.class);
 
-  //~--- constructors ---------------------------------------------------------
+	// ~--- constructors
+	// ---------------------------------------------------------
 
 	/**
 	 * Constructs ...
@@ -97,22 +96,26 @@ public class BasicAuthenticationFilter extends HttpFilter
 	 */
 	@Deprecated
 	public BasicAuthenticationFilter(
-    Provider<WebSecurityContext> securityContextProvider) {}
+			Provider<WebSecurityContext> securityContextProvider) {
+	}
 
 	/**
 	 * Constructs a new basic authenticaton filter
 	 * 
-   * @param configuration scm-manager global configuration
+	 * @param configuration
+	 *            scm-manager global configuration
 	 * 
 	 * @since 1.21
 	 */
 	@Inject
-  public BasicAuthenticationFilter(ScmConfiguration configuration)
+	public BasicAuthenticationFilter(ScmConfiguration configuration,
-  {
+			Set<AutoLoginModule> autoLoginModules) {
+		super(autoLoginModules);
 		this.configuration = configuration;
 	}
 
-  //~--- methods --------------------------------------------------------------
+	// ~--- methods
+	// --------------------------------------------------------------
 
 	/**
 	 * Method description
@@ -128,66 +131,49 @@ public class BasicAuthenticationFilter extends HttpFilter
 	@Override
 	protected void doFilter(HttpServletRequest request,
 			HttpServletResponse response, FilterChain chain)
-    throws IOException, ServletException
+			throws IOException, ServletException {
-  {
 		Subject subject = SecurityUtils.getSubject();
+		User user = getAuthenticatedUser(request, response);
 
-    User user = null;
+		// Fallback to basic authentication scheme
+		if (user == null) {
 			String authentication = request.getHeader(HEADER_AUTHORIZATION);
 
-    if (Util.startWithIgnoreCase(authentication, AUTHORIZATION_BASIC_PREFIX))
+			if (Util.startWithIgnoreCase(authentication,
-    {
+					AUTHORIZATION_BASIC_PREFIX)) {
-      if (logger.isTraceEnabled())
+				if (logger.isTraceEnabled()) {
-      {
 					logger.trace("found basic authorization header, start authentication");
 				}
 
 				user = authenticate(request, response, subject, authentication);
 
-      if (logger.isTraceEnabled())
+				if (logger.isTraceEnabled()) {
-      {
+					if (user != null) {
-        if (user != null)
+						logger.trace("user {} successfully authenticated",
-        {
+								user.getName());
-          logger.trace("user {} successfully authenticated", user.getName());
+					} else {
-        }
-        else
-        {
 						logger.trace("authentcation failed, user object is null");
 					}
 				}
-    }
+			} else if ((configuration != null)
-    else if (subject.isAuthenticated() || subject.isRemembered())
+					&& configuration.isAnonymousAccessEnabled()) {
-    {
+				if (logger.isTraceEnabled()) {
-      if (logger.isTraceEnabled())
-      {
-        logger.trace("user is allready authenticated");
-      }
-
-      user = subject.getPrincipals().oneByType(User.class);
-    }
-    else if ((configuration != null)
-      && configuration.isAnonymousAccessEnabled())
-    {
-      if (logger.isTraceEnabled())
-      {
 					logger.trace("anonymous access granted");
 				}
 
 				user = SCMContext.ANONYMOUS;
 			}
+		}
 
-    if (user == null)
+		if (user == null) {
-    {
+			if (logger.isTraceEnabled()) {
-      if (logger.isTraceEnabled())
-      {
 				logger.trace("could not find user send unauthorized");
 			}
 
 			handleUnauthorized(request, response, chain);
-    }
+		} else {
-    else
+			chain.doFilter(
-    {
+					new SecurityHttpServletRequestWrapper(request, user),
-      chain.doFilter(new SecurityHttpServletRequestWrapper(request, user),
 					response);
 		}
 	}
@@ -207,8 +193,7 @@ public class BasicAuthenticationFilter extends HttpFilter
 	 */
 	protected void handleUnauthorized(HttpServletRequest request,
 			HttpServletResponse response, FilterChain chain)
-    throws IOException, ServletException
+			throws IOException, ServletException {
-  {
 		HttpUtil.sendUnauthorized(request, response);
 	}
 
@@ -225,8 +210,7 @@ public class BasicAuthenticationFilter extends HttpFilter
 	 * @return
 	 */
 	private User authenticate(HttpServletRequest request,
-    HttpServletResponse response, Subject subject, String authentication)
+			HttpServletResponse response, Subject subject, String authentication) {
-  {
 		String token = authentication.substring(6);
 
 		token = new String(Base64.decode(token.getBytes()));
@@ -234,52 +218,41 @@ public class BasicAuthenticationFilter extends HttpFilter
 		int index = token.indexOf(CREDENTIAL_SEPARATOR);
 		User user = null;
 
-    if ((index > 0) && (index < token.length()))
+		if ((index > 0) && (index < token.length())) {
-    {
 			String username = token.substring(0, index);
 			String password = token.substring(index + 1);
 
-      if (Util.isNotEmpty(username) && Util.isNotEmpty(password))
+			if (Util.isNotEmpty(username) && Util.isNotEmpty(password)) {
-      {
+				if (logger.isTraceEnabled()) {
-        if (logger.isTraceEnabled())
-        {
 					logger.trace("try to authenticate user {}", username);
 				}
 
-        try
+				try {
-        {
 
 					subject.login(new UsernamePasswordToken(username, password,
 							request.getRemoteAddr()));
 					user = subject.getPrincipals().oneByType(User.class);
-        }
+				} catch (AuthenticationException ex) {
-        catch (AuthenticationException ex)
+					if (logger.isTraceEnabled()) {
-        {
+						logger.trace("authentication failed for user "
-          if (logger.isTraceEnabled())
+								.concat(username), ex);
-          {
+					} else if (logger.isWarnEnabled()) {
-            logger.trace("authentication failed for user ".concat(username),
+						logger.warn("authentication failed for user {}",
-              ex);
+								username);
-          }
-          else if (logger.isWarnEnabled())
-          {
-            logger.warn("authentication failed for user {}", username);
 					}
 				}
-      }
+			} else if (logger.isWarnEnabled()) {
-      else if (logger.isWarnEnabled())
-      {
 				logger.warn("username or password is null/empty");
 			}
-    }
+		} else if (logger.isWarnEnabled()) {
-    else if (logger.isWarnEnabled())
-    {
 			logger.warn("failed to read basic auth credentials");
 		}
 
 		return user;
 	}
 
-  //~--- fields ---------------------------------------------------------------
+	// ~--- fields
+	// ---------------------------------------------------------------
 
 	/** Field description */
 	private ScmConfiguration configuration;

scm-webapp/src/main/java/sonia/scm/ScmServletModule.java

@@ -43,7 +43,6 @@ import com.google.inject.servlet.ServletModule;
 import com.google.inject.throwingproviders.ThrowingProviderBinder;
 
 import org.apache.shiro.authz.permission.PermissionResolver;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -130,6 +129,7 @@ import sonia.scm.util.DebugServlet;
 import sonia.scm.util.ScmConfigurationUtil;
 import sonia.scm.web.cgi.CGIExecutorFactory;
 import sonia.scm.web.cgi.DefaultCGIExecutorFactory;
+import sonia.scm.web.filter.AutoLoginFilter;
 import sonia.scm.web.filter.LoggingFilter;
 import sonia.scm.web.security.AdministrationContext;
 import sonia.scm.web.security.ApiBasicAuthenticationFilter;
@@ -141,6 +141,7 @@ import sonia.scm.web.security.WebSecurityContext;
 
 //~--- JDK imports ------------------------------------------------------------
 
+
 import com.sun.jersey.api.core.PackagesResourceConfig;
 import com.sun.jersey.api.core.ResourceConfig;
 import com.sun.jersey.api.json.JSONConfiguration;
@@ -347,6 +348,7 @@ public class ScmServletModule extends ServletModule
      *      PATTERN_STATIC_RESOURCES).through(StaticResourceFilter.class);
      */
     filter(PATTERN_ALL).through(BaseUrlFilter.class);
+    filter(PATTERN_ALL).through(AutoLoginFilter.class);
     filterRegex(RESOURCE_REGEX).through(GZipFilter.class);
     filter(PATTERN_RESTAPI,
       PATTERN_DEBUG).through(ApiBasicAuthenticationFilter.class);

scm-webapp/src/main/java/sonia/scm/web/security/ApiBasicAuthenticationFilter.java

@@ -39,11 +39,14 @@ import com.google.inject.Inject;
 import com.google.inject.Singleton;
 
 import sonia.scm.config.ScmConfiguration;
+import sonia.scm.web.filter.AutoLoginModule;
 import sonia.scm.web.filter.BasicAuthenticationFilter;
 
 //~--- JDK imports ------------------------------------------------------------
 
+
 import java.io.IOException;
+import java.util.Set;
 
 import javax.servlet.FilterChain;
 import javax.servlet.ServletException;
@@ -76,9 +79,10 @@ public class ApiBasicAuthenticationFilter extends BasicAuthenticationFilter
    * @param configuration
    */
   @Inject
-  public ApiBasicAuthenticationFilter(ScmConfiguration configuration)
+  public ApiBasicAuthenticationFilter(ScmConfiguration configuration,
+			Set<AutoLoginModule> autoLoginModules)
   {
-    super(configuration);
+    super(configuration, autoLoginModules);
   }
 
   //~--- methods --------------------------------------------------------------

scm-webapp/src/main/java/sonia/scm/web/security/ChainAuthenticatonManager.java

@@ -29,8 +29,6 @@
  *
  */
 
-
-
 package sonia.scm.web.security;
 
 //~--- non-JDK imports --------------------------------------------------------
@@ -70,17 +68,17 @@ import javax.servlet.http.HttpServletResponse;
  * @author Sebastian Sdorra
  */
 @Singleton
-public class ChainAuthenticatonManager extends AbstractAuthenticationManager
+public class ChainAuthenticatonManager extends AbstractAuthenticationManager {
-{
 
 	/** Field description */
 	public static final String CACHE_NAME = "sonia.cache.auth";
 
 	/** the logger for ChainAuthenticatonManager */
-  private static final Logger logger =
+	private static final Logger logger = LoggerFactory
-    LoggerFactory.getLogger(ChainAuthenticatonManager.class);
+			.getLogger(ChainAuthenticatonManager.class);
 
-  //~--- constructors ---------------------------------------------------------
+	// ~--- constructors
+	// ---------------------------------------------------------
 
 	/**
 	 * Constructs ...
@@ -98,22 +96,22 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 	public ChainAuthenticatonManager(UserManager userManager,
 			Set<AuthenticationHandler> authenticationHandlerSet,
 			EncryptionHandler encryptionHandler, CacheManager cacheManager,
-    Set<AuthenticationListener> authenticationListeners)
+			Set<AuthenticationListener> authenticationListeners) {
-  {
 		AssertUtil.assertIsNotEmpty(authenticationHandlerSet);
 		AssertUtil.assertIsNotNull(cacheManager);
-    this.authenticationHandlers = sort(userManager, authenticationHandlerSet);
+		this.authenticationHandlers = sort(userManager,
+				authenticationHandlerSet);
 		this.encryptionHandler = encryptionHandler;
 		this.cache = cacheManager.getCache(String.class,
 				AuthenticationCacheValue.class, CACHE_NAME);
 
-    if (Util.isNotEmpty(authenticationListeners))
+		if (Util.isNotEmpty(authenticationListeners)) {
-    {
 			addListeners(authenticationListeners);
 		}
 	}
 
-  //~--- methods --------------------------------------------------------------
+	// ~--- methods
+	// --------------------------------------------------------------
 
 	/**
 	 * Method description
@@ -128,32 +126,27 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 	 */
 	@Override
 	public AuthenticationResult authenticate(HttpServletRequest request,
-    HttpServletResponse response, String username, String password)
+			HttpServletResponse response, String username, String password) {
-  {
 		AssertUtil.assertIsNotEmpty(username);
 		AssertUtil.assertIsNotEmpty(password);
 
 		String encryptedPassword = encryptionHandler.encrypt(password);
 		AuthenticationResult ar = getCached(username, encryptedPassword);
 
-    if (ar == null)
+		if (ar == null) {
-    {
+			if (logger.isTraceEnabled()) {
-      if (logger.isTraceEnabled())
+				logger.trace(
-      {
+						"no authentication result for user {} found in cache",
-        logger.trace("no authentication result for user {} found in cache",
 						username);
 			}
 
 			ar = doAuthentication(request, response, username, password);
 
-      if ((ar != null) && ar.isCacheable())
+			if ((ar != null) && ar.isCacheable()) {
-      {
+				cache.put(username, new AuthenticationCacheValue(ar,
-        cache.put(username,
+						encryptedPassword));
-          new AuthenticationCacheValue(ar, encryptedPassword));
 			}
-    }
+		} else if (logger.isDebugEnabled()) {
-    else if (logger.isDebugEnabled())
-    {
 			logger.debug("authenticate {} via cache", username);
 		}
 
@@ -167,12 +160,9 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 	 * @throws IOException
 	 */
 	@Override
-  public void close() throws IOException
+	public void close() throws IOException {
-  {
+		for (AuthenticationHandler authenticator : authenticationHandlers) {
-    for (AuthenticationHandler authenticator : authenticationHandlers)
+			if (logger.isTraceEnabled()) {
-    {
-      if (logger.isTraceEnabled())
-      {
 				logger.trace("close authenticator {}", authenticator.getClass());
 			}
 
@@ -187,13 +177,11 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 	 * @param context
 	 */
 	@Override
-  public void init(SCMContextProvider context)
+	public void init(SCMContextProvider context) {
-  {
+		for (AuthenticationHandler authenticator : authenticationHandlers) {
-    for (AuthenticationHandler authenticator : authenticationHandlers)
+			if (logger.isTraceEnabled()) {
-    {
+				logger.trace("initialize authenticator {}",
-      if (logger.isTraceEnabled())
+						authenticator.getClass());
-      {
-        logger.trace("initialize authenticator {}", authenticator.getClass());
 			}
 
 			authenticator.init(context);
@@ -212,40 +200,33 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 	 * @return
 	 */
 	private AuthenticationResult doAuthentication(HttpServletRequest request,
-    HttpServletResponse response, String username, String password)
+			HttpServletResponse response, String username, String password) {
-  {
 		AuthenticationResult ar = null;
 
-    if (logger.isTraceEnabled())
+		if (logger.isTraceEnabled()) {
-    {
 			logger.trace("start authentication chain for user {}", username);
 		}
 
-    for (AuthenticationHandler authenticator : authenticationHandlers)
+		for (AuthenticationHandler authenticator : authenticationHandlers) {
-    {
+			if (logger.isTraceEnabled()) {
-      if (logger.isTraceEnabled())
-      {
 				logger.trace("check authenticator {} for user {}",
 						authenticator.getClass(), username);
 			}
 
-      try
+			try {
-      {
+				AuthenticationResult result = authenticator.authenticate(
-        AuthenticationResult result = authenticator.authenticate(request,
+						request, response, username, password);
-                                        response, username, password);
 
-        if (logger.isDebugEnabled())
+				if (logger.isDebugEnabled()) {
-        {
 					logger.debug("authenticator {} ends with result, {}",
 							authenticator.getClass().getName(), result);
 				}
 
+				// CR: Removed check on state=failed to allow next module to
+				// continue
 				if ((result != null) && (result.getState() != null)
-          && (result.getState().isSuccessfully()
+						&& result.getState().isSuccessfully()) {
-            || (result.getState() == AuthenticationState.FAILED)))
+					if (result.getUser() != null) {
-        {
-          if (result.getState().isSuccessfully() && (result.getUser() != null))
-          {
 						User user = result.getUser();
 
 						user.setType(authenticator.getType());
@@ -257,12 +238,9 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 
 					break;
 				}
-      }
+			} catch (Exception ex) {
-      catch (Exception ex)
+				logger.error("error durring authentication process of "
-      {
+						.concat(authenticator.getClass().getName()), ex);
-        logger.error(
-          "error durring authentication process of ".concat(
-            authenticator.getClass().getName()), ex);
 			}
 		}
 
@@ -280,21 +258,16 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 	 */
 	@VisibleForTesting
 	private List<AuthenticationHandler> sort(UserManager userManager,
-    Set<AuthenticationHandler> authenticationHandlerSet)
+			Set<AuthenticationHandler> authenticationHandlerSet) {
-  {
+		List<AuthenticationHandler> handlers = Lists
-    List<AuthenticationHandler> handlers =
+				.newArrayListWithCapacity(authenticationHandlerSet.size());
-      Lists.newArrayListWithCapacity(authenticationHandlerSet.size());
 
 		String first = Strings.nullToEmpty(userManager.getDefaultType());
 
-    for (AuthenticationHandler handler : authenticationHandlerSet)
+		for (AuthenticationHandler handler : authenticationHandlerSet) {
-    {
+			if (first.equals(handler.getType())) {
-      if (first.equals(handler.getType()))
-      {
 				handlers.add(0, handler);
-      }
+			} else {
-      else
-      {
 				handlers.add(handler);
 			}
 		}
@@ -302,7 +275,8 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 		return handlers;
 	}
 
-  //~--- get methods ----------------------------------------------------------
+	// ~--- get methods
+	// ----------------------------------------------------------
 
 	/**
 	 * Method description
@@ -314,17 +288,14 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 	 * @return
 	 */
 	private AuthenticationResult getCached(String username,
-    String encryptedPassword)
+			String encryptedPassword) {
-  {
 		AuthenticationResult result = null;
 		AuthenticationCacheValue value = cache.get(username);
 
-    if (value != null)
+		if (value != null) {
-    {
 			String cachedPassword = value.password;
 
-      if (cachedPassword.equals(encryptedPassword))
+			if (cachedPassword.equals(encryptedPassword)) {
-      {
 				result = value.authenticationResult;
 			}
 		}
@@ -332,7 +303,8 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 		return result;
 	}
 
-  //~--- inner classes --------------------------------------------------------
+	// ~--- inner classes
+	// --------------------------------------------------------
 
 	/**
 	 * Class description
@@ -341,13 +313,13 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 	 * @version Enter version here..., 2011-01-15
 	 * @author Sebastian Sdorra
 	 */
-  private static class AuthenticationCacheValue implements Serializable
+	private static class AuthenticationCacheValue implements Serializable {
-  {
 
 		/** Field description */
 		private static final long serialVersionUID = 2201116145941277549L;
 
-    //~--- constructors -------------------------------------------------------
+		// ~--- constructors
+		// -------------------------------------------------------
 
 		/**
 		 * Constructs ...
@@ -357,15 +329,14 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 		 * @param ar
 		 * @param password
 		 */
-    public AuthenticationCacheValue(AuthenticationResult ar, String password)
+		public AuthenticationCacheValue(AuthenticationResult ar, String password) {
-    {
+			this.authenticationResult = new AuthenticationResult(ar.getUser()
-      this.authenticationResult =
+					.clone(), ar.getGroups(), ar.getState());
-        new AuthenticationResult(ar.getUser().clone(), ar.getGroups(),
-          ar.getState());
 			this.password = password;
 		}
 
-    //~--- fields -------------------------------------------------------------
+		// ~--- fields
+		// -------------------------------------------------------------
 
 		/** Field description */
 		private AuthenticationResult authenticationResult;
@@ -374,8 +345,8 @@ public class ChainAuthenticatonManager extends AbstractAuthenticationManager
 		private String password;
 	}
 
-
+	// ~--- fields
-  //~--- fields ---------------------------------------------------------------
+	// ---------------------------------------------------------------
 
 	/** Field description */
 	private List<AuthenticationHandler> authenticationHandlers;