Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-08 22:45:45 +01:00
Code Issues Packages Projects Releases Activity

Fix review findings

Browse Source
This commit is contained in:
Florian Scholdei
2020-10-20 10:18:44 +02:00
parent ed4a564677
commit 27d4b0a755
4 changed files with 44 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
scm-ui/ui-webapp/src/repos/sources/components/content/SourcecodeViewer.tsx
View File

@@ -37,32 +37,25 @@ const SourcecodeViewer: FC<Props> = ({ file, language }) => {
const [currentFileRevision, setCurrentFileRevision] = useState("");
useEffect(() => {
function fetchContent() {
if (file.revision !== currentFileRevision) {
getContent((file._links.self as Link).href)
.then(content => {
setLoading(false);
setContent(content);
setCurrentFileRevision(file.revision);
})
.catch(error => {
setLoading(false);
setError(error);
});
})
.catch(setError);
}
if (file.revision !== currentFileRevision) {
fetchContent();
}
});
if (loading) {
return <Loading />;
}
}, [currentFileRevision, file]);
if (error) {
return <ErrorNotification error={error} />;
}
if (loading) {
return <Loading />;
}
if (!content) {
return null;
}