Feature/harmonize translation keys (#1478)

Harmonize translation keys

Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>

scm-ui/ui-webapp/src/repos/permissions/components/PermissionsTable.tsx

@@ -0,0 +1,89 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2020-present Cloudogu GmbH and Contributors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+import React, { FC } from "react";
+import { useTranslation } from "react-i18next";
+import { LabelWithHelpIcon, Notification } from "@scm-manager/ui-components";
+import SinglePermission from "../containers/SinglePermission";
+import { PermissionCollection, RepositoryRole } from "@scm-manager/ui-types";
+
+type Props = {
+  availableRepositoryRoles: RepositoryRole[];
+  availableVerbs: string[];
+  namespace: string;
+  repoName?: string;
+  permissions: PermissionCollection;
+};
+
+const PermissionsTable: FC<Props> = ({
+  availableRepositoryRoles,
+  availableVerbs,
+  namespace,
+  repoName,
+  permissions,
+}) => {
+  const [t] = useTranslation("repos");
+
+  if (permissions?.length === 0) {
+    return <Notification type="info">{t("permission.noPermissions")}</Notification>;
+  }
+
+  return (
+    <table className="card-table table is-hoverable is-fullwidth">
+      <thead>
+        <tr>
+          <th>
+            <LabelWithHelpIcon label={t("permission.name")} helpText={t("permission.help.nameHelpText")} />
+          </th>
+          <th>
+            <LabelWithHelpIcon label={t("permission.role")} helpText={t("permission.help.roleHelpText")} />
+          </th>
+          <th>
+            <LabelWithHelpIcon
+              label={t("permission.permissions")}
+              helpText={t("permission.help.permissionsHelpText")}
+            />
+          </th>
+          <th />
+        </tr>
+      </thead>
+      <tbody>
+        {permissions.map((permission) => {
+          return (
+            <SinglePermission
+              availableRepositoryRoles={availableRepositoryRoles}
+              availableRepositoryVerbs={availableVerbs}
+              key={permission.name + permission.groupPermission.toString()}
+              namespace={namespace}
+              repoName={repoName}
+              permission={permission}
+            />
+          );
+        })}
+      </tbody>
+    </table>
+  );
+};
+
+export default PermissionsTable;

scm-ui/ui-webapp/src/repos/permissions/containers/Permissions.tsx

@@ -45,9 +45,8 @@ import {
   isFetchPermissionsPending,
   modifyPermissionReset
 } from "../modules/permissions";
-import { ErrorPage, LabelWithHelpIcon, Loading, Subtitle } from "@scm-manager/ui-components";
+import { ErrorPage, Loading, Subtitle } from "@scm-manager/ui-components";
 import { Permission, PermissionCollection, PermissionCreateEntry, RepositoryRole } from "@scm-manager/ui-types";
-import SinglePermission from "./SinglePermission";
 import CreatePermissionForm from "./CreatePermissionForm";
 import { History } from "history";
 import { getPermissionsLink } from "../../modules/repos";
@@ -57,6 +56,7 @@ import {
   getRepositoryVerbsLink,
   getUserAutoCompleteLink
 } from "../../../modules/indexResource";
+import PermissionsTable from "../components/PermissionsTable";
 type Props = WithTranslation & {
   availablePermissions: boolean;
   availableRepositoryRoles: RepositoryRole[];
@@ -147,7 +147,7 @@ class Permissions extends React.Component<Props> {
       <CreatePermissionForm
         availableRoles={availableRepositoryRoles}
         availableVerbs={availableVerbs}
-        createPermission={permission => this.createPermission(permission)}
+        createPermission={(permission) => this.createPermission(permission)}
         loading={loadingCreatePermission}
         currentPermissions={permissions}
         userAutocompleteLink={userAutocompleteLink}
@@ -158,39 +158,7 @@ class Permissions extends React.Component<Props> {
     return (
       <div>
         <Subtitle subtitle={t("permission.title")} />
-        <table className="card-table table is-hoverable is-fullwidth">
-          <thead>
-            <tr>
-              <th>
-                <LabelWithHelpIcon label={t("permission.name")} helpText={t("permission.help.nameHelpText")} />
-              </th>
-              <th>
-                <LabelWithHelpIcon label={t("permission.role")} helpText={t("permission.help.roleHelpText")} />
-              </th>
-              <th>
-                <LabelWithHelpIcon
-                  label={t("permission.permissions")}
-                  helpText={t("permission.help.permissionsHelpText")}
-                />
-              </th>
-              <th />
-            </tr>
-          </thead>
-          <tbody>
-            {permissions.map(permission => {
-              return (
-                <SinglePermission
-                  availableRepositoryRoles={availableRepositoryRoles}
-                  availableRepositoryVerbs={availableVerbs}
-                  key={permission.name + permission.groupPermission.toString()}
-                  namespace={namespace}
-                  repoName={repoName}
-                  permission={permission}
-                />
-              );
-            })}
-          </tbody>
-        </table>
+        <PermissionsTable {...this.props} />
         {createPermissionForm}
       </div>
     );