diff --git a/scm-ui/ui-layout/src/card/Card.tsx b/scm-ui/ui-layout/src/card/Card.tsx index 50d0c886db..5eab439539 100644 --- a/scm-ui/ui-layout/src/card/Card.tsx +++ b/scm-ui/ui-layout/src/card/Card.tsx @@ -23,14 +23,9 @@ */ import React, { ComponentType, HTMLAttributes, ReactHTML, Ref } from "react"; -import styled from "styled-components"; import classNames from "classnames"; import CSS from "csstype"; -const CardRowsContainer = styled.div` - overflow: hidden; -`; - type Props = HTMLAttributes & { action?: React.ReactElement; /** @@ -61,12 +56,12 @@ const Card = React.forwardRef( ref, ...props, }, - {children} - , + , action ? {action} : null ) ); diff --git a/scm-ui/ui-layout/src/card/CardTitle.tsx b/scm-ui/ui-layout/src/card/CardTitle.tsx index a9a627738b..b5e2a28d22 100644 --- a/scm-ui/ui-layout/src/card/CardTitle.tsx +++ b/scm-ui/ui-layout/src/card/CardTitle.tsx @@ -23,7 +23,6 @@ */ import React, { HTMLAttributes } from "react"; -import classNames from "classnames"; type Props = HTMLAttributes & { /** @@ -46,11 +45,10 @@ type Props = HTMLAttributes & { * @beta * @since 2.44.0 */ -const CardTitle = React.forwardRef(({ children, level = 3, className, ...props }, ref) => +const CardTitle = React.forwardRef(({ children, level = 3, ...props }, ref) => React.createElement( `h${level}`, { - className: classNames(className, "is-ellipsis-overflow"), ref, ...props, }, diff --git a/scm-ui/ui-overlays/src/popover/Popover.stories.tsx b/scm-ui/ui-overlays/src/popover/Popover.stories.tsx index 20bf91ce15..2438e11a7c 100644 --- a/scm-ui/ui-overlays/src/popover/Popover.stories.tsx +++ b/scm-ui/ui-overlays/src/popover/Popover.stories.tsx @@ -33,6 +33,13 @@ export default { const Template: ComponentStory = (args) => ; +export const WithShortBody = Template.bind({}); +WithShortBody.args = { + trigger: , + title:

A title longer than the body

, + children:
very short body
, +}; + export const CiStatus = Template.bind({}); CiStatus.args = { trigger: ( diff --git a/scm-ui/ui-overlays/src/popover/Popover.tsx b/scm-ui/ui-overlays/src/popover/Popover.tsx index 3aa2546851..cc6ad909e7 100644 --- a/scm-ui/ui-overlays/src/popover/Popover.tsx +++ b/scm-ui/ui-overlays/src/popover/Popover.tsx @@ -78,8 +78,8 @@ const Popover = React.forwardRef(({ title, className, tri ref={ref} className={classNames("has-rounded-border", "p-2", "popover-content", "box", "popover", className)} > -
- {title} +
+ {title}