Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-13 00:45:44 +01:00
Code Issues Packages Projects Releases Activity

Cleanup code

Browse Source
This commit is contained in:
Rene Pfeuffer
2020-01-31 12:37:12 +01:00
parent 931133353d
commit 126b24b878
1 changed files with 25 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
scm-webapp/src/main/java/sonia/scm/plugin/SmpNodeBuilder.java
View File

@@ -13,29 +13,39 @@ class SmpNodeBuilder {
}
List<PluginNode> buildNodeTree(Collection<ExplodedSmp> smps) {
Set<String> availablePlugins = smps.stream().map(smp -> smp.getPlugin().getInformation().getName()).collect(Collectors.toSet());
Set<String> availablePlugins = getAvailablePluginNames(smps);
smps.forEach(smp -> this.assertDependenciesFulfilled(availablePlugins, smp));
List<PluginNode> nodes = smps.stream().map(PluginNode::new).collect(Collectors.toList());
List<PluginNode> nodes = createNodes(smps);
nodes.forEach(node -> {
ExplodedSmp smp = node.getPlugin();
nodes.forEach(otherNode -> {
nodes.forEach(node ->
nodes.forEach(otherNode -> appendIfDependsOnOtherNode(node, otherNode))
);
if (smp.getPlugin().getDependenciesInclusiveOptionals().contains(otherNode.getId())
&& !otherNode.getChildren().contains(node)) {
otherNode.addChild(node);
}
});
nodes.forEach(this::checkForCircle);
});
nodes.forEach(this::checkForCircle);
return nodes;
}
private Set<String> getAvailablePluginNames(Collection<ExplodedSmp> smps) {
return smps.stream()
.map(ExplodedSmp::getPlugin)
.map(InstalledPluginDescriptor::getInformation)
.map(PluginInformation::getName)
.collect(Collectors.toSet());
}
private void appendIfDependsOnOtherNode(PluginNode node, PluginNode otherNode) {
if (node.getPlugin().getPlugin().getDependenciesInclusiveOptionals().contains(otherNode.getId())
&& !otherNode.getChildren().contains(node)) {
otherNode.addChild(node);
}
}
private List<PluginNode> createNodes(Collection<ExplodedSmp> smps) {
return smps.stream().map(PluginNode::new).collect(Collectors.toList());
}
private void assertDependenciesFulfilled(Set<String> availablePlugins, ExplodedSmp smp) {
smp.getPlugin().getDependencies().forEach(dependency -> {
if (!availablePlugins.contains(dependency)) {