improve logging

scm-clients/scm-client-api/src/main/java/sonia/scm/client/ScmClient.java

@@ -35,6 +35,9 @@ package sonia.scm.client;
 
 //~--- non-JDK imports --------------------------------------------------------
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import sonia.scm.util.ServiceUtil;
 
 /**
@@ -47,6 +50,9 @@ public class ScmClient
   /** Field description */
   private static volatile ScmClientProvider provider = null;
 
+  /** the logger for ScmClient */
+  private static final Logger logger = LoggerFactory.getLogger(ScmClient.class);
+
   //~--- methods --------------------------------------------------------------
 
   /**
@@ -91,8 +97,10 @@ public class ScmClient
    *
    *
    * @return
+   *
+   * @throws ScmClientException
    */
-  private static ScmClientProvider getProvider()
+  private static ScmClientProvider getProvider() throws ScmClientException
   {
     if (provider == null)
     {
@@ -105,6 +113,16 @@ public class ScmClient
       }
     }
 
+    if (provider == null)
+    {
+      throw new ScmClientException("could not find a ScmClientProvider");
+    }
+    else if (logger.isInfoEnabled())
+    {
+      logger.info("create ScmClient with provider {}",
+                  provider.getClass().getName());
+    }
+
     return provider;
   }
 }

scm-clients/scm-client-api/src/main/java/sonia/scm/client/ScmUrlProvider.java

@@ -33,6 +33,11 @@
 
 package sonia.scm.client;
 
+//~--- non-JDK imports --------------------------------------------------------
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  *
  * @author Sebastian Sdorra
@@ -52,6 +57,10 @@ public class ScmUrlProvider
   /** Field description */
   public static final String URLPART_REPOSITORY = "repositories/";
 
+  /** the logger for classVar */
+  private static final Logger logger =
+    LoggerFactory.getLogger(ScmUrlProvider.class);
+
   //~--- constructors ---------------------------------------------------------
 
   /**
@@ -70,6 +79,11 @@ public class ScmUrlProvider
     {
       this.baseUrl = baseUrl;
     }
+
+    if (logger.isDebugEnabled())
+    {
+      logger.debug("create new url provider with baseurl {}", this.baseUrl);
+    }
   }
 
   //~--- get methods ----------------------------------------------------------
@@ -141,7 +155,14 @@ public class ScmUrlProvider
    */
   public String getResourceUrl(String urlPart)
   {
-    return baseUrl.concat(urlPart).concat(extension);
+    String resourceUrl = baseUrl.concat(urlPart).concat(extension);
+
+    if (logger.isTraceEnabled())
+    {
+      logger.trace("return resourceurl {}", resourceUrl);
+    }
+
+    return resourceUrl;
   }
 
   //~--- set methods ----------------------------------------------------------