rebuild sonia.navigation

scm-webapp/src/main/webapp/resources/css/style.css

@@ -102,3 +102,7 @@ a:visited {
   vertical-align: top;
   margin-left: 2px;
 }
+
+.scm-nav-item {
+  cursor: pointer;
+}

scm-webapp/src/main/webapp/resources/js/sonia.navigation.js

@@ -33,97 +33,89 @@ Ext.ns('Sonia.navigation');
 
 Sonia.navigation.NavSection = Ext.extend(Ext.Panel, {
 
-  data: null,
+  links: null,
+  tpl: new Ext.XTemplate(
+        '<ul class="scm-nav-list">',
+        '<tpl for="links">',
+            '<li class="scm-nav-item">',
+                '<a id="{id}" class="scm-nav-item">{label}</a>',
+            '</li>',
+        '</tpl>',
+        '</ul>'
+      ),
+
 
   initComponent: function(){
-    if ( this.data == null ){
+    if ( this.links == null ){
-      this.data = this.items;
+      this.links = this.items;
     }
-    if ( this.data == null ){
+    if ( this.links == null ){
-      this.data = [];
+      this.links = [];
     }
+
+    Ext.each(this.links, function(link){
+      Ext.id( link );
+    });
+
     var config = {
       frame: true,
       collapsible:true,
-      style: 'margin: 5px',
+      style: 'margin: 5px'
-      listeners: {
-        afterrender: {
-          fn: this.renderMenu,
-          scope: this
-        }
-      }
     }
 
     Ext.apply(this, Ext.apply(this.initialConfig, config));
     Sonia.navigation.NavSection.superclass.initComponent.apply(this, arguments);
-
   },
 
-  onItemClick: function(e, t){
+  doAction: function(e, t){
-    var target = Ext.get(t);
+    console.debug( t );
-    var id = target.id;
+    e.stopEvent();
-    var prefix = this.id + '-nav-item-';
+    Ext.each(this.links, function(navItem){
-    if ( id != null && id.indexOf(prefix) == 0 ){
+      if ( navItem.id == t.id && Ext.isFunction(navItem.fn) ){
-      var i = parseInt( id.substring( prefix.length ) );
+        var scope = navItem.scope;
-      var fn = this.data[i].fn;
-      if ( Ext.isFunction( fn ) ){
-        var scope = this.data[i].scope;
         if ( Ext.isObject( scope )){
-          fn.call(scope);
+          navItem.fn.call(scope);
         } else {
-          fn();
+          navItem.fn();
-        }
-      } else if ( debug ){
-        console.debug('fn at "' +  this.data[i].label + '" is not a function');
         }
       }
+    });
   },
   
-  renderMenu: function(){
+  afterRender: function(){
-    if ( Ext.isArray( this.data ) && this.data.length > 0 ){
+    Sonia.navigation.NavSection.superclass.afterRender.apply(this, arguments);
-      var links = [];
-      for ( var i=0; i<this.data.length; i++ ){
-        var item = this.data[i];
-        var link = {
-          tag: 'li',
-          cls: 'nav-item',
-          id: this.id + '-nav-item-' + i,
-          html: item.label,
-          style: 'cursor: pointer;'
-        };
-        links.push(link);
-      }
 
-      var dh = Ext.DomHelper;
+    // create list items
-      var list = dh.overwrite(this.body, {tag: 'ul', cls: 'nav-list'}, true);
+    this.tpl.overwrite(this.body, {
-      dh.append(list, links);
+        links: this.links
-      list.on('click', this.onItemClick, this);
+    });
-    }
+
+    this.body.on('mousedown', this.doAction, this, {delegate:'a'});
+    this.body.on('click', Ext.emptyFn, null, {delegate:'a', preventDefault:true});
   },
 
+
   addLink: function(link){
-    this.data.push(link);
+    Ext.id(link);
-    this.renderMenu();
+    this.links.push(link);
   },
 
   addLinks: function(links){
     if ( Ext.isArray(links) && links.length > 0 ){
       for ( var i=0; i<links.length; i++ ){
-        this.data.push(links[i]);
+        this.addLink(links[i]);
       }
-      this.renderMenu();
     } else {
       this.addLink(links);
     }
   },
 
   insertLink: function(pos, link){
-    this.data.splice(pos, 0, link);
+    this.links.splice(pos, 0, link);
-    this.renderMenu();
   },
 
   count: function(){
-    return this.data.length;
+    return this.links.length;
   }
 
 });

scm-webapp/src/main/webapp/resources/js/sonia.scm.js

@@ -95,7 +95,7 @@ Sonia.scm.Main = Ext.extend(Ext.util.Observable, {
     panel.addSection({
       id: 'navMain',
       title: this.sectionMainText,
-      items: [{
+      links: [{
         label: this.navRepositoriesText,
         fn: function(){
           this.mainTabPanel.setActiveTab('repositories');
@@ -109,7 +109,7 @@ Sonia.scm.Main = Ext.extend(Ext.util.Observable, {
     if ( state.user.type == 'xml' && state.user.name != 'anonymous' ){
       securitySection = {
         title: this.sectionSecurityText,
-        items: [{
+        links: [{
           label: this.navChangePasswordText,
           fn: function(){
             new Sonia.action.ChangePasswordWindow().show();
@@ -123,7 +123,7 @@ Sonia.scm.Main = Ext.extend(Ext.util.Observable, {
       panel.addSections([{
         id: 'navConfig',
         title: this.sectionConfigText,
-        items: [{
+        links: [{
           label: this.navGeneralConfigText,
           fn: function(){
             this.addTabPanel("scmConfig", "scmConfig", this.navGeneralConfigText);
@@ -147,18 +147,18 @@ Sonia.scm.Main = Ext.extend(Ext.util.Observable, {
       if ( securitySection == null ){
         securitySection = {
           title: this.sectionSecurityText,
-          items: []
+          links: []
         }
       }
 
-      securitySection.items.push({
+      securitySection.links.push({
         label: this.navUsersText,
         fn: function(){
           this.addTabPanel('users', 'userPanel', this.navUsersText);
         },
         scope: this
       });
-      securitySection.items.push({
+      securitySection.links.push({
         label: this.navGroupsText,
         fn: function(){
           this.addTabPanel('groups', 'groupPanel', this.tabGroupsText);
@@ -175,7 +175,7 @@ Sonia.scm.Main = Ext.extend(Ext.util.Observable, {
       panel.addSection({
         id: 'navLogin',
         title: this.sectionLoginText,
-        items: [{
+        links: [{
           label: this.sectionLoginText,
           fn: this.login,
           scope: this
@@ -185,7 +185,7 @@ Sonia.scm.Main = Ext.extend(Ext.util.Observable, {
       panel.addSection({
         id: 'navLogout',
         title: this.sectionLogoutText,
-        items: [{
+        links: [{
           label: this.navLogoutText,
           fn: this.logout,
           scope: this