clean up code, fix bugs, improve ux, add docs

2025-11-12 00:15:44 +01:00 · 2020-11-30 10:01:21 +01:00
parent ebc1120182
commit 032982857f
10 changed files with 99 additions and 16 deletions
--- a/scm-ui/ui-components/src/modals/CreateTagModal.tsx
+++ b/scm-ui/ui-components/src/modals/CreateTagModal.tsx
@@ -0,0 +1,104 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2020-present Cloudogu GmbH and Contributors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+import React, {FC, useEffect, useState} from "react";
+import { Modal, InputField, Button, apiClient } from "@scm-manager/ui-components";
+import { WithTranslation, withTranslation } from "react-i18next";
+import {Tag} from "@scm-manager/ui-types";
+import {isBranchValid} from "../validation";
+
+type Props = WithTranslation & {
+  existingTagsLink: string;
+  tagCreationLink: string;
+  onClose: () => void;
+  onCreated: () => void;
+  onError: (error: Error) => void;
+  revision: string;
+};
+
+const CreateTagModal: FC<Props> = ({ t, onClose, tagCreationLink, existingTagsLink, onCreated, onError, revision }) => {
+  const [newTagName, setNewTagName] = useState("");
+  const [loading, setLoading] = useState(false);
+  const [tagNames, setTagNames] = useState<string[]>([]);
+
+  useEffect(() => {
+    apiClient
+      .get(existingTagsLink)
+      .then(response => response.json())
+      .then(json => setTagNames(json._embedded.tags.map((tag: Tag) => tag.name)));
+  }, [existingTagsLink]);
+
+  const createTag = () => {
+    setLoading(true);
+    apiClient
+      .post(tagCreationLink, {
+        revision,
+        name: newTagName
+      })
+      .then(onCreated)
+      .catch(onError)
+      .finally(() => setLoading(false));
+  };
+
+  let validationError = "";
+
+  if (newTagName !== "") {
+    if (tagNames.includes(newTagName)) {
+      validationError = "tags.create.form.field.name.error.exists";
+    } else if (!isBranchValid(newTagName)) {
+      validationError = "tags.create.form.field.name.error.format";
+    }
+  }
+
+  return (
+    <Modal
+      title={t("tags.create.title")}
+      active={true}
+      body={
+        <>
+          <InputField
+            name="name"
+            label={t("tags.create.form.field.name.label")}
+            onChange={val => setNewTagName(val)}
+            value={newTagName}
+            validationError={!!validationError}
+            errorMessage={t(validationError)}
+          />
+          <div className="mt-6">{t("tags.create.hint")}</div>
+        </>
+      }
+      footer={
+        <>
+          <Button action={onClose}>{t("tags.create.cancel")}</Button>
+          <Button color="success" action={() => createTag()} loading={loading} disabled={!!validationError || newTagName.length === 0}>
+            {t("tags.create.confirm")}
+          </Button>
+        </>
+      }
+      closeFunction={onClose}
+    />
+  );
+};
+
+export default withTranslation("repos")(CreateTagModal);