Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-14 09:25:43 +01:00
Code Issues Packages Projects Releases Activity

Fix tracker

Browse Source
This commit is contained in:
René Pfeuffer
2019-09-16 17:49:21 +02:00
parent b2294b8ae1
commit 0243edf585
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scm-webapp/src/main/java/sonia/scm/plugin/PluginDependencyTracker.java
View File

@@ -27,16 +27,10 @@ class PluginDependencyTracker {
} }
private void addDependency(String from, String to) { private void addDependency(String from, String to) {
plugins.computeIfAbsent(to, name -> createInitialDependencyCollection(from)); plugins.computeIfAbsent(to, name -> new HashSet<>()).add(from);
} }
private void removeDependency(String from, String to) { private void removeDependency(String from, String to) {
plugins.get(to).remove(from); plugins.get(to).remove(from);
} }
private Collection<String> createInitialDependencyCollection(String from) {
Collection<String> dependencies = new HashSet<>();
dependencies.add(from);
return dependencies;
}
} }

2
scm-webapp/src/test/java/sonia/scm/plugin/PluginDependencyTrackerTest.java
View File

@@ -73,7 +73,7 @@ class PluginDependencyTrackerTest {
PluginDependencyTracker pluginDependencyTracker = new PluginDependencyTracker(); PluginDependencyTracker pluginDependencyTracker = new PluginDependencyTracker();
pluginDependencyTracker.addInstalled(review); pluginDependencyTracker.addInstalled(review);
pluginDependencyTracker.addInstalled(jira); pluginDependencyTracker.addInstalled(jira);
pluginDependencyTracker.removeInstalled(jira); pluginDependencyTracker.removeInstalled(review);
boolean mayUninstall = pluginDependencyTracker.mayUninstall("scm-mail-plugin"); boolean mayUninstall = pluginDependencyTracker.mayUninstall("scm-mail-plugin");
assertThat(mayUninstall).isFalse(); assertThat(mayUninstall).isFalse();