Files
SCM-Manager/docs/en/development/definition-of-done.md

14 lines
828 B
Markdown
Raw Normal View History

---
title: Definition of Done
---
2020-03-31 17:28:30 +02:00
2020-03-09 08:01:43 +01:00
* Acceptance criteria are checked manually (from the user's perspective)
* Code coverage is checked manually (>= 80% on new code) ([sonarcloud](https://sonarcloud.io/dashboard?id=sonia.scm%3Ascm))
* The clean code principles are respected ([CleanCode](https://clean-code-developer.com/virtues/))
* All new code/logic is implemented on the right spot / "Should i do this here?"
* Code of the story/feature/branch is merged to the mainline branch
* Build on mainline branch is green ([Jenkins](https://scm-manager.ci.cloudbees.com/job/scm-manager-2.x/))
* Integration test, wherever sensible, are implemented
* Code is reviewed according to the 4-eyes-principle (1 implementer, 1 reviewer, based on an average number of eyes per person of around 2)
2020-03-31 17:28:30 +02:00
* Documentation is updated whenever necessary