2018-07-31 10:53:44 +02:00
|
|
|
//@flow
|
|
|
|
|
import configureMockStore from "redux-mock-store";
|
|
|
|
|
import thunk from "redux-thunk";
|
|
|
|
|
import fetchMock from "fetch-mock";
|
|
|
|
|
|
2018-07-31 11:30:30 +02:00
|
|
|
import reducer, {
|
|
|
|
|
fetchGroups,
|
2018-07-31 13:04:09 +02:00
|
|
|
FETCH_GROUPS,
|
2018-07-31 10:53:44 +02:00
|
|
|
FETCH_GROUPS_PENDING,
|
|
|
|
|
FETCH_GROUPS_SUCCESS,
|
2018-07-31 11:30:30 +02:00
|
|
|
FETCH_GROUPS_FAILURE,
|
2018-07-31 13:04:09 +02:00
|
|
|
fetchGroupsSuccess,
|
|
|
|
|
isPermittedToCreateGroups,
|
|
|
|
|
getGroupsFromState,
|
|
|
|
|
getFetchGroupsFailure,
|
|
|
|
|
isFetchGroupsPending,
|
2018-07-31 13:49:46 +02:00
|
|
|
selectListAsCollection,
|
2018-07-31 15:09:45 +02:00
|
|
|
fetchGroup,
|
|
|
|
|
FETCH_GROUP_PENDING,
|
|
|
|
|
FETCH_GROUP_SUCCESS,
|
|
|
|
|
FETCH_GROUP_FAILURE,
|
|
|
|
|
fetchGroupSuccess,
|
|
|
|
|
getFetchGroupFailure,
|
|
|
|
|
FETCH_GROUP,
|
|
|
|
|
isFetchGroupPending,
|
|
|
|
|
getGroupByName,
|
2018-07-31 13:49:46 +02:00
|
|
|
createGroup,
|
|
|
|
|
CREATE_GROUP_SUCCESS,
|
|
|
|
|
CREATE_GROUP_PENDING,
|
2018-07-31 14:22:15 +02:00
|
|
|
CREATE_GROUP_FAILURE,
|
|
|
|
|
isCreateGroupPending,
|
|
|
|
|
CREATE_GROUP,
|
|
|
|
|
getCreateGroupFailure
|
2018-07-31 13:49:46 +02:00
|
|
|
} from "./groups";
|
2018-07-31 10:53:44 +02:00
|
|
|
const GROUPS_URL = "/scm/api/rest/v2/groups";
|
|
|
|
|
|
2018-07-31 13:04:09 +02:00
|
|
|
const error = new Error("You have an error!");
|
|
|
|
|
|
2018-07-31 15:09:45 +02:00
|
|
|
const humanGroup = {
|
2018-07-31 11:30:30 +02:00
|
|
|
creationDate: "2018-07-31T08:39:07.860Z",
|
|
|
|
|
description: "This is a group",
|
2018-07-31 15:09:45 +02:00
|
|
|
name: "humanGroup",
|
2018-07-31 11:30:30 +02:00
|
|
|
type: "xml",
|
|
|
|
|
properties: {},
|
|
|
|
|
members: ["userZaphod"],
|
|
|
|
|
_links: {
|
|
|
|
|
self: {
|
2018-07-31 15:09:45 +02:00
|
|
|
href: "http://localhost:3000/scm/api/rest/v2/groups/humanGroup"
|
2018-07-31 11:30:30 +02:00
|
|
|
},
|
|
|
|
|
delete: {
|
2018-07-31 15:09:45 +02:00
|
|
|
href: "http://localhost:3000/scm/api/rest/v2/groups/humanGroup"
|
2018-07-31 11:30:30 +02:00
|
|
|
},
|
|
|
|
|
update: {
|
2018-07-31 15:09:45 +02:00
|
|
|
href:"http://localhost:3000/scm/api/rest/v2/groups/humanGroup"
|
2018-07-31 11:30:30 +02:00
|
|
|
}
|
|
|
|
|
},
|
|
|
|
|
_embedded: {
|
2018-07-31 13:49:46 +02:00
|
|
|
members: [
|
|
|
|
|
{
|
|
|
|
|
name: "userZaphod",
|
|
|
|
|
_links: {
|
|
|
|
|
self: {
|
|
|
|
|
href: "http://localhost:3000/scm/api/rest/v2/users/userZaphod"
|
|
|
|
|
}
|
2018-07-31 11:30:30 +02:00
|
|
|
}
|
|
|
|
|
}
|
2018-07-31 13:49:46 +02:00
|
|
|
]
|
2018-07-31 11:30:30 +02:00
|
|
|
}
|
2018-07-31 10:53:44 +02:00
|
|
|
};
|
|
|
|
|
|
2018-07-31 15:09:45 +02:00
|
|
|
const emptyGroup = {
|
2018-07-31 11:30:30 +02:00
|
|
|
creationDate: "2018-07-31T08:39:07.860Z",
|
|
|
|
|
description: "This is a group",
|
2018-07-31 15:09:45 +02:00
|
|
|
name: "emptyGroup",
|
2018-07-31 11:30:30 +02:00
|
|
|
type: "xml",
|
|
|
|
|
properties: {},
|
|
|
|
|
members: [],
|
|
|
|
|
_links: {
|
|
|
|
|
self: {
|
2018-07-31 15:09:45 +02:00
|
|
|
href: "http://localhost:3000/scm/api/rest/v2/groups/emptyGroup"
|
2018-07-31 11:30:30 +02:00
|
|
|
},
|
|
|
|
|
delete: {
|
2018-07-31 15:09:45 +02:00
|
|
|
href: "http://localhost:3000/scm/api/rest/v2/groups/emptyGroup"
|
2018-07-31 11:30:30 +02:00
|
|
|
},
|
|
|
|
|
update: {
|
2018-07-31 15:09:45 +02:00
|
|
|
href:"http://localhost:3000/scm/api/rest/v2/groups/emptyGroup"
|
2018-07-31 11:30:30 +02:00
|
|
|
}
|
|
|
|
|
},
|
|
|
|
|
_embedded: {
|
|
|
|
|
members: []
|
|
|
|
|
}
|
2018-07-31 10:53:44 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const responseBody = {
|
|
|
|
|
page: 0,
|
|
|
|
|
pageTotal: 1,
|
|
|
|
|
_links: {
|
|
|
|
|
self: {
|
|
|
|
|
href: "http://localhost:3000/scm/api/rest/v2/groups/?page=0&pageSize=10"
|
|
|
|
|
},
|
|
|
|
|
first: {
|
|
|
|
|
href: "http://localhost:3000/scm/api/rest/v2/groups/?page=0&pageSize=10"
|
|
|
|
|
},
|
|
|
|
|
last: {
|
|
|
|
|
href: "http://localhost:3000/scm/api/rest/v2/groups/?page=0&pageSize=10"
|
|
|
|
|
},
|
|
|
|
|
create: {
|
|
|
|
|
href: "http://localhost:3000/scm/api/rest/v2/groups/"
|
|
|
|
|
}
|
|
|
|
|
},
|
|
|
|
|
_embedded: {
|
2018-07-31 15:09:45 +02:00
|
|
|
groups: [humanGroup, emptyGroup]
|
2018-07-31 10:53:44 +02:00
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const response = {
|
|
|
|
|
headers: { "content-type": "application/json" },
|
|
|
|
|
responseBody
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
describe("groups fetch()", () => {
|
|
|
|
|
const mockStore = configureMockStore([thunk]);
|
|
|
|
|
afterEach(() => {
|
|
|
|
|
fetchMock.reset();
|
|
|
|
|
fetchMock.restore();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should successfully fetch groups", () => {
|
|
|
|
|
fetchMock.getOnce(GROUPS_URL, response);
|
|
|
|
|
|
|
|
|
|
const expectedActions = [
|
|
|
|
|
{ type: FETCH_GROUPS_PENDING },
|
|
|
|
|
{
|
|
|
|
|
type: FETCH_GROUPS_SUCCESS,
|
|
|
|
|
payload: response
|
|
|
|
|
}
|
|
|
|
|
];
|
|
|
|
|
|
|
|
|
|
const store = mockStore({});
|
|
|
|
|
|
|
|
|
|
return store.dispatch(fetchGroups()).then(() => {
|
|
|
|
|
expect(store.getActions()).toEqual(expectedActions);
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should fail getting groups on HTTP 500", () => {
|
|
|
|
|
fetchMock.getOnce(GROUPS_URL, {
|
|
|
|
|
status: 500
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const store = mockStore({});
|
|
|
|
|
return store.dispatch(fetchGroups()).then(() => {
|
|
|
|
|
const actions = store.getActions();
|
|
|
|
|
expect(actions[0].type).toEqual(FETCH_GROUPS_PENDING);
|
|
|
|
|
expect(actions[1].type).toEqual(FETCH_GROUPS_FAILURE);
|
|
|
|
|
expect(actions[1].payload).toBeDefined();
|
|
|
|
|
});
|
|
|
|
|
});
|
2018-07-31 13:49:46 +02:00
|
|
|
|
2018-07-31 15:09:45 +02:00
|
|
|
it("should sucessfully fetch single group", () => {
|
|
|
|
|
fetchMock.getOnce(GROUPS_URL + "/humandGroup", humanGroup);
|
|
|
|
|
|
|
|
|
|
const store = mockStore({});
|
|
|
|
|
return store.dispatch(fetchGroup("humandGroup")).then(() => {
|
|
|
|
|
const actions = store.getActions();
|
|
|
|
|
expect(actions[0].type).toEqual(FETCH_GROUP_PENDING);
|
|
|
|
|
expect(actions[1].type).toEqual(FETCH_GROUP_SUCCESS);
|
|
|
|
|
expect(actions[1].payload).toBeDefined();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should fail fetching single group on HTTP 500", () => {
|
|
|
|
|
fetchMock.getOnce(GROUPS_URL + "/humandGroup", {
|
|
|
|
|
status: 500
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const store = mockStore({});
|
|
|
|
|
return store.dispatch(fetchGroup("humandGroup")).then(() => {
|
|
|
|
|
const actions = store.getActions();
|
|
|
|
|
expect(actions[0].type).toEqual(FETCH_GROUP_PENDING);
|
|
|
|
|
expect(actions[1].type).toEqual(FETCH_GROUP_FAILURE);
|
|
|
|
|
expect(actions[1].payload).toBeDefined();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
|
2018-07-31 13:49:46 +02:00
|
|
|
it("should successfully create group", () => {
|
|
|
|
|
fetchMock.postOnce(GROUPS_URL, {
|
|
|
|
|
status: 201
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const store = mockStore({});
|
2018-07-31 15:09:45 +02:00
|
|
|
return store.dispatch(createGroup(humanGroup)).then(() => {
|
2018-07-31 13:49:46 +02:00
|
|
|
const actions = store.getActions();
|
|
|
|
|
expect(actions[0].type).toEqual(CREATE_GROUP_PENDING);
|
|
|
|
|
expect(actions[1].type).toEqual(CREATE_GROUP_SUCCESS);
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should fail creating group on HTTP 500", () => {
|
|
|
|
|
fetchMock.postOnce(GROUPS_URL, {
|
|
|
|
|
status: 500
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const store = mockStore({});
|
2018-07-31 15:09:45 +02:00
|
|
|
return store.dispatch(createGroup(humanGroup)).then(() => {
|
2018-07-31 13:49:46 +02:00
|
|
|
const actions = store.getActions();
|
|
|
|
|
expect(actions[0].type).toEqual(CREATE_GROUP_PENDING);
|
|
|
|
|
expect(actions[1].type).toEqual(CREATE_GROUP_FAILURE);
|
|
|
|
|
expect(actions[1].payload).toBeDefined();
|
|
|
|
|
expect(actions[1].payload instanceof Error).toBeTruthy();
|
|
|
|
|
});
|
|
|
|
|
});
|
2018-07-31 10:53:44 +02:00
|
|
|
});
|
2018-07-31 11:30:30 +02:00
|
|
|
|
|
|
|
|
describe("groups reducer", () => {
|
2018-07-31 15:09:45 +02:00
|
|
|
|
|
|
|
|
it("should update state correctly according to FETCH_GROUPS_SUCCESS action", () => {
|
|
|
|
|
|
2018-07-31 11:30:30 +02:00
|
|
|
const newState = reducer({}, fetchGroupsSuccess(responseBody));
|
|
|
|
|
|
|
|
|
|
expect(newState.list).toEqual({
|
2018-07-31 15:09:45 +02:00
|
|
|
entries: ["humanGroup", "emptyGroup"],
|
2018-07-31 11:30:30 +02:00
|
|
|
entry: {
|
|
|
|
|
groupCreatePermission: true,
|
|
|
|
|
page: 0,
|
|
|
|
|
pageTotal: 1,
|
|
|
|
|
_links: responseBody._links
|
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(newState.byNames).toEqual({
|
2018-07-31 15:09:45 +02:00
|
|
|
humanGroup: humanGroup,
|
|
|
|
|
emptyGroup: emptyGroup
|
2018-07-31 11:30:30 +02:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(newState.list.entry.groupCreatePermission).toBeTruthy();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should set groupCreatePermission to true if update link is present", () => {
|
|
|
|
|
const newState = reducer({}, fetchGroupsSuccess(responseBody));
|
|
|
|
|
|
|
|
|
|
expect(newState.list.entry.groupCreatePermission).toBeTruthy();
|
|
|
|
|
});
|
|
|
|
|
|
2018-07-31 15:09:45 +02:00
|
|
|
it("should not replace whole byNames map when fetching groups", () => {
|
2018-07-31 11:30:30 +02:00
|
|
|
const oldState = {
|
|
|
|
|
byNames: {
|
2018-07-31 15:09:45 +02:00
|
|
|
emptyGroup: emptyGroup
|
2018-07-31 11:30:30 +02:00
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const newState = reducer(oldState, fetchGroupsSuccess(responseBody));
|
2018-07-31 15:09:45 +02:00
|
|
|
expect(newState.byNames["humanGroup"]).toBeDefined();
|
|
|
|
|
expect(newState.byNames["emptyGroup"]).toBeDefined();
|
2018-07-31 11:30:30 +02:00
|
|
|
});
|
|
|
|
|
|
2018-07-31 15:09:45 +02:00
|
|
|
it("should set groupCreatePermission to true if create link is present", () => {
|
2018-07-31 11:30:30 +02:00
|
|
|
const newState = reducer({}, fetchGroupsSuccess(responseBody));
|
|
|
|
|
|
|
|
|
|
expect(newState.list.entry.groupCreatePermission).toBeTruthy();
|
2018-07-31 15:09:45 +02:00
|
|
|
expect(newState.list.entries).toEqual(["humanGroup", "emptyGroup"]);
|
|
|
|
|
expect(newState.byNames["emptyGroup"]).toBeTruthy();
|
|
|
|
|
expect(newState.byNames["humanGroup"]).toBeTruthy();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
it("should update state according to FETCH_GROUP_SUCCESS action", () => {
|
|
|
|
|
const newState = reducer({}, fetchGroupSuccess(emptyGroup));
|
|
|
|
|
expect(newState.byNames["emptyGroup"]).toBe(emptyGroup);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should affect groups state nor the state of other groups", () => {
|
|
|
|
|
const newState = reducer(
|
|
|
|
|
{
|
|
|
|
|
list: {
|
|
|
|
|
entries: ["humanGroup"]
|
|
|
|
|
}
|
|
|
|
|
},
|
|
|
|
|
fetchGroupSuccess(emptyGroup)
|
|
|
|
|
);
|
|
|
|
|
expect(newState.byNames["emptyGroup"]).toBe(emptyGroup);
|
|
|
|
|
expect(newState.list.entries).toEqual(["humanGroup"]);
|
2018-07-31 11:30:30 +02:00
|
|
|
});
|
2018-07-31 15:09:45 +02:00
|
|
|
|
2018-07-31 11:30:30 +02:00
|
|
|
});
|
2018-07-31 13:04:09 +02:00
|
|
|
|
|
|
|
|
describe("selector tests", () => {
|
|
|
|
|
it("should return an empty object", () => {
|
|
|
|
|
expect(selectListAsCollection({})).toEqual({});
|
|
|
|
|
expect(selectListAsCollection({ groups: { a: "a" } })).toEqual({});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return a state slice collection", () => {
|
|
|
|
|
const collection = {
|
|
|
|
|
page: 3,
|
|
|
|
|
totalPages: 42
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const state = {
|
|
|
|
|
groups: {
|
|
|
|
|
list: {
|
|
|
|
|
entry: collection
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
expect(selectListAsCollection(state)).toBe(collection);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return false", () => {
|
|
|
|
|
expect(isPermittedToCreateGroups({})).toBe(false);
|
|
|
|
|
expect(isPermittedToCreateGroups({ groups: { list: { entry: {} } } })).toBe(
|
|
|
|
|
false
|
|
|
|
|
);
|
|
|
|
|
expect(
|
|
|
|
|
isPermittedToCreateGroups({
|
|
|
|
|
groups: { list: { entry: { groupCreatePermission: false } } }
|
|
|
|
|
})
|
|
|
|
|
).toBe(false);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return true", () => {
|
|
|
|
|
const state = {
|
|
|
|
|
groups: {
|
|
|
|
|
list: {
|
|
|
|
|
entry: {
|
|
|
|
|
groupCreatePermission: true
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
expect(isPermittedToCreateGroups(state)).toBe(true);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should get groups from state", () => {
|
|
|
|
|
const state = {
|
|
|
|
|
groups: {
|
|
|
|
|
list: {
|
|
|
|
|
entries: ["a", "b"]
|
|
|
|
|
},
|
|
|
|
|
byNames: {
|
|
|
|
|
a: { name: "a" },
|
|
|
|
|
b: { name: "b" }
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
expect(getGroupsFromState(state)).toEqual([{ name: "a" }, { name: "b" }]);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return true, when fetch groups is pending", () => {
|
|
|
|
|
const state = {
|
|
|
|
|
pending: {
|
|
|
|
|
[FETCH_GROUPS]: true
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
expect(isFetchGroupsPending(state)).toEqual(true);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return false, when fetch groups is not pending", () => {
|
|
|
|
|
expect(isFetchGroupsPending({})).toEqual(false);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return error when fetch groups did fail", () => {
|
|
|
|
|
const state = {
|
|
|
|
|
failure: {
|
|
|
|
|
[FETCH_GROUPS]: error
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
expect(getFetchGroupsFailure(state)).toEqual(error);
|
|
|
|
|
});
|
|
|
|
|
|
2018-07-31 15:09:45 +02:00
|
|
|
it("should return undefined when fetch groups did not fail", () => {
|
2018-07-31 13:04:09 +02:00
|
|
|
expect(getFetchGroupsFailure({})).toBe(undefined);
|
|
|
|
|
});
|
2018-07-31 14:22:15 +02:00
|
|
|
|
2018-07-31 15:09:45 +02:00
|
|
|
it("should return group emptyGroup", () => {
|
|
|
|
|
const state = {
|
|
|
|
|
groups: {
|
|
|
|
|
byNames: {
|
|
|
|
|
emptyGroup: emptyGroup
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
expect(getGroupByName(state, "emptyGroup")).toEqual(emptyGroup);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return true, when fetch group humandGroup is pending", () => {
|
|
|
|
|
const state = {
|
|
|
|
|
pending: {
|
|
|
|
|
[FETCH_GROUP + "/humandGroup"]: true
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
expect(isFetchGroupPending(state, "humandGroup")).toEqual(true);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return false, when fetch group humandGroup is not pending", () => {
|
|
|
|
|
expect(isFetchGroupPending({}, "humandGroup")).toEqual(false);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return error when fetch group humandGroup did fail", () => {
|
|
|
|
|
const state = {
|
|
|
|
|
failure: {
|
|
|
|
|
[FETCH_GROUP + "/humandGroup"]: error
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
expect(getFetchGroupFailure(state, "humandGroup")).toEqual(error);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("should return undefined when fetch group humandGroup did not fail", () => {
|
|
|
|
|
expect(getFetchGroupFailure({}, "humandGroup")).toBe(undefined);
|
|
|
|
|
});
|
|
|
|
|
|
2018-07-31 14:22:15 +02:00
|
|
|
it("should return true if create group is pending", () => {
|
|
|
|
|
expect(isCreateGroupPending({pending: {
|
|
|
|
|
[CREATE_GROUP]: true
|
|
|
|
|
}})).toBeTruthy();
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
it("should return false if create group is not pending", () => {
|
|
|
|
|
expect(isCreateGroupPending({})).toBe(false);
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
it("should return error if creating group failed", () => {
|
|
|
|
|
expect(getCreateGroupFailure({
|
|
|
|
|
failure: {
|
|
|
|
|
[CREATE_GROUP]: error
|
|
|
|
|
}
|
|
|
|
|
})).toEqual(error)
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
it("should return undefined if creating group did not fail", () => {
|
|
|
|
|
expect(getCreateGroupFailure({})).toBeUndefined()
|
|
|
|
|
})
|
2018-07-31 15:09:45 +02:00
|
|
|
|
2018-07-31 13:04:09 +02:00
|
|
|
});
|