mirror of
https://github.com/redmine/redmine.git
synced 2025-11-02 19:36:00 +01:00
We are creating multipe mails per class notification event, one per recipient, wrapped in a Mailer::MultiMessage object to send them all at once. We keep the existing interface of all class methods intended to be used by external code the same as they were before, with one exception: We provide additional recipient addresses in options[:recipients] for Mailer.security_notification. Since the first-class recipients have to be users to render individual mails for them, additional recipient addresses have to be provided with some other channel. By providing additional recipients in options[:recipients], we can solve the use-case for address change notifications for users, which probably is the only real use-case for having to use a plain email address instead of a User as a notification recipient. Patch by Holger Just and Marius BALTEANU. git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
234 lines
6.3 KiB
Ruby
234 lines
6.3 KiB
Ruby
# Redmine - project management software
|
|
# Copyright (C) 2006-2017 Jean-Philippe Lang
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
require File.expand_path('../../test_helper', __FILE__)
|
|
|
|
class NewsControllerTest < Redmine::ControllerTest
|
|
fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
|
|
:enabled_modules, :news, :comments,
|
|
:attachments
|
|
|
|
def setup
|
|
User.current = nil
|
|
end
|
|
|
|
def test_index
|
|
get :index
|
|
assert_response :success
|
|
assert_select 'h3 a', :text => 'eCookbook first release !'
|
|
end
|
|
|
|
def test_index_with_project
|
|
get :index, :params => {
|
|
:project_id => 1
|
|
}
|
|
assert_response :success
|
|
assert_select 'h3 a', :text => 'eCookbook first release !'
|
|
end
|
|
|
|
def test_index_with_invalid_project_should_respond_with_404
|
|
get :index, :params => {
|
|
:project_id => 999
|
|
}
|
|
assert_response 404
|
|
end
|
|
|
|
def test_index_without_permission_should_fail
|
|
Role.all.each {|r| r.remove_permission! :view_news}
|
|
@request.session[:user_id] = 2
|
|
|
|
get :index
|
|
assert_response 403
|
|
end
|
|
|
|
def test_show
|
|
get :show, :params => {
|
|
:id => 1
|
|
}
|
|
assert_response :success
|
|
assert_select 'h2', :text => 'eCookbook first release !'
|
|
end
|
|
|
|
def test_show_should_show_attachments
|
|
attachment = Attachment.first
|
|
attachment.container = News.find(1)
|
|
attachment.save!
|
|
|
|
get :show, :params => {
|
|
:id => 1
|
|
}
|
|
assert_response :success
|
|
assert_select 'a', :text => attachment.filename
|
|
end
|
|
|
|
def test_show_with_comments_in_reverse_order
|
|
user = User.find(1)
|
|
user.pref[:comments_sorting] = 'desc'
|
|
user.pref.save!
|
|
|
|
@request.session[:user_id] = 1
|
|
get :show, :params => {
|
|
:id => 1
|
|
}
|
|
assert_response :success
|
|
|
|
comments = css_select('#comments .wiki').map(&:text).map(&:strip)
|
|
assert_equal ["This is an other comment", "my first comment"], comments
|
|
end
|
|
|
|
def test_show_not_found
|
|
get :show, :params => {
|
|
:id => 999
|
|
}
|
|
assert_response 404
|
|
end
|
|
|
|
def test_get_new
|
|
@request.session[:user_id] = 2
|
|
get :new, :params => {
|
|
:project_id => 1
|
|
}
|
|
assert_response :success
|
|
assert_select 'input[name=?]', 'news[title]'
|
|
end
|
|
|
|
def test_post_create
|
|
ActionMailer::Base.deliveries.clear
|
|
@request.session[:user_id] = 2
|
|
|
|
with_settings :notified_events => %w(news_added) do
|
|
post :create, :params => {
|
|
:project_id => 1,
|
|
:news => {
|
|
:title => 'NewsControllerTest',
|
|
:description => 'This is the description',
|
|
:summary => ''
|
|
}
|
|
}
|
|
end
|
|
assert_redirected_to '/projects/ecookbook/news'
|
|
|
|
news = News.find_by_title('NewsControllerTest')
|
|
assert_not_nil news
|
|
assert_equal 'This is the description', news.description
|
|
assert_equal User.find(2), news.author
|
|
assert_equal Project.find(1), news.project
|
|
assert_equal 2, ActionMailer::Base.deliveries.size
|
|
end
|
|
|
|
def test_post_create_with_attachment
|
|
set_tmp_attachments_directory
|
|
@request.session[:user_id] = 2
|
|
assert_difference 'News.count' do
|
|
assert_difference 'Attachment.count' do
|
|
post :create, :params => {
|
|
:project_id => 1,
|
|
:news => {
|
|
:title => 'Test',
|
|
:description => 'This is the description'
|
|
},
|
|
:attachments => {
|
|
'1' => {
|
|
'file' => uploaded_test_file('testfile.txt', 'text/plain')}
|
|
}
|
|
}
|
|
end
|
|
end
|
|
attachment = Attachment.order('id DESC').first
|
|
news = News.order('id DESC').first
|
|
assert_equal news, attachment.container
|
|
end
|
|
|
|
def test_post_create_with_validation_failure
|
|
@request.session[:user_id] = 2
|
|
post :create, :params => {
|
|
:project_id => 1,
|
|
:news => {
|
|
:title => '',
|
|
:description => 'This is the description',
|
|
:summary => ''
|
|
}
|
|
}
|
|
assert_response :success
|
|
assert_select_error /title cannot be blank/i
|
|
end
|
|
|
|
def test_get_edit
|
|
@request.session[:user_id] = 2
|
|
get :edit, :params => {
|
|
:id => 1
|
|
}
|
|
assert_response :success
|
|
assert_select 'input[name=?][value=?]', 'news[title]', 'eCookbook first release !'
|
|
end
|
|
|
|
def test_put_update
|
|
@request.session[:user_id] = 2
|
|
put :update, :params => {
|
|
:id => 1,
|
|
:news => {
|
|
:description => 'Description changed by test_post_edit'
|
|
}
|
|
}
|
|
assert_redirected_to '/news/1'
|
|
news = News.find(1)
|
|
assert_equal 'Description changed by test_post_edit', news.description
|
|
end
|
|
|
|
def test_put_update_with_attachment
|
|
set_tmp_attachments_directory
|
|
@request.session[:user_id] = 2
|
|
assert_no_difference 'News.count' do
|
|
assert_difference 'Attachment.count' do
|
|
put :update, :params => {
|
|
:id => 1,
|
|
:news => {
|
|
:description => 'This is the description'
|
|
},
|
|
:attachments => {
|
|
'1' => {
|
|
'file' => uploaded_test_file('testfile.txt', 'text/plain')}
|
|
}
|
|
}
|
|
end
|
|
end
|
|
attachment = Attachment.order('id DESC').first
|
|
assert_equal News.find(1), attachment.container
|
|
end
|
|
|
|
def test_update_with_failure
|
|
@request.session[:user_id] = 2
|
|
put :update, :params => {
|
|
:id => 1,
|
|
:news => {
|
|
:description => ''
|
|
}
|
|
}
|
|
assert_response :success
|
|
assert_select_error /description cannot be blank/i
|
|
end
|
|
|
|
def test_destroy
|
|
@request.session[:user_id] = 2
|
|
delete :destroy, :params => {
|
|
:id => 1
|
|
}
|
|
assert_redirected_to '/projects/ecookbook/news'
|
|
assert_nil News.find_by_id(1)
|
|
end
|
|
end
|