Go MAEDA
f43b3685ff
Use sum { ... } instead of map { ... }.sum ( #34399 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@20581 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-06 01:36:39 +00:00
Toshi MARUYAMA
43b848a2ed
remove spaces inside {} of app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@20411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-17 12:41:33 +00:00
Toshi MARUYAMA
4ce729d5af
use "do end" instead of {} at ActiveRecord scope lambda of app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@20342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-12 12:31:20 +00:00
Toshi MARUYAMA
63cd0b3e61
use "do end" instead of {} at app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@20284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-07 12:30:38 +00:00
Go MAEDA
e48ff48820
Evaluate acts_as_activity_provider's scope lazily ( #33664 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@20148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-17 02:02:50 +00:00
Toshi MARUYAMA
d208cb6421
fix source indent of app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@20083 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-26 15:02:02 +00:00
Go MAEDA
a7b9fa9996
Fix that Issues API bypasses add_issue_notes permission ( #33689 ).
...
Patch by Junya Tomono and Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19975 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-12 02:28:46 +00:00
Toshi MARUYAMA
258ba9b88b
remove spaces inside {} of app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19889 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:53 +00:00
Toshi MARUYAMA
f3f333a906
add space after comma to app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19888 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:45 +00:00
Toshi MARUYAMA
2f478664f7
add empty line after guard clause to app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:37 +00:00
Toshi MARUYAMA
26bf703530
fix source indent of Issue#visible_condition
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:29 +00:00
Toshi MARUYAMA
9568e81d73
fix source indent of Issue#self_and_descendants
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19885 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:21 +00:00
Go MAEDA
3f11c1f10b
Add "behind-schedule" CSS class to issues ( #31881 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19868 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-09 00:45:19 +00:00
Go MAEDA
6416bb5f51
Done ratio of a parent issue may be shown as 99% even though all subtasks are completed ( #33576 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19818 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-14 06:56:05 +00:00
Go MAEDA
ca2bde9fbf
Updating an issue via REST API causes internal server error if invalid project id is specified ( #33417 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19777 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-14 14:33:07 +00:00
Go MAEDA
5917137d12
Show warning and the reason when the issue cannot be closed or reopen because of open subtask(s), blocking issue(s) or closed parent issue ( #31589 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@19570 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-10 03:50:47 +00:00
Go MAEDA
907e0173e4
Update copyright year in source files to 2020 ( #33069 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
d48769f152
Enable users to receive email notifications about high issues (only) ( #32628 ).
...
Patch by Jan Schulz-Hofen.
git-svn-id: http://svn.redmine.org/redmine/trunk@19449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-21 04:23:26 +00:00
Toshi MARUYAMA
9e27f2a7c3
cleanup: rubocop: fix Layout/AlignArguments in app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18937 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 00:46:24 +00:00
Toshi MARUYAMA
75d3e4037b
code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18780 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:33:43 +00:00
Toshi MARUYAMA
c1e7c43cd4
code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18735 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 04:30:13 +00:00
Toshi MARUYAMA
0779cd6e53
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours method
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18567 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:48 +00:00
Toshi MARUYAMA
91d7916f38
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18566 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:36 +00:00
Toshi MARUYAMA
edc94dabb3
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition method
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18565 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:26 +00:00
Toshi MARUYAMA
ad110b965f
code cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18556 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:26 +00:00
Toshi MARUYAMA
591d0eae79
code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18523 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:56:51 +00:00
Toshi MARUYAMA
2829ddcc33
code cleanup: rubocop: fix Layout/BlockEndNewline in app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18517 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:54:53 +00:00
Toshi MARUYAMA
d6701ab40f
remove "attr_reader :current_journal" from Issue class
...
Issue#current_journal is already defined in Issue class.
git-svn-id: http://svn.redmine.org/redmine/trunk@18488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:48 +00:00
Toshi MARUYAMA
3be589df24
use "attr_writer" instead of "attr_accessor" for Issue#deleted_attachment_ids
...
Issue#deleted_attachment_ids is already defined in Issue class.
git-svn-id: http://svn.redmine.org/redmine/trunk@18487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:37 +00:00
Go MAEDA
8a9123de04
Limit total_estimated_hours to visible issues ( #31778 ).
...
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@18356 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-07 04:44:19 +00:00
Go MAEDA
4082069c75
Update copyright year.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
1ff42ec5bc
New Permission: Edit own issue ( #1248 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-04-25 05:32:58 +00:00
Go MAEDA
72e1451159
Use Regexp#match? to reduce allocations of MatchData object ( #28940 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
d4daf4e23b
Support frozen_string_literal in issue, journal, and query ( #26561 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@17980 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 00:29:58 +00:00
Go MAEDA
5861160ffc
Add "frozen_string_literal: false" for all files ( #26561 ).
...
This will be changed to true in the future.
git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
0c78056a69
Send emails asynchronously ( #26791 ).
...
Custom async_* delivery methods are removed in favor of ActiveJob (Async by default).
git-svn-id: http://svn.redmine.org/redmine/trunk@17588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-10 17:13:09 +00:00
Jean-Philippe Lang
5416ed1022
Cleanup: Remove Issue#each_notification and Journal#each_notification ( #26791 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@17584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:09:38 +00:00
Go MAEDA
3952c4d264
Extend Issue Summary to include subprojects ( #2529 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17563 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-03 07:16:47 +00:00
Jean-Philippe Lang
e856c9f879
Fixed that issue details page shows default values for custom fields that aren't actually set ( #25726 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17499 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 08:25:25 +00:00
Go MAEDA
7015e137fe
Use pluck(:id) instead of collect(&:id) in app/models/issue.rb ( #26711 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17455 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-07-29 05:45:40 +00:00
Go MAEDA
1c5600f820
Use pluck(:id) instead of collect(&:id) ( #26711 ).
...
Patch by jwjw yy.
git-svn-id: http://svn.redmine.org/redmine/trunk@17454 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-07-28 15:24:24 +00:00
Jean-Philippe Lang
ce1c652250
Upgrade to Rails 5.2.0 ( #23630 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17410 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-23 05:13:29 +00:00
Jean-Philippe Lang
3e31f8167b
Cannot clear category field on copying an Issue ( #28951 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17395 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-17 06:22:35 +00:00
Go MAEDA
74d775166a
Clear subtask assignee during copy if is locked ( #28946 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17390 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-17 01:03:04 +00:00
Jean-Philippe Lang
c2bdc81124
Log automatic rescheduling of following issues to journal ( #28649 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17373 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-10 05:57:12 +00:00
Go MAEDA
85db9769bc
Clear target version when copying an issue if status is locked or closed ( #27863 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17368 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-07 00:33:29 +00:00
Go MAEDA
2943153eca
Fix: Copying an issue fails if the issue is watched by a locked user ( #28765 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-19 00:44:10 +00:00
Go MAEDA
a175f9ded9
Allow selecting subprojects on new issue form ( #12704 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17217 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-28 06:42:52 +00:00
Jean-Philippe Lang
6d4c0a77fe
The progress exceeding 99.5% is displayed as 100% ( #27848 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 22:35:59 +00:00
Jean-Philippe Lang
2cb30321a2
No validation errors when entering an invalid "Estimate hours" value ( #27881 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:41:15 +00:00