Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-07 22:05:56 +01:00
Code Issues Packages Projects Releases Activity
18,159 Commits 35 Branches 222 Tags
eef8f625c831ae33ffeb9ec80fe2e3d68f6edae8
Commit Graph

190 Commits

Author SHA1 Message Date
Marius Balteanu
b010054d69 Replaces @URI.parse@ with @Addressable::URI.parse(url)@ to enhance robustness of @validate_back_url@ (#31831). 
Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22710 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-02-13 23:17:09 +00:00
Marius Balteanu
353ac52d47 Stop appending the utf8 checkmark parameter to form URLs (#40190). 
Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22709 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-02-13 23:13:49 +00:00
Marius Balteanu
f0f1d49b56 Remove @rss_*@ deprecated methods (#36806). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22416 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-11-06 20:36:48 +00:00
Go MAEDA
32d2b1c42f Fix RuboCop offense Style/InverseMethods: Use present? instead of inverting blank? (#37248). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22152 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-03-25 01:32:23 +00:00
Go MAEDA
9d65eee424 Avoid double-render error with ApplicationController#find_optional_project (#38063). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22066 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-20 03:31:41 +00:00
Go MAEDA
0b6f4c6811 Ruby 2.7: Fix RuboCop offense Performance/MapCompact (#38134). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22055 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-17 01:38:27 +00:00
Go MAEDA
3942177f49 Fix RuboCop offense Performance/BlockGivenWithExplicitBlock (#38146). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22027 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-11 13:20:52 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-01 06:19:35 +00:00
Marius Balteanu
f286a6044b Deprecate and rename rss_* methods to atom_* methods (#15118). 
Patch by Mischa The Evil and Marius BĂLTEANU


git-svn-id: http://svn.redmine.org/redmine/trunk@21467 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-19 09:56:46 +00:00
Marius Balteanu
1db2566ff9 Disable API authentication with username and password when two-factor authentication is enabled for the user (#35001). 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21436 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-02-24 19:10:35 +00:00
Marius Balteanu
9cda1638bd Set default protect from forgery true (#36317). 
Patch by Takashi Kato.

git-svn-id: http://svn.redmine.org/redmine/trunk@21379 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-01-22 08:43:42 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379). 
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-01-02 05:29:10 +00:00
Marius Balteanu
16b8d3c0be Fix typo (#33521). 
git-svn-id: http://svn.redmine.org/redmine/trunk@21140 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-08-05 23:46:17 +00:00
Marius Balteanu
7e2f3352db Fix that updating an issue from context menu to a none value do not set the field to blank (#33521). 
Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@21139 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-08-05 23:41:01 +00:00
Go MAEDA
66fc9f463d Gracefully handle invalid query parameters for custom fields (#35312). 
Patch by Holger Just.


git-svn-id: http://svn.redmine.org/redmine/trunk@21012 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-05-28 03:58:01 +00:00
Go MAEDA
ec989a5420 Fix "DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: common/error_messages.api" (#29914, #34984). 
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20897 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-04-01 15:36:57 +00:00
Go MAEDA
a7b96ae2ab Reverts r20895 (#29914, #34985). 
Wrong issue number.


git-svn-id: http://svn.redmine.org/redmine/trunk@20896 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-04-01 15:34:21 +00:00
Go MAEDA
d67eeabd53 Fix "DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: common/error_messages.api" (#29914, #34985). 
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20895 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-04-01 15:27:33 +00:00
Go MAEDA
094628e694 Remove #filename_for_content_disposition for MS browsers (#29914, #32914). 
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20892 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-04-01 15:19:16 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069). 
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-03-25 06:58:56 +00:00
Go MAEDA
9783ba003d Fix hard-coded error messages in ApplicationController (#33232). 
Contributed by Kam Nazir.


git-svn-id: http://svn.redmine.org/redmine/trunk@20843 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-03-25 04:39:18 +00:00
Toshi MARUYAMA
745e4152f8 remove spaces inside {} of ApplicationController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20409 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-11-17 12:41:18 +00:00
Toshi MARUYAMA
834bc11cc9 use "do end" instead of {} at ApplicationController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20142 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-10-11 12:57:39 +00:00
Toshi MARUYAMA
a6b68a82c6 add space after comma to ApplicationController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20134 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-10-11 12:56:36 +00:00
Toshi MARUYAMA
d7e881617d add empty line after guard clause to ApplicationController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20046 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-09-17 15:49:06 +00:00
Go MAEDA
be7f5e21fa Adds a setting to disable/enable/require 2fa auth (#1237). 
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@19989 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-08-29 06:37:09 +00:00
Toshi MARUYAMA
562dea3aa8 avoid using rescue in its modifier form at ApplicationController#find_current_user 
git-svn-id: http://svn.redmine.org/redmine/trunk@19862 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-07-08 17:29:56 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069). 
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-03-03 00:24:10 +00:00
Jean-Philippe Lang
0cd14b3a4b Validate back_url everywhere (#32850). 
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19488 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-02-02 08:39:22 +00:00
Jean-Philippe Lang
b3cda4fd61 Expose validate_back_url as helper method (#32850). 
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19487 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-02-02 08:38:47 +00:00
Jean-Philippe Lang
914f57fefc Move duplicated back_url method from ApplicationHelper to ApplicationController (#32850). 
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19486 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-02-02 08:38:01 +00:00
Go MAEDA
f7fcd111e9 Ruby 2.7: Regexp#match and Regexp#match? with a nil argument are deprecated (#32527, #31500). 
git-svn-id: http://svn.redmine.org/redmine/trunk@19324 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-11-30 05:40:40 +00:00
Toshi MARUYAMA
cb591d0af6 code layout clean up app/controllers/application_controller.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@19284 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-11-25 06:32:28 +00:00
Toshi MARUYAMA
4a60ebd848 cleanup: rubocop: fix Layout/SpaceInsideParens in app/controllers/application_controller.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@19253 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-11-24 13:18:21 +00:00
Toshi MARUYAMA
252450b44c code cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/application_controller.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@18821 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-10-22 12:41:21 +00:00
Go MAEDA
4082069c75 Update copyright year. 
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-25 07:36:06 +00:00
Go MAEDA
6d6ea928c8 Custom Exception classes should inherit StandardError instead of Exception (#31387). 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18187 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-21 23:53:10 +00:00
Go MAEDA
29403e710a Adds favorites and recently used projects lists to project jump box (#31355). 
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@18181 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-20 22:26:30 +00:00
Go MAEDA
f992df684f Small refactorization of avatar methods (#31391). 
* move existing methods from ApplicationHelper to a new helper file (AvatarsHelper)
* change default avatar size from 50 to 24 because most of the avatars are using the  size 24
* class 'gravatar' is always added and all custom classes are appended
* added user name as default title for avatar images
* added two new methods: @assignee_avatar@ and @author_avatar@

Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18175 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-19 22:27:41 +00:00
Go MAEDA
6ef0a4c4cc Use HTTP status code 403 instead of 401 when REST API is disabled (#30086). 
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18055 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-04-10 02:51:28 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940). 
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-27 02:15:24 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561). 
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561). 
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-15 01:32:57 +00:00
Go MAEDA
29063283da Ajax Request Returns 200 but an error event is fired instead of success (#30073). 
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17849 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-02-05 08:33:29 +00:00
Jean-Philippe Lang
3ba51f205d Let admins unarchive the project when trying to access an archived project (#29993). 
git-svn-id: http://svn.redmine.org/redmine/trunk@17682 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2018-12-02 11:23:10 +00:00
Go MAEDA
679cf413ab Log exception's message when ActionView::MissingTemplate is raised (#26341). 
Patch by Vincent Robert.


git-svn-id: http://svn.redmine.org/redmine/trunk@17174 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2018-01-11 12:29:52 +00:00
Jean-Philippe Lang
2eaabae252 Don't redirect anonymous users to the login form when module is disabled (#26145). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16726 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-26 21:04:34 +00:00
Jean-Philippe Lang
310060ff57 Code cleanup. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16725 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-26 20:51:28 +00:00
Jean-Philippe Lang
e7c0e16a3f Use regular #authorize method. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16724 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-26 20:41:12 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-25 08:40:31 +00:00