Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-10 15:26:03 +01:00
Code Issues Packages Projects Releases Activity
16,028 Commits 35 Branches 222 Tags
e5d7ece6f2718cb7e3988586c4c598c2d4ba32c2
Commit Graph

54 Commits

Author SHA1 Message Date
Go MAEDA
6e781f6479 Fix that "Successful deletion" notice is not displayed after deleting some types of content (#33116). 
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19641 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-04-04 00:43:28 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069). 
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-03-03 00:24:10 +00:00
Go MAEDA
6095186e97 Include attachments in news post notifications (#33002). 
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19528 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-02-24 03:19:00 +00:00
Toshi MARUYAMA
15e8297d81 cleanup: rubocop: fix Layout/IndentFirstHashElement in test/functional/news_controller_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@19222 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-11-24 05:25:12 +00:00
Go MAEDA
adebf4da1d Remove trailing whitespaces from test (#31506). 
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18233 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-06-06 14:53:23 +00:00
Go MAEDA
4082069c75 Update copyright year. 
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-25 07:36:06 +00:00
Go MAEDA
4f5a3a156c Enable frozen_string_literal for some files under test directory (#26561). 
git-svn-id: http://svn.redmine.org/redmine/trunk@17978 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-16 15:03:47 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561). 
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-15 01:32:57 +00:00
Go MAEDA
6765505b2d Add missing fixtures to several tests (#30276). 
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17780 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-01-09 14:26:56 +00:00
Jean-Philippe Lang
015ca36634 Send individual emails for each mail recipient (#26791). 
We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.

We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:

We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.

By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.

Patch by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2018-10-06 13:08:52 +00:00
Jean-Philippe Lang
b03e03b770 Global News view should not be allowed without permission (#7068). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16721 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-26 19:49:02 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
b834e81d7f Use Rails 5 syntax for functional tests. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16585 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-05-31 17:32:34 +00:00
Jean-Philippe Lang
bb5ccb870c Removes calls to #assert_template and #assigns in functional tests. 
git-svn-id: http://svn.redmine.org/redmine/trunk@15715 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-07-19 20:06:01 +00:00
Jean-Philippe Lang
2e4e610930 Adds our own class for controller tests. 
git-svn-id: http://svn.redmine.org/redmine/trunk@15661 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-07-14 09:35:49 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016. 
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
e3618bdbec Add support for multiple email addresses per user (#4244). 
git-svn-id: http://svn.redmine.org/redmine/trunk@13886 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2015-01-17 14:14:12 +00:00
Jean-Philippe Lang
000124f44f Copyright update. 
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
2a6692248b Replaced "can't" with "cannot" in error messages. 
git-svn-id: http://svn.redmine.org/redmine/trunk@13781 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-12-21 12:39:48 +00:00
Jean-Philippe Lang
f3e573b5f8 Replaced remaining #assert_tag with #assert_select. 
git-svn-id: http://svn.redmine.org/redmine/trunk@13624 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-11-22 09:38:21 +00:00
Jean-Philippe Lang
46756cbd56 Fixed 500 error when displaying a news with comments in reverse order (#18332). 
git-svn-id: http://svn.redmine.org/redmine/trunk@13595 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-11-14 20:53:14 +00:00
Toshi MARUYAMA
0636015826 add missing fixtures to NewsControllerTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@13375 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-09-11 17:19:42 +00:00
Toshi MARUYAMA
98249335d5 use escaped "can't" constant at NewsControllerTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@12803 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-02-04 23:52:12 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977) 
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-01-29 22:45:39 +00:00
Toshi MARUYAMA
184ea832d6 Rails4: replace deprecated Relation#first with finder options at NewsControllerTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@12522 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-01-08 06:26:25 +00:00
Toshi MARUYAMA
4f28ed2fb4 Rails4: replace deprecated Relation#first with finder options at NewsControllerTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@12521 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-01-08 06:23:43 +00:00
Jean-Philippe Lang
e396a0eebe Copyright for 2013 (#12788). 
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2013-01-12 09:29:31 +00:00
Jean-Philippe Lang
4cc4e8bfd3 Functional tests cleanup. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10936 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-12-03 22:23:23 +00:00
Jean-Philippe Lang
265baa1b2c Upgrade to Rails 3.2.8 (#11758). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10275 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-09-02 10:08:51 +00:00
Jean-Philippe Lang
7acd04fb87 Tests should not change settings. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9949 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-07-08 12:23:47 +00:00
Jean-Philippe Lang
ba5a052c8c Copyright update. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9636 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-05-05 12:56:53 +00:00
Jean-Philippe Lang
33cb9c87a9 More functional tests for NewsController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9173 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-03-10 13:47:28 +00:00
Jean-Philippe Lang
9634fe054a Adds a test for when updating a news fails. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9054 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-03-02 11:43:33 +00:00
Jean-Philippe Lang
21607751c9 Clean up assertion. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8999 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-02-25 12:35:22 +00:00
Jean-Philippe Lang
24138187eb Allows attachments on news (#1972). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8728 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-01-29 22:39:06 +00:00
Toshi MARUYAMA
4f6286b86a remove trailing white-spaces from test/functional/news_controller_test.rb. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6830 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-08-30 16:03:18 +00:00
Jean-Baptiste Barth
17f86d964f Use absolute paths in test/**/* requires for Ruby 1.9.2 compatibility. #4050 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4509 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-12-12 23:24:34 +00:00
Jean-Philippe Lang
2fab7bd9b1 Adds leading slash to all assert_redirected_to arguments (#6887). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4407 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-11-14 16:45:32 +00:00
Eric Davis
79e30e7087 Refactor: convert News to a REST resource 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4214 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-27 16:51:12 +00:00
Eric Davis
deed1b949d Refactor: move NewsController#preview to PreviewsController#news 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4174 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-24 16:26:46 +00:00
Eric Davis
401197a895 Refactor: move #destroy_comment method to CommentsController#destroy 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4172 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-23 15:20:19 +00:00
Eric Davis
1f2f953687 Refactor: move NewsController#add_comment to CommentsController#create 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4170 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-22 16:25:09 +00:00
Eric Davis
01d1a02df4 Refactor: split NewsController#edit into #edit and #update 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4168 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-21 15:20:37 +00:00
Eric Davis
3bc29e29e0 Refactor: split NewsController#new into #new and #create methods. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4163 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-20 15:13:48 +00:00
Eric Davis
9b595c689d Refactor: Move the rest of the routing tests to RoutingTest. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3687 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-21 16:02:55 +00:00
Eric Davis
7b0cb6aba8 Upgraded to Rails 2.3.4 (#3597) 
* Ran the Rails upgrade
* Upgraded to Rails Engines 2.3.2
* Added a plugin to let Engines override application views.
* Converted tests to use the new classes:
** ActionController::TestCase for functional
** ActiveSupport::TestCase for units
* Converted ActiveRecord::Error message to a string.
* ActiveRecord grouping returns an ordered hash which doesn't have #sort!
* Updated the I18n storage_units format.
* Added some default initializers from a fresh rails app
* Changed the order of check_box_tags and hidden_field_tags.  The hidden tag
  needs to appear first in Rails 2.3, otherwise it will override any value in
  the check_box_tag.
* Removed the custom handler for when the cookie store is tampered with.
  Rails 2.3 removed the TamperedWithCookie exception and instead Rails will not
  load the data from it when it's been tampered with (e.g. no user login).
* Fixed mail layouts, 2.3 has problems with implicit multipart emails that
  use layouts.  Also removed some custom Redmine mailer code.
* Fixed a bug that occurred in tests where the "required" span tag would be
  added to the :field_status translation.  This resulted in an email string of:

    <li>Status<span class="required"> *</span><span class="required"> *</span>

  Instead of:

    <li>Status: New</li>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2887 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-09-13 17:14:35 +00:00
Jean-Philippe Lang
d41bd93acb Fixed: error raised when trying to add an empty comment to a news (#3615). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2820 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-07-18 07:51:17 +00:00
Jean-Philippe Lang
7dccf9fda6 Allows multiple roles on the same project (#706). Prerequisite for user groups feature. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2726 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-05-10 10:54:31 +00:00
Eric Davis
b4be8849c0 Added observers to watch model objects for mail delivery instead of calling Mailer. 
* Added an IssueObserver to watch when Issues are created
* Added a JournalObserver to watch when Journals are created (Issue updates)
* Added a NewsObserver for News items.
* Added a DocumentObserver for Document notifications.
* Setup IssuesController#new to use the IssueObserver.
* Setup IssuesController#edit to use the IssueObserver.
* Setup IssuesController#bulk_edit to use the JournalObserver.
* Removed the Mailer call in Changeset#scan_commit_for_issue_ids, the
  JournalObserver will handle it.
* Removed Mailer calls in MailHandler in favor of the Observers.

  #2659

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2637 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-03-28 00:38:57 +00:00
Jean-Philippe Lang
fe28193e4e Merged Rails 2.2 branch. Redmine now requires Rails 2.2.2. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2493 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-02-21 11:04:50 +00:00