Commit Graph

1327 Commits

Author SHA1 Message Date
Go MAEDA
e4142a8338 Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textile (#26552).
Patch by Michael Gerz and Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17173 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-11 01:32:18 +00:00
Jean-Philippe Lang
054f3bb424 Updates for 3.4.4 release.
git-svn-id: http://svn.redmine.org/redmine/trunk@17162 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 17:58:39 +00:00
Go MAEDA
c35433ad01 Links for custom field value don't have "external" class (#27024).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-01 06:18:01 +00:00
Toshi MARUYAMA
9d797400ea mercurial: work around faulty parsing of early command options (#27516)
Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:47 +00:00
Toshi MARUYAMA
58ed865513 mercurial: separate command options and positional arguments with "--" (#27516)
We don't have much problems here thanks to hgtarget(path) and CGI.escape(),
which prepends a repository path and encodes "=" character respectively, but
it's better to not rely on the side effect of these functions.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:35 +00:00
Toshi MARUYAMA
ca87bf766c mercurial: reject malicious command argument (#27516)
We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.

https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314

This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.

This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:23 +00:00
Go MAEDA
d6d2d23365 Fix: Round floats to 2 digits when rendering an issue list to PDF (#12510).
Patch by Holger Just and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 14:25:35 +00:00
Jean-Philippe Lang
62d6dfe1cc Fixes visibility checks for version.fixed_issues in Gantt (#27676).
Like the version page - the Gantt chart featured a "percent done" info
for each version, which wasn't properly limited to visible issues.

Patch by Gregor Schmidt.

git-svn-id: http://svn.redmine.org/redmine/trunk@17053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 19:38:44 +00:00
Go MAEDA
9ae7bc8152 Make robust Redmine::Helpers::URL#uri_with_safe_scheme? (#27114)
Patch by okkez.


git-svn-id: http://svn.redmine.org/redmine/trunk@17035 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-26 03:44:37 +00:00
Go MAEDA
a92b92e501 Add right-click context menu to gantt bars (#10485).
Contributed by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17031 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-25 16:31:50 +00:00
Go MAEDA
fc93f14d64 Add right-click context menu to gantt subjects (#10485).
Contributed by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17030 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-25 16:30:23 +00:00
Go MAEDA
4b30e7a90e Fix: Gravatar icon is misaligned in gantt (#26410).
Contributed by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17027 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-25 15:29:52 +00:00
Jean-Philippe Lang
2fd2c1a31f Updates for 3.4.3 release.
git-svn-id: http://svn.redmine.org/redmine/trunk@17003 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-10-15 19:46:27 +00:00
Toshi MARUYAMA
6455e0431f fix "schema_migrations_table_name is deprecated" warning during redmine:plugins:migrate (#26615)
Contributed by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16962 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-31 15:57:43 +00:00
Toshi MARUYAMA
432cf42b47 git: remove "--no-color" option from "git --version" for git 2.14 compatibility (#26645)
git-svn-id: http://svn.redmine.org/redmine/trunk@16948 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-08 05:10:32 +00:00
Toshi MARUYAMA
7ab8bee653 remove empty lines with trailing white spaces at lib/redmine/search.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16941 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-01 04:46:00 +00:00
Toshi MARUYAMA
63217014ff remove trailing white spaces from lib/redmine/subclass_factory.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16937 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-31 06:21:35 +00:00
Toshi MARUYAMA
a9aac23343 remove trailing white space from lib/redmine/themes.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16935 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-31 04:30:42 +00:00
Jean-Philippe Lang
3a3ecb3dce Removed unused date calculations.
git-svn-id: http://svn.redmine.org/redmine/trunk@16934 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 21:22:57 +00:00
Jean-Philippe Lang
0910b2bdbe Drop Darcs support (#26391).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-25 17:32:53 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
85a0e96ad6 Set a default size for macro thumbnails different from the preview thumbnails.
git-svn-id: http://svn.redmine.org/redmine/trunk@16829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-19 07:00:27 +00:00
Jean-Philippe Lang
fba0a6685e Updates for 3.4.2 release.
git-svn-id: http://svn.redmine.org/redmine/trunk@16825 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-16 18:07:32 +00:00
Jean-Philippe Lang
2350d493b8 Updates for 3.4.1 release.
git-svn-id: http://svn.redmine.org/redmine/trunk@16779 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-09 07:16:52 +00:00
Jean-Philippe Lang
bd9e5447ea Set version to 3.4.
git-svn-id: http://svn.redmine.org/redmine/trunk@16695 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 09:20:07 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
7b6e6b9370 Removes plugins_path from configuration file (#24007).
git-svn-id: http://svn.redmine.org/redmine/trunk@16675 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-17 10:40:51 +00:00
Jean-Philippe Lang
ca1fbf1ea1 Render all possible inline textile images even if an invalid one exists (#26157).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@16668 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-17 07:45:08 +00:00
Jean-Philippe Lang
5744bfc2c6 Removes duplicate shell_quote method (#26149).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16667 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-17 07:42:54 +00:00
Toshi MARUYAMA
ce9edd07e3 gannt: not show %done if the field is disabled for the tracker (#25876)
Contributed by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16663 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-15 04:14:58 +00:00
Toshi MARUYAMA
06babbec7e remove is_binary_data? from String (#25563)
git-svn-id: http://svn.redmine.org/redmine/trunk@16644 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-10 04:29:15 +00:00
Jean-Philippe Lang
7f4767418b Generate markup for uploaded image dropped into wiki-edit textarea (#26071).
Patch by Felix Gliesche.

git-svn-id: http://svn.redmine.org/redmine/trunk@16643 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-07 21:01:45 +00:00
Jean-Philippe Lang
9b0fcdaf2b New permission: view news (#7068).
Patch by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16639 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-07 20:25:25 +00:00
Jean-Philippe Lang
b674e80128 New Permission: View Forum (#4866).
Patch by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16637 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-07 20:20:22 +00:00
Jean-Philippe Lang
f902860955 Link to user in wiki syntax (#4179).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@16636 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-07 20:10:57 +00:00
Jean-Philippe Lang
52b9b9cb02 Use stored ref. to array holding supported languages symbols via a constant (#26055).
Patch by Mischa The Evil.

git-svn-id: http://svn.redmine.org/redmine/trunk@16624 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-06 21:55:57 +00:00
Jean-Philippe Lang
9f5bd0c139 Pull-up retrieve_supported_languages private class method (#26055).
Patch by Mischa The Evil.

git-svn-id: http://svn.redmine.org/redmine/trunk@16623 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-06 21:55:29 +00:00
Jean-Philippe Lang
6198bde366 Remove internal CodeRay scanners (#26055).
Patch by Mischa The Evil.

git-svn-id: http://svn.redmine.org/redmine/trunk@16622 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-06 21:54:55 +00:00
Jean-Philippe Lang
8dca980a35 Make sure we can call #values.
git-svn-id: http://svn.redmine.org/redmine/trunk@16604 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-03 08:44:29 +00:00
Jean-Philippe Lang
4df797956d Errors#get is deprecated in Rails 5.
git-svn-id: http://svn.redmine.org/redmine/trunk@16595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-01 21:30:39 +00:00
Jean-Philippe Lang
335a16e4fd Cusotom field label should not be associated to the first input (#25760).
git-svn-id: http://svn.redmine.org/redmine/trunk@16574 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-05-27 08:49:08 +00:00
Jean-Philippe Lang
8ba7b6a2b2 Highlight language aliases are no more supported (#25634).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16568 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-05-27 07:53:16 +00:00
Jean-Philippe Lang
0c90a19eb2 Updates for 3.3.3 release.
git-svn-id: http://svn.redmine.org/redmine/trunk@16532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-09 08:28:03 +00:00
Jean-Philippe Lang
4f2c5a9945 Filter arbitrary class names and ids in rendered HTML output (#25503).
* Disallow setting arbitrary classes and ids via Textile syntax
* Only allow valid/supported languages for syntax highlighted code blocks

Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@16502 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-06 16:41:52 +00:00
Jean-Philippe Lang
281b26e2f5 Helper methods to find out if a given language is supported (#25503).
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@16501 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-06 16:37:18 +00:00
Jean-Philippe Lang
99fa41011f Add kbd to ALLOWED_TAGS (#25503).
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@16500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-06 16:34:52 +00:00
Jean-Philippe Lang
88a3a351d0 Don't hardcode the groups on My page.
git-svn-id: http://svn.redmine.org/redmine/trunk@16475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-04 17:17:47 +00:00
Jean-Philippe Lang
5c7aaa4d1e Makes Attachments column available on the issue list (#25515).
git-svn-id: http://svn.redmine.org/redmine/trunk@16473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-04 17:07:13 +00:00
Toshi MARUYAMA
6139e0033a spelling fixes (#25495)
git-svn-id: http://svn.redmine.org/redmine/trunk@16445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-02 03:34:44 +00:00
Toshi MARUYAMA
14cfe2c67a git: use '--no-renames' option in 'show' command (#25371)
git-svn-id: http://svn.redmine.org/redmine/trunk@16428 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-24 15:53:04 +00:00