Commit Graph

304 Commits

Author SHA1 Message Date
Marius Balteanu
805b36cbfb Remove unused setting 'Blind carbon copy recipients (bcc)' (#30820).
git-svn-id: http://svn.redmine.org/redmine/trunk@21130 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-01 17:25:13 +00:00
Go MAEDA
e86476eb5b Fix "ActiveRecord::StaleObjectError: Attempted to update a stale object: Issue." (#29914, #32912).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20884 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:48:50 +00:00
Go MAEDA
f134831602 Do not journalize attachments that are added during a "Copy Issue" operation (#34921).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@20872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-29 03:32:38 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
73648a0b9c Add test for 4 byte characters (emoji) support (#32054).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20780 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-13 01:16:10 +00:00
Go MAEDA
3f3514d8b1 Show only valid projects on issue form when the issue is a subtask (#33419).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20701 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-01 00:59:07 +00:00
Toshi MARUYAMA
ce605ea31d remove spaces inside {} of test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20439 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-19 13:31:17 +00:00
Toshi MARUYAMA
24feec3bb7 shorten long line of test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20177 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-24 14:39:16 +00:00
Toshi MARUYAMA
0470d27d0d shorten long line of test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20166 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-22 14:18:36 +00:00
Go MAEDA
a7b9fa9996 Fix that Issues API bypasses add_issue_notes permission (#33689).
Patch by Junya Tomono and Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19975 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-12 02:28:46 +00:00
Go MAEDA
3f11c1f10b Add "behind-schedule" CSS class to issues (#31881).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19868 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-09 00:45:19 +00:00
Go MAEDA
e9e0c538da Use more efficient "exists?" instead of "first" in tests when checking the existence of rows (#33367).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-03 00:44:08 +00:00
Go MAEDA
5917137d12 Show warning and the reason when the issue cannot be closed or reopen because of open subtask(s), blocking issue(s) or closed parent issue (#31589).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19570 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-10 03:50:47 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
d48769f152 Enable users to receive email notifications about high issues (only) (#32628).
Patch by Jan Schulz-Hofen.


git-svn-id: http://svn.redmine.org/redmine/trunk@19449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-21 04:23:26 +00:00
Toshi MARUYAMA
3f6d9f74f7 cleanup: rubocop: fix Layout/IndentFirstArrayElement in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19242 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-24 05:44:51 +00:00
Toshi MARUYAMA
8e3d0354a5 cleanup: rubocop: fix Layout/ClosingParenthesisIndentation in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19205 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-23 14:28:14 +00:00
Toshi MARUYAMA
bd0f849e08 cleanup: rubocop: fix Layout/IndentFirstHashElement in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19204 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-23 14:28:03 +00:00
Toshi MARUYAMA
4588fb20c5 cleanup: rubocop: fix Layout/AlignArguments in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19036 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 16:33:58 +00:00
Go MAEDA
545a050ba3 Code cleanup: RuboCop: Fix Performance/Count and Performance/Detect.
This change corrects newly detected offenses after updating rubocop-performance to 1.5.0 in r18579.


git-svn-id: http://svn.redmine.org/redmine/trunk@18580 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-02 00:53:11 +00:00
Toshi MARUYAMA
cc8750f7dd code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18554 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 02:44:32 +00:00
Toshi MARUYAMA
2e1da01790 code cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18537 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 17:55:14 +00:00
Toshi MARUYAMA
83d5633a5f code cleanup: rubocop: fix Style/TrailingCommaInArguments in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18529 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 11:18:59 +00:00
Toshi MARUYAMA
9a5cb65b9e code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18522 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:43:56 +00:00
Toshi MARUYAMA
5611ee0e02 backout r13743
git-svn-id: http://svn.redmine.org/redmine/trunk@18478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 05:49:21 +00:00
Toshi MARUYAMA
c7c2bb2b24 code cleanup: rubocop: fix Lint/UselessSetterCall in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18477 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-18 01:56:43 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
1ff42ec5bc New Permission: Edit own issue (#1248).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-04-25 05:32:58 +00:00
Go MAEDA
4f5a3a156c Enable frozen_string_literal for some files under test directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 15:03:47 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
196540f7f6 Test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17732 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-13 19:47:26 +00:00
Jean-Philippe Lang
015ca36634 Send individual emails for each mail recipient (#26791).
We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.

We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:

We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.

By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.

Patch by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:08:52 +00:00
Go MAEDA
3952c4d264 Extend Issue Summary to include subprojects (#2529).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17563 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-03 07:16:47 +00:00
Jean-Philippe Lang
5fbe5d74bc Test failures with sqlite3.
git-svn-id: http://svn.redmine.org/redmine/trunk@17502 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 11:57:38 +00:00
Jean-Philippe Lang
ce1c652250 Upgrade to Rails 5.2.0 (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@17410 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-23 05:13:29 +00:00
Go MAEDA
74d775166a Clear subtask assignee during copy if is locked (#28946).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17390 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-17 01:03:04 +00:00
Jean-Philippe Lang
c2bdc81124 Log automatic rescheduling of following issues to journal (#28649).
git-svn-id: http://svn.redmine.org/redmine/trunk@17373 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-10 05:57:12 +00:00
Go MAEDA
85db9769bc Clear target version when copying an issue if status is locked or closed (#27863).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17368 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-07 00:33:29 +00:00
Go MAEDA
2943153eca Fix: Copying an issue fails if the issue is watched by a locked user (#28765).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-19 00:44:10 +00:00
Go MAEDA
0f9ea965e7 Fix: Calculation of the start date of following issues ignores the "non-working days" setting (#14846).
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17230 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-08 07:44:54 +00:00
Jean-Philippe Lang
2cb30321a2 No validation errors when entering an invalid "Estimate hours" value (#27881).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:41:15 +00:00
Toshi MARUYAMA
eb1998ef39 try IssueTest#test_overdue failing on CI server at Japanese daytime (#22320)
git-svn-id: http://svn.redmine.org/redmine/trunk@16938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-31 06:57:35 +00:00
Toshi MARUYAMA
09148ba665 add missing fixture for IssueTest#test_update_should_notify_previous_assignee
git-svn-id: http://svn.redmine.org/redmine/trunk@16894 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-27 07:19:31 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
dd650c5c26 Setting to disable automatic closing of duplicates (#26192).
git-svn-id: http://svn.redmine.org/redmine/trunk@16697 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 11:40:58 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
b997f03211 Set default assignee before validation (#26072).
git-svn-id: http://svn.redmine.org/redmine/trunk@16619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-06 21:11:37 +00:00
Toshi MARUYAMA
c7cff810e8 remove trailing white spaces from test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16549 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-05-10 12:30:50 +00:00
Jean-Philippe Lang
cf76867a2f Adds tests for default assignments (#482).
git-svn-id: http://svn.redmine.org/redmine/trunk@16526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-08 08:15:52 +00:00
Jean-Philippe Lang
9506ff1f40 Fixed that watchers list is not updated when changing project on the new issue form (#17762).
git-svn-id: http://svn.redmine.org/redmine/trunk@16511 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-06 19:57:00 +00:00