Commit Graph

479 Commits

Author SHA1 Message Date
Marius Balteanu
ba74ba1c70 Allow users to be mentioned using @ in issues and wiki pages (#13919):
* the user must have add watchers permission on that object in order to mention other users
* mentioned user will receive a notification email
* only visible users who can view the object can be mentioned



git-svn-id: http://svn.redmine.org/redmine/trunk@21435 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-02-23 21:16:18 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
b6a26a60f3 Fixes for Performance/StringIdentifierArgument introduced in RuboCop Performance 1.13.0 (#35142).
git-svn-id: http://svn.redmine.org/redmine/trunk@21330 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-29 06:12:27 +00:00
Go MAEDA
91c00f51ec Fixes for Performance/BigDecimalWithNumericArgument introduced in RuboCop Performance 1.13.0 (#35142).
git-svn-id: http://svn.redmine.org/redmine/trunk@21326 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-25 08:59:22 +00:00
Go MAEDA
b4dbd821c9 Issue Summary: add statistics about issues without assignee, version or category (#13099).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@21309 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-12 04:40:32 +00:00
Go MAEDA
578e367c8c Allow addition/removal of subtasks to show in parent's history (#6033).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21273 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-08 14:22:06 +00:00
Marius Balteanu
506fc9d74c Tokenize search parameter in order to allow multiple search terms in:
* the "contains" operator of text filters
* in issue autocomplete

Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-05 19:54:31 +00:00
Marius Balteanu
05e9d7883b Use sanitize_sql_like in like scopes (#35073).
Patch Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:44:39 +00:00
Marius Balteanu
f31a1e2bbb Fixed attachments deletable by user without edit issue permission on tracker (#35634).
git-svn-id: http://svn.redmine.org/redmine/trunk@21142 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-05 23:50:11 +00:00
Go MAEDA
83e22515b9 Ruby 3.0: Fix super calls (#34992, #34986).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20912 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-03 09:01:53 +00:00
Go MAEDA
f134831602 Do not journalize attachments that are added during a "Copy Issue" operation (#34921).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@20872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-29 03:32:38 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
5d251f28d0 Unable to autoload constant Version.table_name if gems use Version class (#33206).
Patch by Alexander Meindl.


git-svn-id: http://svn.redmine.org/redmine/trunk@20760 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-03 14:39:23 +00:00
Go MAEDA
354d30df31 Add class 'error' to custom fields with validation errors (#32764, #34580).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20710 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-11 12:26:44 +00:00
Go MAEDA
3f3514d8b1 Show only valid projects on issue form when the issue is a subtask (#33419).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20701 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-01 00:59:07 +00:00
Toshi MARUYAMA
ca099daae2 shorten long line of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20663 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-17 13:11:05 +00:00
Go MAEDA
f43b3685ff Use sum { ... } instead of map { ... }.sum (#34399).
git-svn-id: http://svn.redmine.org/redmine/trunk@20581 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-06 01:36:39 +00:00
Toshi MARUYAMA
43b848a2ed remove spaces inside {} of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-17 12:41:33 +00:00
Toshi MARUYAMA
4ce729d5af use "do end" instead of {} at ActiveRecord scope lambda of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-12 12:31:20 +00:00
Toshi MARUYAMA
63cd0b3e61 use "do end" instead of {} at app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-07 12:30:38 +00:00
Go MAEDA
e48ff48820 Evaluate acts_as_activity_provider's scope lazily (#33664).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-17 02:02:50 +00:00
Toshi MARUYAMA
d208cb6421 fix source indent of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20083 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-26 15:02:02 +00:00
Go MAEDA
a7b9fa9996 Fix that Issues API bypasses add_issue_notes permission (#33689).
Patch by Junya Tomono and Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19975 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-12 02:28:46 +00:00
Toshi MARUYAMA
258ba9b88b remove spaces inside {} of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19889 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:53 +00:00
Toshi MARUYAMA
f3f333a906 add space after comma to app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19888 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:45 +00:00
Toshi MARUYAMA
2f478664f7 add empty line after guard clause to app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:37 +00:00
Toshi MARUYAMA
26bf703530 fix source indent of Issue#visible_condition
git-svn-id: http://svn.redmine.org/redmine/trunk@19886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:29 +00:00
Toshi MARUYAMA
9568e81d73 fix source indent of Issue#self_and_descendants
git-svn-id: http://svn.redmine.org/redmine/trunk@19885 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:21 +00:00
Go MAEDA
3f11c1f10b Add "behind-schedule" CSS class to issues (#31881).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19868 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-09 00:45:19 +00:00
Go MAEDA
6416bb5f51 Done ratio of a parent issue may be shown as 99% even though all subtasks are completed (#33576).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19818 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-14 06:56:05 +00:00
Go MAEDA
ca2bde9fbf Updating an issue via REST API causes internal server error if invalid project id is specified (#33417).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19777 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-14 14:33:07 +00:00
Go MAEDA
5917137d12 Show warning and the reason when the issue cannot be closed or reopen because of open subtask(s), blocking issue(s) or closed parent issue (#31589).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19570 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-10 03:50:47 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
d48769f152 Enable users to receive email notifications about high issues (only) (#32628).
Patch by Jan Schulz-Hofen.


git-svn-id: http://svn.redmine.org/redmine/trunk@19449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-21 04:23:26 +00:00
Toshi MARUYAMA
9e27f2a7c3 cleanup: rubocop: fix Layout/AlignArguments in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18937 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 00:46:24 +00:00
Toshi MARUYAMA
75d3e4037b code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18780 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:33:43 +00:00
Toshi MARUYAMA
c1e7c43cd4 code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18735 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 04:30:13 +00:00
Toshi MARUYAMA
0779cd6e53 code cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours method
git-svn-id: http://svn.redmine.org/redmine/trunk@18567 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:48 +00:00
Toshi MARUYAMA
91d7916f38 code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method
git-svn-id: http://svn.redmine.org/redmine/trunk@18566 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:36 +00:00
Toshi MARUYAMA
edc94dabb3 code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition method
git-svn-id: http://svn.redmine.org/redmine/trunk@18565 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:26 +00:00
Toshi MARUYAMA
ad110b965f code cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18556 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:26 +00:00
Toshi MARUYAMA
591d0eae79 code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18523 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:56:51 +00:00
Toshi MARUYAMA
2829ddcc33 code cleanup: rubocop: fix Layout/BlockEndNewline in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18517 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:54:53 +00:00
Toshi MARUYAMA
d6701ab40f remove "attr_reader :current_journal" from Issue class
Issue#current_journal is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:48 +00:00
Toshi MARUYAMA
3be589df24 use "attr_writer" instead of "attr_accessor" for Issue#deleted_attachment_ids
Issue#deleted_attachment_ids is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:37 +00:00
Go MAEDA
8a9123de04 Limit total_estimated_hours to visible issues (#31778).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@18356 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-07 04:44:19 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
1ff42ec5bc New Permission: Edit own issue (#1248).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-04-25 05:32:58 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
d4daf4e23b Support frozen_string_literal in issue, journal, and query (#26561).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17980 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 00:29:58 +00:00