Commit Graph

161 Commits

Author SHA1 Message Date
Go MAEDA
959b55779f Fix hard-coded string "no subject" in app/models/mail_handler.rb (#5820).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 00:09:10 +00:00
Go MAEDA
db3ee07a55 Reverts r18245 (#31582, #31365).
Issue subjets are truncated in some cases when they are created via email.


git-svn-id: http://svn.redmine.org/redmine/trunk@18269 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 06:57:45 +00:00
Jean-Philippe Lang
7a66b3b1da Issue subject may be broken if the subject field is split into multiple lines (#31365).
Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18245 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-10 11:40:48 +00:00
Go MAEDA
7bb8ab5e24 Fix "Undefined local variable sender_email" error in MailHandler#receive_message_reply when receiving a reply to a locked topic (#31503).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18239 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-10 00:54:28 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
b0e17e8199 Don't rescue Exception class (#31387).
Patch by Go MAEDA and Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 06:50:25 +00:00
Go MAEDA
143c359d90 Allows setting the private flag via mail keyword (#31324).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@18150 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-09 22:30:29 +00:00
Go MAEDA
b900ae6107 Support frozen_string_literal in test/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17996 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-21 03:27:53 +00:00
Go MAEDA
26509e7f4c Decode hexadecimal-encoded literals in order to be frozen string literals friendly (#31004).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17991 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-19 15:43:55 +00:00
Go MAEDA
e70c283a22 Remove unnecessary encoding magic comment (#31034).
The default script encoding is UTF-8 in Ruby 2.0 or later.

Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 06:26:33 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
472ea47808 Test for r17914 (#17699).
git-svn-id: http://svn.redmine.org/redmine/trunk@17915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-03 13:00:07 +00:00
Go MAEDA
77f35cb818 Option to parse HTML part of multipart (HTML) emails first (#30838).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17913 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-03 08:17:59 +00:00
Go MAEDA
b41c5c89d4 Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name (#30785).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-18 13:21:18 +00:00
Jean-Philippe Lang
7145e6d09a Test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17731 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-13 17:54:40 +00:00
Jean-Philippe Lang
b97770dc5c Test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17730 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-13 17:53:47 +00:00
Go MAEDA
f743d2356f Fix: Attachments are added even if validation fails when updating an issue via email (#28576).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@17630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-23 06:07:32 +00:00
Go MAEDA
facb44cb03 Ensure that vendor-defined characters in ISO-2022-JP email subject don't break issue's subject (#29442).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-15 10:00:18 +00:00
Jean-Philippe Lang
0c78056a69 Send emails asynchronously (#26791).
Custom async_* delivery methods are removed in favor of ActiveJob (Async by default).

git-svn-id: http://svn.redmine.org/redmine/trunk@17588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-10 17:13:09 +00:00
Jean-Philippe Lang
015ca36634 Send individual emails for each mail recipient (#26791).
We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.

We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:

We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.

By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.

Patch by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:08:52 +00:00
Go MAEDA
d1c84dbdf9 Fix: Allow to set no_notification option when receiving emails via IMAP or POP3 (#29191).
Patch by Holger Just.


git-svn-id: http://svn.redmine.org/redmine/trunk@17432 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-07-06 00:51:28 +00:00
Go MAEDA
a9bf2b763c Allow setting "Parent issue" attribute in emails (#27070).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17304 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-24 02:40:21 +00:00
Go MAEDA
76f12c1316 Optional regex for filtering attachments on incoming emails (#27025).
Patch by Jan Schulz-Hofen.


git-svn-id: http://svn.redmine.org/redmine/trunk@17225 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-03 04:29:54 +00:00
Jean-Philippe Lang
4e6b54e33e Empty email attachments are imported to Redmine, creating broken DB records (#27885).
Patch by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@17147 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:46:58 +00:00
Toshi MARUYAMA
abe914fd3f add test that anonymous user can add watchers by mail (#26654)
git-svn-id: http://svn.redmine.org/redmine/trunk@16963 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-09-07 17:22:14 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Toshi MARUYAMA
741fff9956 code layout cleanup test/unit/mail_handler_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16677 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-19 05:38:36 +00:00
Toshi MARUYAMA
8c03f2a6db allow unicode whitespace after mail handler body delimiters (#17718)
Contributed by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@16609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-06 01:34:52 +00:00
Jean-Philippe Lang
30f7be9c19 Changes the digest used for attachments to SHA256 (#25240).
Patch by Jens Kraemer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16454 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-03 11:11:36 +00:00
Jean-Philippe Lang
f338fe9075 Allow to set multiple values in emails for list custom fields (#16549).
git-svn-id: http://svn.redmine.org/redmine/trunk@16380 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-08 19:55:56 +00:00
Jean-Philippe Lang
a63908c5ed Emails with no text or html Content not handled properly (#25269, #25256).
Patch by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16379 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-07 17:54:09 +00:00
Jean-Philippe Lang
a9a1f6205a Mail parts with empty content should be ignored (#25256).
Patch by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16371 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-05 08:41:20 +00:00
Toshi MARUYAMA
3ac569c4d8 additional test for mail by Pavel Rosický (#24616)
git-svn-id: http://svn.redmine.org/redmine/trunk@16274 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-28 06:25:03 +00:00
Jean-Philippe Lang
f30462595e Optional Regex delimiters to truncate incoming emails (#5864).
git-svn-id: http://svn.redmine.org/redmine/trunk@16065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-13 18:46:29 +00:00
Jean-Philippe Lang
f416657d56 When creating issues by receiving an email, watchers created via CC in the mail don't get an email notification (#23278).
git-svn-id: http://svn.redmine.org/redmine/trunk@15609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-09 03:15:32 +00:00
Jean-Philippe Lang
ffdcb22ccb Ability to define a default assigned_to when receiving emails (#23020).
git-svn-id: http://svn.redmine.org/redmine/trunk@15547 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-18 07:07:41 +00:00
Jean-Philippe Lang
05a9275fda "I don't want to be notified of changes that I make myself" as Default for all User (#14574).
git-svn-id: http://svn.redmine.org/redmine/trunk@15288 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-04-03 11:33:28 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Toshi MARUYAMA
e28cc10a35 add test which ensure received mail text attachment keeps original encoding (#21742)
This test fails on Ruby >= 2.1 and will be fixed by next revision.

Contributed by Pavel Rosický.

git-svn-id: http://svn.redmine.org/redmine/trunk@15183 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-04 06:55:55 +00:00
Jean-Philippe Lang
91da86a688 Add watchers from To and Cc fields in issue replies (#7017).
git-svn-id: http://svn.redmine.org/redmine/trunk@15092 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-01-22 20:01:05 +00:00
Jean-Philippe Lang
0df7fa714b Allow a default version to be set on the command line for incoming emails (#7346).
git-svn-id: http://svn.redmine.org/redmine/trunk@14789 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-11-01 08:56:27 +00:00
Jean-Philippe Lang
3795c22730 Makes project selection by subaddress optional (#20732).
git-svn-id: http://svn.redmine.org/redmine/trunk@14690 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-19 16:56:13 +00:00
Jean-Philippe Lang
3caa882286 MailHandler: Select project by subaddress (redmine+project@example.com) (#20732).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@14687 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-17 10:03:49 +00:00
Jean-Philippe Lang
5c441cffca Moved notification assertion to its own test.
git-svn-id: http://svn.redmine.org/redmine/trunk@14685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-17 09:21:49 +00:00
Jean-Philippe Lang
b837e3627b Removed duplicate test case.
git-svn-id: http://svn.redmine.org/redmine/trunk@14684 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-17 09:17:33 +00:00
Jean-Philippe Lang
bf14be9f2c Deliveries already cleared in #setup.
git-svn-id: http://svn.redmine.org/redmine/trunk@14683 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-17 09:14:23 +00:00
Jean-Philippe Lang
7642378bf4 Not testing nested set.
git-svn-id: http://svn.redmine.org/redmine/trunk@14682 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-17 09:13:10 +00:00
Jean-Philippe Lang
1ccdf38fdd Mail Handler: add support for allow_override=all (#20543).
git-svn-id: http://svn.redmine.org/redmine/trunk@14681 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-17 09:08:18 +00:00
Jean-Philippe Lang
af3c91d02a Mail handler: no attributes overridable by default (#20543).
git-svn-id: http://svn.redmine.org/redmine/trunk@14680 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-17 08:00:16 +00:00
Jean-Philippe Lang
3ae42cb326 Better handle html-only emails (#16962).
git-svn-id: http://svn.redmine.org/redmine/trunk@14313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-06-15 21:16:42 +00:00