Commit Graph

278 Commits

Author SHA1 Message Date
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
1ff42ec5bc New Permission: Edit own issue (#1248).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-04-25 05:32:58 +00:00
Go MAEDA
4f5a3a156c Enable frozen_string_literal for some files under test directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 15:03:47 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
196540f7f6 Test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17732 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-13 19:47:26 +00:00
Jean-Philippe Lang
015ca36634 Send individual emails for each mail recipient (#26791).
We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.

We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:

We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.

By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.

Patch by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:08:52 +00:00
Go MAEDA
3952c4d264 Extend Issue Summary to include subprojects (#2529).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17563 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-03 07:16:47 +00:00
Jean-Philippe Lang
5fbe5d74bc Test failures with sqlite3.
git-svn-id: http://svn.redmine.org/redmine/trunk@17502 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 11:57:38 +00:00
Jean-Philippe Lang
ce1c652250 Upgrade to Rails 5.2.0 (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@17410 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-23 05:13:29 +00:00
Go MAEDA
74d775166a Clear subtask assignee during copy if is locked (#28946).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17390 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-17 01:03:04 +00:00
Jean-Philippe Lang
c2bdc81124 Log automatic rescheduling of following issues to journal (#28649).
git-svn-id: http://svn.redmine.org/redmine/trunk@17373 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-10 05:57:12 +00:00
Go MAEDA
85db9769bc Clear target version when copying an issue if status is locked or closed (#27863).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17368 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-07 00:33:29 +00:00
Go MAEDA
2943153eca Fix: Copying an issue fails if the issue is watched by a locked user (#28765).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-19 00:44:10 +00:00
Go MAEDA
0f9ea965e7 Fix: Calculation of the start date of following issues ignores the "non-working days" setting (#14846).
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17230 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-08 07:44:54 +00:00
Jean-Philippe Lang
2cb30321a2 No validation errors when entering an invalid "Estimate hours" value (#27881).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:41:15 +00:00
Toshi MARUYAMA
eb1998ef39 try IssueTest#test_overdue failing on CI server at Japanese daytime (#22320)
git-svn-id: http://svn.redmine.org/redmine/trunk@16938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-31 06:57:35 +00:00
Toshi MARUYAMA
09148ba665 add missing fixture for IssueTest#test_update_should_notify_previous_assignee
git-svn-id: http://svn.redmine.org/redmine/trunk@16894 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-27 07:19:31 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
dd650c5c26 Setting to disable automatic closing of duplicates (#26192).
git-svn-id: http://svn.redmine.org/redmine/trunk@16697 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 11:40:58 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
b997f03211 Set default assignee before validation (#26072).
git-svn-id: http://svn.redmine.org/redmine/trunk@16619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-06 21:11:37 +00:00
Toshi MARUYAMA
c7cff810e8 remove trailing white spaces from test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16549 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-05-10 12:30:50 +00:00
Jean-Philippe Lang
cf76867a2f Adds tests for default assignments (#482).
git-svn-id: http://svn.redmine.org/redmine/trunk@16526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-08 08:15:52 +00:00
Jean-Philippe Lang
9506ff1f40 Fixed that watchers list is not updated when changing project on the new issue form (#17762).
git-svn-id: http://svn.redmine.org/redmine/trunk@16511 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-06 19:57:00 +00:00
Jean-Philippe Lang
756a102820 Reset status when copying issues (#23610).
git-svn-id: http://svn.redmine.org/redmine/trunk@16451 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-03 10:30:29 +00:00
Jean-Philippe Lang
18f431acc0 Allow to disable description field in tracker setting (#25052).
Patch by Go MAEDA and Mischa The Evil.

git-svn-id: http://svn.redmine.org/redmine/trunk@16351 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-02 19:47:58 +00:00
Jean-Philippe Lang
f3627e2a3d Prevent parent issue from being closed if a child issue is open (#10989).
git-svn-id: http://svn.redmine.org/redmine/trunk@16108 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-21 09:09:22 +00:00
Jean-Philippe Lang
3b7da88a83 Show an error message when changing an issue's project fails due to errors in child issues (#23888).
git-svn-id: http://svn.redmine.org/redmine/trunk@16089 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-18 08:54:26 +00:00
Jean-Philippe Lang
bf5dade8df Use assert_nil instead of assert_equal.
git-svn-id: http://svn.redmine.org/redmine/trunk@16060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-11 15:26:41 +00:00
Jean-Philippe Lang
3a2b6c7c96 Enforce issue assignee validation (#23921).
git-svn-id: http://svn.redmine.org/redmine/trunk@16055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-10 12:02:37 +00:00
Jean-Philippe Lang
d4f57cc2fa Edit/delete links displayed on issue even if project is closed (#23969).
git-svn-id: http://svn.redmine.org/redmine/trunk@15879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-02 11:00:08 +00:00
Jean-Philippe Lang
752648ebf5 closed_on field of copied issue is always set to source issue's value (#23764).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@15848 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-01 07:43:22 +00:00
Jean-Philippe Lang
55be3ef172 Journalize values that are cleared after project or tracker change (#21623).
git-svn-id: http://svn.redmine.org/redmine/trunk@15811 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-09-03 07:26:49 +00:00
Jean-Philippe Lang
a20458612e When copying an issue, all statuses for new issue should be available (#14696).
git-svn-id: http://svn.redmine.org/redmine/trunk@15810 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-09-03 07:21:32 +00:00
Jean-Philippe Lang
d5ca4a3593 Fixed that restricted custom permissions on for non member/anonymous does not work (#23655).
git-svn-id: http://svn.redmine.org/redmine/trunk@15750 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-08-30 19:24:03 +00:00
Jean-Philippe Lang
f4b885d088 Use #update! instead of #update_attribute.
git-svn-id: http://svn.redmine.org/redmine/trunk@15685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-16 16:13:04 +00:00
Jean-Philippe Lang
83777f727a Assignable users should not include users that cannot view the tracker (#23172).
git-svn-id: http://svn.redmine.org/redmine/trunk@15586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-28 20:31:08 +00:00
Jean-Philippe Lang
a23450fe08 Adds issue visibility by role/tracker (#285).
git-svn-id: http://svn.redmine.org/redmine/trunk@15465 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-05 11:50:09 +00:00
Jean-Philippe Lang
79df68e17f Limit trackers for new issue to certain roles (#7839).
git-svn-id: http://svn.redmine.org/redmine/trunk@15464 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-05 10:06:17 +00:00
Jean-Philippe Lang
a6828512c0 Adds Issue#allowed_target_trackers (#7839).
git-svn-id: http://svn.redmine.org/redmine/trunk@15430 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-05-30 18:20:13 +00:00
Jean-Philippe Lang
ed50d42210 Replace Date.today with User.current.today (#22320).
Depending on the offset between a user's configured timezone and the server
timezone, Date.today may be more or less often wrong from the user's
perspective, leading to things like issues marked as overdue too early or too
late, or yesterday / tomorrow being displayed / selected where 'today' is
intended.

A test case illustrating the problem with Issue#overdue? is included

Patch by Jens Kraemer.

git-svn-id: http://svn.redmine.org/redmine/trunk@15379 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-05-07 10:42:22 +00:00
Jean-Philippe Lang
40c9c3e922 Notify the user of missing attachments (#22401).
under certain (rare) circumstances it may happen that, when an issue or other
container is saved, added attachments have already been removed (i.e. by the
attachments:prune rake task). This patch adds a validation error to the
container in this case.

Patch by Jens Kraemer.

git-svn-id: http://svn.redmine.org/redmine/trunk@15378 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-05-07 10:31:20 +00:00
Jean-Philippe Lang
05a9275fda "I don't want to be notified of changes that I make myself" as Default for all User (#14574).
git-svn-id: http://svn.redmine.org/redmine/trunk@15288 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-04-03 11:33:28 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
9473a373a5 Verify assigned_to_id when assigning safe_attributes (#22127).
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@15223 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-12 13:09:23 +00:00
Jean-Philippe Lang
01cf5ed968 Private notes get copied without private flag to Duplicate issues (#22072).
git-svn-id: http://svn.redmine.org/redmine/trunk@15196 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-12 08:21:32 +00:00
Jean-Philippe Lang
300e5e4652 After copying a task, setting the parent as the orignal task's parent triggers an error (#17580).
git-svn-id: http://svn.redmine.org/redmine/trunk@15057 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-01-10 15:31:50 +00:00
Jean-Philippe Lang
3a48f09d4f Can't set parent issue when issue relations among child issues are present (#13654).
git-svn-id: http://svn.redmine.org/redmine/trunk@15056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-01-10 15:12:28 +00:00
Jean-Philippe Lang
a5fd84f00e Don't include locked user in assignable users (#21477).
git-svn-id: http://svn.redmine.org/redmine/trunk@14972 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-12-12 12:37:56 +00:00
Jean-Philippe Lang
b095389a60 Adds a test for #21477.
git-svn-id: http://svn.redmine.org/redmine/trunk@14971 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-12-12 12:36:11 +00:00