Commit Graph

75 Commits

Author SHA1 Message Date
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
96b6bdfb77 Test for r18158 (#22481).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18159 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-12 05:43:50 +00:00
Go MAEDA
400e1ca2ff Attachment preview does not work for some source files such as JavaScript and Go (#29259).
Patch by Go MAEDA with the help of Stephan Wenzel's contribution.


git-svn-id: http://svn.redmine.org/redmine/trunk@18122 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-04 09:32:05 +00:00
Go MAEDA
b900ae6107 Support frozen_string_literal in test/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17996 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-21 03:27:53 +00:00
Go MAEDA
26509e7f4c Decode hexadecimal-encoded literals in order to be frozen string literals friendly (#31004).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17991 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-19 15:43:55 +00:00
Go MAEDA
e70c283a22 Remove unnecessary encoding magic comment (#31034).
The default script encoding is UTF-8 in Ruby 2.0 or later.

Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 06:26:33 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
4c38f46184 Makes sure the generated thumbnail is always of at least the requested size (#13688).
Patch by Jens Krämer and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17850 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-05 13:50:20 +00:00
Jean-Philippe Lang
fb1d0bf165 Clear thumbnails directory to prevent test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17752 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-16 13:27:52 +00:00
Go MAEDA
cccd14ae5c Deletes thumbnails when the attachment diskfile is deleted (#30177).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-15 02:58:45 +00:00
Go MAEDA
bda0de0044 Allows re-use of thumbnails for identical attachments (#30177).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17735 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-15 02:37:00 +00:00
Jean-Philippe Lang
fde78164dc Test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17729 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-13 17:51:08 +00:00
Go MAEDA
51fdc31e1c "thumbnail" macro may break filename attribute of the attachment (#29038).
Patch by Toru Takahashi.


git-svn-id: http://svn.redmine.org/redmine/trunk@17428 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-07-02 02:36:22 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
2660a2e5b3 Adds a test for when the file comparison fails (#25215).
git-svn-id: http://svn.redmine.org/redmine/trunk@16462 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-03 12:51:13 +00:00
Jean-Philippe Lang
1b81a030ce Cleanup tests with mock files.
git-svn-id: http://svn.redmine.org/redmine/trunk@16461 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-03 12:48:58 +00:00
Jean-Philippe Lang
f0e5437d27 Reuse existing identical disk files for new attachments (#25215).
Patch by Jens Kraemer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-03 11:54:29 +00:00
Jean-Philippe Lang
ee84b6b24c Adds a rake task to update attachments digests to SHA256 (#25240).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16455 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-03 11:38:06 +00:00
Jean-Philippe Lang
30f7be9c19 Changes the digest used for attachments to SHA256 (#25240).
Patch by Jens Kraemer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16454 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-03 11:11:36 +00:00
Jean-Philippe Lang
831a2d58ab Test cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@16086 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-16 08:49:52 +00:00
Jean-Philippe Lang
ae7852adac Test cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@16085 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-16 08:49:38 +00:00
Jean-Philippe Lang
d74bc734f3 Fixed the assertion (#24186).
git-svn-id: http://svn.redmine.org/redmine/trunk@16084 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-16 08:47:37 +00:00
Jean-Philippe Lang
20be00e437 Restrict the length attachment filenames on disk (#24186).
git-svn-id: http://svn.redmine.org/redmine/trunk@16083 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-16 08:45:41 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
3ffdc863de Removes attachment from disk after rollback on create (#21125).
git-svn-id: http://svn.redmine.org/redmine/trunk@15085 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-01-21 05:38:55 +00:00
Jean-Philippe Lang
dd1c5f8900 Files upload restriction by files extensions (#20008).
git-svn-id: http://svn.redmine.org/redmine/trunk@14792 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-11-01 10:41:02 +00:00
Jean-Philippe Lang
e3e0f5440d Extend Filesize in the attachments table for files with size > 2GB (#10672).
git-svn-id: http://svn.redmine.org/redmine/trunk@14709 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-20 16:36:28 +00:00
Jean-Philippe Lang
e045215db7 Remove attachment after transaction commit (#20388).
Patch by Ivan Zabrovskiy.

git-svn-id: http://svn.redmine.org/redmine/trunk@14630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-09-30 18:59:51 +00:00
Jean-Philippe Lang
785569b980 Typo.
git-svn-id: http://svn.redmine.org/redmine/trunk@14629 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-09-30 18:50:01 +00:00
Jean-Philippe Lang
ef003caab2 Wrong syntax for resizing inline images may throw a 500 error (#20278).
Fix by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@14473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-08-02 07:25:23 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
0cfbf9d449 Make sure that Redmine::Thumbnail.generate is called.
git-svn-id: http://svn.redmine.org/redmine/trunk@13714 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 12:22:35 +00:00
Jean-Philippe Lang
56edfcf6e9 Adds some Attachment tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@13709 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 08:35:00 +00:00
Jean-Philippe Lang
288c014aa7 Edit attachments after upload (#1326).
git-svn-id: http://svn.redmine.org/redmine/trunk@13665 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-29 13:41:53 +00:00
Jean-Philippe Lang
61776a8b7e Blank content type for attachments attached via Ajax file upload (Patch by Jens Krämer).
git-svn-id: http://svn.redmine.org/redmine/trunk@13125 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-05-02 07:38:04 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00
Toshi MARUYAMA
8a6f4c3880 Rails4: replace deprecated Relation#first with finder options at AttachmentTest
git-svn-id: http://svn.redmine.org/redmine/trunk@12500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-08 02:49:09 +00:00
Toshi MARUYAMA
afda064058 remove trailing white-spaces from test/unit/attachment_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@12356 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-04 07:09:17 +00:00
Jean-Philippe Lang
02fca76c13 Strip eols from file names (#14819).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12128 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-11 19:19:24 +00:00
Toshi MARUYAMA
c49451eb10 not use assert_not_nil in Errors#[]
r7593 etc. replaced Rails2 Errors#on.
Rails3 Errors#[] always return array.
So, Rails3 Errors#[] is always not nil.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12070 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-30 08:23:54 +00:00
Jean-Philippe Lang
14b50dfbab Removing shoulda context.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11315 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-03 09:20:05 +00:00
Jean-Philippe Lang
e396a0eebe Copyright for 2013 (#12788).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:29:31 +00:00
Jean-Philippe Lang
d46a0a3a4f NoMethodError: private method `now' called for DateTime:Class error in tests with ruby < 1.9.3 (#5298).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10993 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 13:18:41 +00:00
Jean-Philippe Lang
c99b638d61 Store attachments in subdirectories (#5298).
Existing files can be moved to their target subdirectories using rake redmine:attachments:move_to_subdirectories.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10990 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 12:07:19 +00:00
Jean-Philippe Lang
5c2de4dfc9 Adds Attachment#title.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-16 16:42:23 +00:00
Jean-Philippe Lang
7f0bb136ad Validate attachment description length (#11365).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9984 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-15 14:42:00 +00:00
Jean-Philippe Lang
a0c495b953 Displays thumbnails of attached images of the issue view (#1006).
This behaviour can be turned on/off in Settings -> Display (off by default). Thumbnail size can be configured there too.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9933 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-07 13:48:07 +00:00
Jean-Philippe Lang
ba5a052c8c Copyright update.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9636 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-05-05 12:56:53 +00:00
Jean-Philippe Lang
4a6de486ba Use fixture.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8983 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 21:24:00 +00:00