Commit Graph

97 Commits

Author SHA1 Message Date
Go MAEDA
43873746ba Replace custom EMAIL_REGEXP with URI::MailTo::EMAIL_REGEXP for more accurate email validation (#36969).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22332 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-10-07 03:43:00 +00:00
Go MAEDA
32d2b1c42f Fix RuboCop offense Style/InverseMethods: Use present? instead of inverting blank? (#37248).
git-svn-id: https://svn.redmine.org/redmine/trunk@22152 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-25 01:32:23 +00:00
Go MAEDA
45b4bff194 Refactor code to use YAML.load_file instead of explicitly opening the file (#38250).
git-svn-id: https://svn.redmine.org/redmine/trunk@22101 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-02-13 14:35:38 +00:00
Go MAEDA
e03bc47e14 Fix config/settings.yml not closed in Setting.load_available_settings (#38250).
Patch by Thomas Löber.


git-svn-id: https://svn.redmine.org/redmine/trunk@22099 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-02-06 14:08:30 +00:00
Go MAEDA
dbf8c1d921 Fix RuboCop offense Performance/RedundantEqualityComparisonBlock (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22031 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:30:25 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
204709f4df Use the classes whitelist configured in application.rb instead of hardcoded classes (#37476).
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21777 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-08-25 13:47:04 +00:00
Go MAEDA
7752e9a19a Psych::DisallowedClass exception when loading default plugin settings (#37450, #37476).
Contributed by Dmitry Makurin.


git-svn-id: https://svn.redmine.org/redmine/trunk@21725 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-07-21 00:41:29 +00:00
Go MAEDA
b6c218deed Don't use YAML.unsafe_load (#37450).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21722 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-07-20 03:05:10 +00:00
Marius Balteanu
eb868ad932 Add "required for administrators" option to Two-factor authentication settings that behaves like optional, but will require all users with administration rights to set up two-factor authentication at their next login (#35439).
git-svn-id: http://svn.redmine.org/redmine/trunk@21395 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-02-01 20:17:27 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
f3f355a8bf Fix that encoding drop-down in the import settings defaults to US-ASCII instead of general_csv_encoding in Thai (#36377).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21336 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 02:38:32 +00:00
Go MAEDA
a99567846c Fix that encoding drop-down in the import settings defaults to US-ASCII instead of general_csv_encoding in Korean (#36377).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21335 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 02:37:13 +00:00
Go MAEDA
9955844da1 Drop OpenID support (#35755).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21312 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-14 00:09:53 +00:00
Go MAEDA
5865edeba7 Psych 4: Psych::DisallowedClass exception when unserializing a setting value (#36226).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21294 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-25 05:48:04 +00:00
Marius Balteanu
1b0bf28803 When 2FA is set to optional, allow to require 2FA only for certain user groups (#31920).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-04 13:06:47 +00:00
Go MAEDA
2a564a1376 DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. (#29914, #32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20880 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:32:23 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
5f30d907a7 Remove unsupported encodings ISO-2022-KR and ISCII91 from Setting::ENCODINGS (#34750).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20747 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-02-17 12:24:12 +00:00
Toshi MARUYAMA
0468fe6545 remove spaces inside {} of app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20346 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-12 12:31:51 +00:00
Toshi MARUYAMA
238e6ce65d use "do end" instead of {} at app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20283 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-07 12:30:31 +00:00
Go MAEDA
fdba424d77 Use match? instead of =~ when MatchData is not used (#34150).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20168 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-23 00:13:38 +00:00
Toshi MARUYAMA
2cf079be5b add space after comma to app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20130 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-05 15:48:22 +00:00
Toshi MARUYAMA
c988d6ca48 shorten long line of app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20123 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-05 15:47:26 +00:00
Go MAEDA
be7f5e21fa Adds a setting to disable/enable/require 2fa auth (#1237).
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@19989 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-29 06:37:09 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
47a71c8011 Reverts r19478 (#32897).
git-svn-id: http://svn.redmine.org/redmine/trunk@19479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-30 05:27:52 +00:00
Go MAEDA
10bb12e09f Fix 'DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1.' (#32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-28 09:49:14 +00:00
Toshi MARUYAMA
dd0c72e4bc cleanup: rubocop: fix Layout/IndentFirstHashElement in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19302 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 16:48:24 +00:00
Toshi MARUYAMA
43e0616102 cleanup: rubocop: fix Layout/EmptyLineAfterGuardClause in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19288 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 09:08:02 +00:00
Toshi MARUYAMA
404f2fb54d cleanup: rubocop: fix Layout/IndentFirstArrayElement in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19248 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-24 12:57:50 +00:00
Toshi MARUYAMA
ab37571a8e cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19104 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:29:52 +00:00
Toshi MARUYAMA
e57b7fd4c0 code cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18795 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:30:41 +00:00
Toshi MARUYAMA
991230f37a code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18794 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:30:29 +00:00
Toshi MARUYAMA
cd922bb237 code cleanup: rubocop: fix Layout/AlignArray in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18792 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:30:05 +00:00
Toshi MARUYAMA
beb966737a fix Setting#find_or_default is not private
git-svn-id: http://svn.redmine.org/redmine/trunk@18694 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-16 14:36:31 +00:00
Toshi MARUYAMA
b8f33b0694 code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18646 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-13 16:22:54 +00:00
Toshi MARUYAMA
ca411ddca7 code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18559 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 09:00:06 +00:00
Go MAEDA
35e6a532f5 Force passwords to contain specified character classes (#4221).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-29 01:35:09 +00:00
Go MAEDA
26774d09e9 Code cleanup: RuboCop: Fix Style/UnneededCondition in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18397 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-26 07:16:55 +00:00
Go MAEDA
47dd2083f7 Reject setting RFC non-compliant emission email addresses (#31154).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18396 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-26 04:18:18 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
5329ef3b82 Reverts r17862.
git-svn-id: http://svn.redmine.org/redmine/trunk@17878 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-18 13:03:03 +00:00
Go MAEDA
b0b8978ff8 Fix: Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name (#30785).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17862 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-12 23:35:05 +00:00
Jean-Philippe Lang
0c78056a69 Send emails asynchronously (#26791).
Custom async_* delivery methods are removed in favor of ActiveJob (Async by default).

git-svn-id: http://svn.redmine.org/redmine/trunk@17588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-10 17:13:09 +00:00
Go MAEDA
6233ebd71e Fix indent (#27025).
Patch by Jan Schulz-Hofen.


git-svn-id: http://svn.redmine.org/redmine/trunk@17226 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-03 04:32:16 +00:00
Go MAEDA
76f12c1316 Optional regex for filtering attachments on incoming emails (#27025).
Patch by Jan Schulz-Hofen.


git-svn-id: http://svn.redmine.org/redmine/trunk@17225 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-03 04:29:54 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00