Commit Graph

5306 Commits

Author SHA1 Message Date
Jean-Philippe Lang
198212f991 Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@17666 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-29 22:20:14 +00:00
Jean-Philippe Lang
1cadb28a6e Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@17665 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-29 19:24:30 +00:00
Jean-Philippe Lang
0fac1a5440 Adds a test for #30001.
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17659 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-29 16:06:52 +00:00
Jean-Philippe Lang
a6d8e17e79 Adds a test for #29918.
git-svn-id: http://svn.redmine.org/redmine/trunk@17657 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-29 15:57:04 +00:00
Go MAEDA
05e701b877 Add missing fixtures for test_create_with_one_attachment (#30054).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17649 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-29 06:58:04 +00:00
Go MAEDA
9b682c2537 Add missing fixtures for test_create_should_send_notification (#29990).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17648 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-29 06:52:33 +00:00
Jean-Philippe Lang
4770fa5b6a Tests for #29674.
Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@17646 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-28 18:15:56 +00:00
Jean-Philippe Lang
f130bf9e2b REST API with JSON content missing false values (#20788).
Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17643 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-28 18:03:07 +00:00
Go MAEDA
14d441a144 Remove blank keys from sort criteria (#30009).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17638 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-26 05:22:04 +00:00
Go MAEDA
7fbcb8c908 Tags start with 'pre' are handled as 'pre' tag in Textile (#8395).
Patch by Takenori TAKAKI and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17636 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-26 04:40:09 +00:00
Go MAEDA
6a12b5839b Add wiki class also for half width custom fields with text formatting enabled (#30027).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17634 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-26 00:23:08 +00:00
Go MAEDA
f743d2356f Fix: Attachments are added even if validation fails when updating an issue via email (#28576).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@17630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-23 06:07:32 +00:00
Go MAEDA
c5eff3dae2 Strip whitespace from integer custom field (#8317).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17625 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-08 13:01:06 +00:00
Go MAEDA
54cfb7b75e Sort issues by due date in email reminders (#29771).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17624 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-06 03:13:46 +00:00
Go MAEDA
5dee8589d5 Remove trailing whitespaces from test/unit/mailer_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@17623 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-06 02:45:26 +00:00
Go MAEDA
9c99d50713 Removes request and response accessors from Structure class (#28564).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17617 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-03 08:11:22 +00:00
Go MAEDA
46b028b1b8 Fix that the following tests fail randomly due to uninitialized User.current (#29853):
* AttachmentsVisibilityTest#test_attachment_should_be_visible
*
Redmine::AttachmentFieldFormatTest#test_should_accept_a_hash_with_upload_on_create
*
Redmine::AttachmentFieldFormatTest#test_should_replace_attachment_on_update

Patch by Gilad Shanan.


git-svn-id: http://svn.redmine.org/redmine/trunk@17616 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-03 07:15:00 +00:00
Go MAEDA
bae9ffd327 Filter out issues from closed projects in the following widgets (#29449):
* Issues assigned to me
* Reported issues
* Watched issues

Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17611 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-29 06:14:56 +00:00
Go MAEDA
d3ffa9252c Remove trailing whitespaces from test/functional/my_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@17610 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-29 05:48:31 +00:00
Go MAEDA
a0479c768e Filter time entries after project status (#20081).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17608 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-29 04:05:18 +00:00
Go MAEDA
21034c5628 Filter issues after project status (#20081).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17607 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-29 04:03:52 +00:00
Go MAEDA
e8243d213d \f or \v character in Textile markup may cause RegexpError exception (#29756).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17603 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-28 11:01:54 +00:00
Go MAEDA
57a4fedd34 Handles the case when an expired token is in the users session (#29781).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17601 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-28 05:59:11 +00:00
Go MAEDA
ccd524a04a Add missing enabled_modules fixture to TrackerTest (#29820).
Patch by Gilad Shanan.


git-svn-id: http://svn.redmine.org/redmine/trunk@17599 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-20 01:10:20 +00:00
Go MAEDA
facb44cb03 Ensure that vendor-defined characters in ISO-2022-JP email subject don't break issue's subject (#29442).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-15 10:00:18 +00:00
Go MAEDA
7be4200651 Fix broken tests due to r17593 (#29739).
git-svn-id: http://svn.redmine.org/redmine/trunk@17594 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-11 16:14:37 +00:00
Jean-Philippe Lang
b4425f6ec1 #last_email already asserts that mail is not nil.
git-svn-id: http://svn.redmine.org/redmine/trunk@17592 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-10 19:06:21 +00:00
Jean-Philippe Lang
717bef36a3 Journal must be saved.
git-svn-id: http://svn.redmine.org/redmine/trunk@17589 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-10 18:41:12 +00:00
Jean-Philippe Lang
0c78056a69 Send emails asynchronously (#26791).
Custom async_* delivery methods are removed in favor of ActiveJob (Async by default).

git-svn-id: http://svn.redmine.org/redmine/trunk@17588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-10 17:13:09 +00:00
Jean-Philippe Lang
5533eeff23 Fixed that test_email raises an error with #deliver_later (#26791).
git-svn-id: http://svn.redmine.org/redmine/trunk@17587 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 16:07:45 +00:00
Jean-Philippe Lang
015ca36634 Send individual emails for each mail recipient (#26791).
We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.

We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:

We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.

By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.

Patch by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:08:52 +00:00
Go MAEDA
ece41123a1 Remove trailing whitespaces from test/functional/documents_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@17573 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-05 05:27:42 +00:00
Go MAEDA
0438d68db8 Remove trailing whitespaces from test/fixtures/documents.yml
git-svn-id: http://svn.redmine.org/redmine/trunk@17572 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-05 05:26:30 +00:00
Go MAEDA
86a13c5536 Remove trailing whitespaces from test/fixtures/attachments.yml
git-svn-id: http://svn.redmine.org/redmine/trunk@17571 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-05 05:25:33 +00:00
Go MAEDA
7d615fd516 Repository entry pagination (#29395).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17568 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-04 13:24:06 +00:00
Go MAEDA
dcc7ecb34a Attachments prev/next navigation (#29395).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17567 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-04 13:20:11 +00:00
Go MAEDA
28c231473f Custom queries are broken by updating with nil parameter values (#29701).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17566 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-04 12:46:32 +00:00
Go MAEDA
3952c4d264 Extend Issue Summary to include subprojects (#2529).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17563 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-03 07:16:47 +00:00
Go MAEDA
43d9adeb2a Wrong use of refute_includes in tests (#29708).
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17559 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-02 02:12:39 +00:00
Jean-Philippe Lang
9123ae9cb7 SQLite3::ConstraintException
git-svn-id: http://svn.redmine.org/redmine/trunk@17534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-29 09:19:39 +00:00
Jean-Philippe Lang
eb1e6d8c26 Syntax highlighter: replace CodeRay with Rouge (#24681).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-29 06:57:40 +00:00
Jean-Philippe Lang
b9fa262165 Adds preview option to the wiki toolbar (#27758).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17521 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-26 07:27:30 +00:00
Go MAEDA
c76c0900bb Use the id field as project_key in ProjectCustomField#visibility_by_project_condition by default (#29161).
Patch by Holger Just.


git-svn-id: http://svn.redmine.org/redmine/trunk@17517 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-24 05:31:13 +00:00
Jean-Philippe Lang
5282a45b9b Link to user in wiki syntax only works when login is written in lower case (#26892).
Patch by Marius BALTEANU and Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17516 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 14:55:35 +00:00
Jean-Philippe Lang
daa7d2ba18 Support migration context for plugins (#28934).
git-svn-id: http://svn.redmine.org/redmine/trunk@17514 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 14:22:29 +00:00
Jean-Philippe Lang
8eb8cdc06d Remove link to current version, already present in the page breadcrumb (#26575).
git-svn-id: http://svn.redmine.org/redmine/trunk@17510 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 13:58:45 +00:00
Jean-Philippe Lang
a9eaf563a5 Support self-signed LDAPS connections (#29606).
Patch by Gregor Schmidt.

git-svn-id: http://svn.redmine.org/redmine/trunk@17505 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 13:28:36 +00:00
Jean-Philippe Lang
aac543dfba Column Project is no longer added by default to the list of default columns for time entries (#26537).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17503 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 11:59:52 +00:00
Jean-Philippe Lang
5fbe5d74bc Test failures with sqlite3.
git-svn-id: http://svn.redmine.org/redmine/trunk@17502 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 11:57:38 +00:00
Jean-Philippe Lang
e856c9f879 Fixed that issue details page shows default values for custom fields that aren't actually set (#25726).
git-svn-id: http://svn.redmine.org/redmine/trunk@17499 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 08:25:25 +00:00