Commit Graph

5306 Commits

Author SHA1 Message Date
Jean-Philippe Lang
10f96ab2ab Adds tests for #27153.
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17156 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 22:28:37 +00:00
Jean-Philippe Lang
27cd7f478b Cannot clear all watchers when copying an issue (#26880).
git-svn-id: http://svn.redmine.org/redmine/trunk@17153 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 22:18:17 +00:00
Jean-Philippe Lang
c7948ed40d Anonymous user should have their icon (#26699).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17150 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 22:01:56 +00:00
Jean-Philippe Lang
4e6b54e33e Empty email attachments are imported to Redmine, creating broken DB records (#27885).
Patch by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@17147 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:46:58 +00:00
Jean-Philippe Lang
2cb30321a2 No validation errors when entering an invalid "Estimate hours" value (#27881).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:41:15 +00:00
Go MAEDA
c35433ad01 Links for custom field value don't have "external" class (#27024).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-01 06:18:01 +00:00
Toshi MARUYAMA
d2298e419c source code comment slight change (#27865)
git-svn-id: http://svn.redmine.org/redmine/trunk@17136 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-29 15:09:57 +00:00
Toshi MARUYAMA
7a556764ef use relative url at robots.txt (#27865)
git-svn-id: http://svn.redmine.org/redmine/trunk@17135 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-29 14:56:51 +00:00
Toshi MARUYAMA
fca43b026e remove trailing white spaces from test/functional/timelog_report_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@17134 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-28 18:40:25 +00:00
Go MAEDA
f33ddf9749 Issues reports should show only statuses used by the project (#27772).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17121 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-19 10:15:22 +00:00
Go MAEDA
a4931262d0 Strip whitespace from login on login page (#22532).
Patch by Artur Borisovich and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-13 13:58:32 +00:00
Go MAEDA
01085249ab Fix: Strip whitespace from email addresses on lost password page (#27754).
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17078 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-08 08:27:27 +00:00
Toshi MARUYAMA
4e7ae640b9 add copyright header to test/unit/lib/redmine/helpers/url_test.rb (#12510)
git-svn-id: http://svn.redmine.org/redmine/trunk@17077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 14:28:41 +00:00
Toshi MARUYAMA
93d8204b8a code clean up IssuesPdfHelperTest (#12510)
* remove extra empty lines
* remove trailing white space
* replace tab to two spaces

git-svn-id: http://svn.redmine.org/redmine/trunk@17065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 12:03:08 +00:00
Toshi MARUYAMA
9d797400ea mercurial: work around faulty parsing of early command options (#27516)
Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:47 +00:00
Toshi MARUYAMA
ca87bf766c mercurial: reject malicious command argument (#27516)
We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.

https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314

This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.

This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:23 +00:00
Go MAEDA
d6d2d23365 Fix: Round floats to 2 digits when rendering an issue list to PDF (#12510).
Patch by Holger Just and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 14:25:35 +00:00
Go MAEDA
ae842a73db Disallow creating inverse relates issue relations (#27663).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 09:01:07 +00:00
Go MAEDA
0ed07156ad Reverted r17054 (#27663).
The change breaks test/functional/issue_relations_controller_test.rb.



git-svn-id: http://svn.redmine.org/redmine/trunk@17055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-30 00:02:02 +00:00
Go MAEDA
3a310ccc2e Disallow creating inverse relates issue relations (#27663).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17054 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 22:22:39 +00:00
Jean-Philippe Lang
62d6dfe1cc Fixes visibility checks for version.fixed_issues in Gantt (#27676).
Like the version page - the Gantt chart featured a "percent done" info
for each version, which wasn't properly limited to visible issues.

Patch by Gregor Schmidt.

git-svn-id: http://svn.redmine.org/redmine/trunk@17053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 19:38:44 +00:00
Go MAEDA
4a6f9e01d6 Add tests for context menu in gantt (#10485).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17037 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-27 00:34:30 +00:00
Go MAEDA
9ae7bc8152 Make robust Redmine::Helpers::URL#uri_with_safe_scheme? (#27114)
Patch by okkez.


git-svn-id: http://svn.redmine.org/redmine/trunk@17035 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-26 03:44:37 +00:00
Toshi MARUYAMA
e438523e78 remove unused WikisController#edit (#26579)
git-svn-id: http://svn.redmine.org/redmine/trunk@17018 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-05 19:09:05 +00:00
Jean-Philippe Lang
5a775287ab Fix filter after multiple version ids (#26667).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17000 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-10-15 11:54:39 +00:00
Jean-Philippe Lang
cb73fc58f2 Fix filter values for fixed version id (#26667).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@16999 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-10-15 11:53:49 +00:00
Jean-Philippe Lang
0a3e85b92d Filtering time entries after issue's target version doesn't work as expected in some cases (#26667).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@16997 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-10-15 11:42:00 +00:00
Toshi MARUYAMA
caca511d25 remove trailing white spaces from test/functional/queries_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16967 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-09-15 04:49:32 +00:00
Toshi MARUYAMA
abe914fd3f add test that anonymous user can add watchers by mail (#26654)
git-svn-id: http://svn.redmine.org/redmine/trunk@16963 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-09-07 17:22:14 +00:00
Toshi MARUYAMA
0f6fd7584b fix file name corruption when export a wiki page with non-ASCII title in MS browsers (#26599)
Contributed by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16957 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-30 15:46:45 +00:00
Toshi MARUYAMA
aa5e49c37b fix element order (#26769)
git-svn-id: http://svn.redmine.org/redmine/trunk@16954 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-28 04:20:55 +00:00
Toshi MARUYAMA
7cb8ce8e40 add category_id to REST issue creation tests (#26769)
git-svn-id: http://svn.redmine.org/redmine/trunk@16953 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-28 04:15:55 +00:00
Jean-Philippe Lang
143cd53e78 Missing fixtures.
git-svn-id: http://svn.redmine.org/redmine/trunk@16946 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-02 18:38:40 +00:00
Jean-Philippe Lang
9f9f7993e6 #assert_nothing_raised takes no arguments.
git-svn-id: http://svn.redmine.org/redmine/trunk@16944 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-01 21:40:58 +00:00
Jean-Philippe Lang
09e55e3e3a Adds a few tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@16940 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-31 16:44:06 +00:00
Toshi MARUYAMA
eb1998ef39 try IssueTest#test_overdue failing on CI server at Japanese daytime (#22320)
git-svn-id: http://svn.redmine.org/redmine/trunk@16938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-31 06:57:35 +00:00
Jean-Philippe Lang
b3409a604a Renames time_entry_reports_controller_test.rb to timelog_report_test.rb.
git-svn-id: http://svn.redmine.org/redmine/trunk@16933 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 18:31:32 +00:00
Jean-Philippe Lang
a9e4b41d4a Move helper tests to test/helpers (#26504).
git-svn-id: http://svn.redmine.org/redmine/trunk@16930 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 18:23:06 +00:00
Jean-Philippe Lang
d827fc4a75 Skip all issue concurrency tests with MySQL.
git-svn-id: http://svn.redmine.org/redmine/trunk@16926 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 17:09:45 +00:00
Jean-Philippe Lang
f2480d3ee3 Test broken by r16924 (#26520).
git-svn-id: http://svn.redmine.org/redmine/trunk@16925 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 17:02:24 +00:00
Jean-Philippe Lang
e89b93f8d1 Fill the issue id when logging time from the time log list of an issue (#26520).
git-svn-id: http://svn.redmine.org/redmine/trunk@16924 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 16:42:55 +00:00
Jean-Philippe Lang
b996c36315 Adds a test for #26564.
Patch by Toshi MARUYAMA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16919 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 16:31:12 +00:00
Jean-Philippe Lang
6712ef52c2 Removes wiki tab in project settings (#26579).
git-svn-id: http://svn.redmine.org/redmine/trunk@16917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 08:28:50 +00:00
Jean-Philippe Lang
e930ee8e98 Adds a checkbox to set a page as the wiki start page (#26579).
git-svn-id: http://svn.redmine.org/redmine/trunk@16915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 07:38:48 +00:00
Jean-Philippe Lang
1587d71635 Adds some system tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@16908 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-29 08:30:13 +00:00
Jean-Philippe Lang
4cc65b29cf Adds a system test for creating an issue with attachment.
git-svn-id: http://svn.redmine.org/redmine/trunk@16907 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-29 08:19:25 +00:00
Jean-Philippe Lang
000ff80320 Project settings: Move issue tracking settings to their own tab (#26488).
git-svn-id: http://svn.redmine.org/redmine/trunk@16896 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-27 16:42:50 +00:00
Toshi MARUYAMA
09148ba665 add missing fixture for IssueTest#test_update_should_notify_previous_assignee
git-svn-id: http://svn.redmine.org/redmine/trunk@16894 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-27 07:19:31 +00:00
Jean-Philippe Lang
449d5e6d34 Removes the Modules tab in project settings (#26488).
Modules can now be select on the first tab, just like when creating a project.

git-svn-id: http://svn.redmine.org/redmine/trunk@16892 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-26 17:07:43 +00:00
Jean-Philippe Lang
9f346d5921 Make sure that something was actually deleted.
git-svn-id: http://svn.redmine.org/redmine/trunk@16890 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-26 16:43:19 +00:00