Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-07 22:05:56 +01:00
Code Issues Packages Projects Releases Activity
16,614 Commits 35 Branches 222 Tags
c334fe23b18cba0fb69aff026fc0073e1a44e147
Commit Graph

90 Commits

Author SHA1 Message Date
Toshi MARUYAMA
c334fe23b1 add 'freeze' to avoid immutable array literals in loops at MercurialAdapterTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@20642 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-12-12 15:49:59 +00:00
Toshi MARUYAMA
fd3b7dd4ca fix source indent of MercurialAdapterTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@20538 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-12-02 13:31:15 +00:00
Go MAEDA
78dfef0978 Replace gsub with tr, delete, or squeeze (#34161). 
git-svn-id: http://svn.redmine.org/redmine/trunk@20176 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-10-24 06:46:50 +00:00
Toshi MARUYAMA
8abbf9ac2f fix source indent of MercurialAdapterTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@20072 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-09-24 16:06:40 +00:00
Toshi MARUYAMA
77fceb7585 add space after comma to MercurialAdapterTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@20042 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-09-17 15:48:33 +00:00
Toshi MARUYAMA
858f323da1 fix source indent of MercurialAdapterTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@20041 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-09-17 15:48:25 +00:00
Go MAEDA
2eb7d4fd35 Fix a RuboCop offense Layout/TrailingWhitespace due to r19766 (#27790). 
git-svn-id: http://svn.redmine.org/redmine/trunk@19768 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-05-09 03:19:04 +00:00
Toshi MARUYAMA
6404ee5714 scm: mercurial: add double quote branch and tag name to test repository (#27790) 
git-svn-id: http://svn.redmine.org/redmine/trunk@19766 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-05-08 13:08:40 +00:00
Toshi MARUYAMA
07d14ce721 scm: mercurial: refactor MercurialAdapterTest#test_branches for easy adding new branch to test repository 
git-svn-id: http://svn.redmine.org/redmine/trunk@19764 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-05-08 12:25:37 +00:00
Toshi MARUYAMA
14f0215dbf fix source indents of MercurialAdapterTest 
git-svn-id: http://svn.redmine.org/redmine/trunk@19761 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-05-08 12:25:08 +00:00
Toshi MARUYAMA
12318cff4d scm: mercurial: add test of author and message which have control character (#23055) 
git-svn-id: http://svn.redmine.org/redmine/trunk@19608 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-03-22 16:35:09 +00:00
Toshi MARUYAMA
8de1d87e70 scm: mercurial: update test repository (#23055) 
git-svn-id: http://svn.redmine.org/redmine/trunk@19607 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-03-22 16:34:59 +00:00
Toshi MARUYAMA
28f91a7332 scm: mercurial: refactor MercurialAdapterTest#test_branches for easy adding new branch to test repository 
git-svn-id: http://svn.redmine.org/redmine/trunk@19605 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-03-22 16:15:14 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069). 
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
513e869c93 cleanup: rubocop: fix Layout/AlignArguments in test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@18935 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-11-08 00:46:03 +00:00
Toshi MARUYAMA
9fa084133b code clean up test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@18344 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-08-04 04:51:26 +00:00
Toshi MARUYAMA
6e6b01a65e rubocop: fix Layout/BlockAlignment of test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@18343 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-08-04 04:51:14 +00:00
Toshi MARUYAMA
4b95697d23 rubocop: fix Layout/CaseIndentation of test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@18338 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-08-03 05:33:57 +00:00
Toshi MARUYAMA
ec4177a2f3 rubocop: fix Layout/AlignArray of test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@18332 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-07-29 12:47:01 +00:00
Go MAEDA
4082069c75 Update copyright year. 
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-25 07:36:06 +00:00
Go MAEDA
b900ae6107 Support frozen_string_literal in test/**/*.rb (#26561). 
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17996 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-21 03:27:53 +00:00
Go MAEDA
26509e7f4c Decode hexadecimal-encoded literals in order to be frozen string literals friendly (#31004). 
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17991 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-19 15:43:55 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561). 
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-15 01:32:57 +00:00
Toshi MARUYAMA
9d797400ea mercurial: work around faulty parsing of early command options (#27516) 
Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-12-07 11:38:47 +00:00
Toshi MARUYAMA
ca87bf766c mercurial: reject malicious command argument (#27516) 
We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.

https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314

This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.

This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-12-07 11:38:23 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
5a77904a91 Don't use assert_equal nil. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16072 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-12-13 20:12:34 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016. 
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
000124f44f Copyright update. 
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534). 
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-10-22 17:37:16 +00:00
Toshi MARUYAMA
e266ddb309 scm: mercurial: add one "closed" branch to test repository (#16177) 
git-svn-id: http://svn.redmine.org/redmine/trunk@12929 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-02-26 11:27:41 +00:00
Toshi MARUYAMA
5872d079e6 scm: mercurial: use long id in adapter level (#14361) 
git-svn-id: http://svn.redmine.org/redmine/trunk@12761 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-02-02 04:44:38 +00:00
Toshi MARUYAMA
d26b4fc5b7 scm: mercurial: add adapter entry test (#14361) 
git-svn-id: http://svn.redmine.org/redmine/trunk@12756 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-02-02 04:43:17 +00:00
Toshi MARUYAMA
f2ec6f8d77 back out r12752 (#14361) 
Revision, Author and Comment of repository browser are broken.

git-svn-id: http://svn.redmine.org/redmine/trunk@12753 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-02-01 08:46:47 +00:00
Toshi MARUYAMA
ae68ff1100 scm: mercurial: use long id in adapter level (#14361) 
git-svn-id: http://svn.redmine.org/redmine/trunk@12752 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-02-01 07:47:04 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977) 
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-01-29 22:45:39 +00:00
Toshi MARUYAMA
596366b062 upgrade mocha 0.14 and remove deprecation warning 
<pre>
Mocha deprecation warning: Change `require 'mocha'` to `require 'mocha/setup'`.
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11896 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2013-05-21 12:57:11 +00:00
Jean-Philippe Lang
e396a0eebe Copyright for 2013 (#12788). 
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2013-01-12 09:29:31 +00:00
Toshi MARUYAMA
17db2dca3d scm: mercurial: add test of diff from new to old revision to unit lib test 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10390 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-09-16 08:51:19 +00:00
Toshi MARUYAMA
c70bc540dd add copyright statement to test/unit/lib/redmine/scm/adapters/*.rb 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10378 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-09-14 21:40:45 +00:00
Toshi MARUYAMA
2b4549b3ea scm: mercurial: test: lib: update branches test for Branch class (#5501) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7674 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-10-28 05:19:58 +00:00
Toshi MARUYAMA
613a056ed6 scm: mercurial: test: add test of parents to unit lib test (#5501) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7667 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-10-28 04:57:43 +00:00
Toshi MARUYAMA
476c3d54b7 scm: mercurial: update test repository (#5501) 
This test repository has one merged revision.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7662 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-10-28 01:44:12 +00:00
Toshi MARUYAMA
81ef038587 scm: mercurial: drop supporting below Mercurial 1.1 (#9465) 
On November 1st 2011, Mercurial 2.0 will be released.

On Mercurial 1.1.2, unit lib test fails with following error.

<pre>
Traceback (most recent call last):
  File "/WEB-DOWN/hg-repo/hg-crew/hg", line 20, in <module>
    mercurial.dispatch.run()
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 20, in run
    sys.exit(dispatch(sys.argv[1:]))
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 29, in dispatch
    return _runcatch(u, args)
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 45, in _runcatch
    return _dispatch(ui, args)
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 367, in _dispatch
    ret = _runcommand(ui, options, cmd, d)
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 416, in _runcommand
    return checkargs()
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 376, in checkargs
    return cmdfunc()
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 361, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/util.py", line 715, in check
    return func(*args, **kwargs)
  File "/REDMINE-1/hg-workdir/redmine-bb-all/lib/redmine/scm/adapters/mercurial/redminehelper.py", line 149, in rhlog
    if hg.util.version() >= '1.6':
AttributeError: 'module' object has no attribute 'version'

  1) Error:
test_nodes_in_branch(MercurialAdapterTest):
Redmine::Scm::Adapters::MercurialAdapter::HgCommandAborted: hg exited with non-zero status: 1
    lib/redmine/scm/adapters/mercurial_adapter.rb:306:in `hg'
    lib/redmine/scm/adapters/mercurial_adapter.rb:234:in `nodes_in_branch'
    test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb:311:in `test_nodes_in_branch'
    test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb:304:in `each'
    test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb:304:in `test_nodes_in_branch'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7650 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-10-25 06:10:12 +00:00
Toshi MARUYAMA
74cbbd38d0 scm: mercurial: skip failing unit lib tests on below Mercurial 1.5 (#9465) 
Tests of non ASCII nor alphabetic nor numeric *named branch* fails on below Mercurial 1.5.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7642 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-10-24 09:32:38 +00:00
Toshi MARUYAMA
3baabca8f2 scm: mercurial: replace RAILS_ROOT to Rails.root in unit adapter test. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6050 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-06-10 11:09:50 +00:00
Toshi MARUYAMA
c9a3d925ca scm: mercurial: add unit adapter test of default path_encoding is UTF-8 (#2664). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5869 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-05-21 02:38:56 +00:00
Toshi MARUYAMA
1f0ddc3199 scm: mercurial: code clean up unit adapter test. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5826 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-05-18 02:18:25 +00:00
Toshi MARUYAMA
e5606c8d32 scm: mercurial: remove trailing white-spaces from unit adapter test. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5781 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-05-13 06:17:34 +00:00
Toshi MARUYAMA
46d970a552 scm: mercurial: add client command tests at unit adapter test (#4273). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5361 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2011-04-08 04:53:11 +00:00