Toshi MARUYAMA
745e4152f8
remove spaces inside {} of ApplicationController
...
git-svn-id: http://svn.redmine.org/redmine/trunk@20409 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-17 12:41:18 +00:00
Toshi MARUYAMA
834bc11cc9
use "do end" instead of {} at ApplicationController
...
git-svn-id: http://svn.redmine.org/redmine/trunk@20142 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-11 12:57:39 +00:00
Toshi MARUYAMA
a6b68a82c6
add space after comma to ApplicationController
...
git-svn-id: http://svn.redmine.org/redmine/trunk@20134 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-11 12:56:36 +00:00
Toshi MARUYAMA
d7e881617d
add empty line after guard clause to ApplicationController
...
git-svn-id: http://svn.redmine.org/redmine/trunk@20046 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-17 15:49:06 +00:00
Go MAEDA
be7f5e21fa
Adds a setting to disable/enable/require 2fa auth ( #1237 ).
...
Patch by Felix Schäfer.
git-svn-id: http://svn.redmine.org/redmine/trunk@19989 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-29 06:37:09 +00:00
Toshi MARUYAMA
562dea3aa8
avoid using rescue in its modifier form at ApplicationController#find_current_user
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19862 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-08 17:29:56 +00:00
Go MAEDA
907e0173e4
Update copyright year in source files to 2020 ( #33069 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Jean-Philippe Lang
0cd14b3a4b
Validate back_url everywhere ( #32850 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@19488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 08:39:22 +00:00
Jean-Philippe Lang
b3cda4fd61
Expose validate_back_url as helper method ( #32850 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@19487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 08:38:47 +00:00
Jean-Philippe Lang
914f57fefc
Move duplicated back_url method from ApplicationHelper to ApplicationController ( #32850 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@19486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 08:38:01 +00:00
Go MAEDA
f7fcd111e9
Ruby 2.7: Regexp#match and Regexp#match? with a nil argument are deprecated ( #32527 , #31500 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19324 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-30 05:40:40 +00:00
Toshi MARUYAMA
cb591d0af6
code layout clean up app/controllers/application_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 06:32:28 +00:00
Toshi MARUYAMA
4a60ebd848
cleanup: rubocop: fix Layout/SpaceInsideParens in app/controllers/application_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19253 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-24 13:18:21 +00:00
Toshi MARUYAMA
252450b44c
code cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/application_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18821 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:41:21 +00:00
Go MAEDA
4082069c75
Update copyright year.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
6d6ea928c8
Custom Exception classes should inherit StandardError instead of Exception ( #31387 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18187 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-21 23:53:10 +00:00
Go MAEDA
29403e710a
Adds favorites and recently used projects lists to project jump box ( #31355 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@18181 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-20 22:26:30 +00:00
Go MAEDA
f992df684f
Small refactorization of avatar methods ( #31391 ).
...
* move existing methods from ApplicationHelper to a new helper file (AvatarsHelper)
* change default avatar size from 50 to 24 because most of the avatars are using the size 24
* class 'gravatar' is always added and all custom classes are appended
* added user name as default title for avatar images
* added two new methods: @assignee_avatar@ and @author_avatar@
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@18175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-19 22:27:41 +00:00
Go MAEDA
6ef0a4c4cc
Use HTTP status code 403 instead of 401 when REST API is disabled ( #30086 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-04-10 02:51:28 +00:00
Go MAEDA
72e1451159
Use Regexp#match? to reduce allocations of MatchData object ( #28940 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
07b3087fda
Enable frozen_string_literal for some files under app and lib directory ( #26561 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc
Add "frozen_string_literal: false" for all files ( #26561 ).
...
This will be changed to true in the future.
git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
29063283da
Ajax Request Returns 200 but an error event is fired instead of success ( #30073 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@17849 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-05 08:33:29 +00:00
Jean-Philippe Lang
3ba51f205d
Let admins unarchive the project when trying to access an archived project ( #29993 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17682 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-02 11:23:10 +00:00
Go MAEDA
679cf413ab
Log exception's message when ActionView::MissingTemplate is raised ( #26341 ).
...
Patch by Vincent Robert.
git-svn-id: http://svn.redmine.org/redmine/trunk@17174 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-11 12:29:52 +00:00
Jean-Philippe Lang
2eaabae252
Don't redirect anonymous users to the login form when module is disabled ( #26145 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16726 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-26 21:04:34 +00:00
Jean-Philippe Lang
310060ff57
Code cleanup.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16725 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-26 20:51:28 +00:00
Jean-Philippe Lang
e7c0e16a3f
Use regular #authorize method.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16724 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-26 20:41:12 +00:00
Jean-Philippe Lang
7fd04e1f8d
Update copyright.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
f6defca16d
redirect_to :back deprecated in Rails 5.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-03 07:51:48 +00:00
Jean-Philippe Lang
da4f9ce34d
Don't call #head with a hash.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-01 18:28:18 +00:00
Jean-Philippe Lang
b9ee00a8c8
Adds methods to User model to handle tokens.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16474 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-04 17:15:07 +00:00
Toshi MARUYAMA
6139e0033a
spelling fixes ( #25495 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-02 03:34:44 +00:00
Jean-Philippe Lang
6eaceed7b5
Delete :issue_query from session instead of :query.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16402 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-14 18:20:47 +00:00
Jean-Philippe Lang
6a1865905f
Don't redirect to lost password page after login ( #13741 ).
...
Patch by Gregory Van der Steen.
git-svn-id: http://svn.redmine.org/redmine/trunk@16151 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-07 10:49:31 +00:00
Jean-Philippe Lang
3ccf7cf7ff
Set user's localization before redirecting ( #23346 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@15775 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-08-31 17:01:47 +00:00
Jean-Philippe Lang
8b107b6058
Don't use render :text => "".
...
git-svn-id: http://svn.redmine.org/redmine/trunk@15731 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-21 20:49:14 +00:00
Jean-Philippe Lang
57afa5345e
Don't pass conditions to #delete_all.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@15675 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-16 10:30:45 +00:00
Jean-Philippe Lang
9e20edf2d4
Don't generate URL from params.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@15659 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 07:43:34 +00:00
Jean-Philippe Lang
ee82a55602
Use .before_action instead of .before_filter.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@15655 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 07:27:31 +00:00
Jean-Philippe Lang
f694839c82
Code cleanup ( #23054 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@15534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-15 18:24:02 +00:00
Jean-Philippe Lang
cda9c63d9c
Updates copyright for 2016.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
5d70fce6ce
Security notifications when password or email adress is changed ( #21421 ).
...
Patch by Jan Schulz-Hofen.
git-svn-id: http://svn.redmine.org/redmine/trunk@15145 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-02-05 07:33:24 +00:00
Jean-Philippe Lang
c9ae44e85b
Fix Non ASCII attachment filename encoding broken (MOJIBAKE) in Microsoft Edge Explorer ( #21656 ).
...
Patch by by Hang Xie.
git-svn-id: http://svn.redmine.org/redmine/trunk@15013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-01-09 08:37:07 +00:00
Jean-Philippe Lang
4cd22dcc55
Keep track of valid user sessions ( #21058 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@14735 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-24 10:15:22 +00:00
Jean-Philippe Lang
4714b31002
Preload issues custom values for bulk operations.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@14730 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-23 16:51:46 +00:00
Jean-Philippe Lang
7356e18d36
Include helper instead of patching ( #20508 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@14693 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-19 17:30:28 +00:00
Jean-Philippe Lang
032f2c9be6
Open redirect vulnerability ( #19577 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@14560 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-09-13 14:35:20 +00:00
Jean-Philippe Lang
d6f389658b
Require password re-entry for sensitive actions ( #19851 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@14333 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-06-19 18:41:10 +00:00
Jean-Philippe Lang
51f7060aa8
Add the ability to expire passwords after a configurable number of days ( #19458 ).
...
Patch by Holger Just and Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@14264 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-05-10 10:26:55 +00:00