Commit Graph

191 Commits

Author SHA1 Message Date
Go MAEDA
4fb1e4bea0 Use fixtures :all to ensure consistent test data and improve test reliability (#41961).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23391 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-12-11 10:17:57 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Go MAEDA
421dc8320f Receive e-mail replies to news and news comments (#38274).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22160 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-26 05:35:50 +00:00
Go MAEDA
79f0c64e29 Add MissingContainer exception to MailHandler (#38273).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22158 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-26 05:11:26 +00:00
Go MAEDA
96a718547d Try importing journal replies as issue reply where applicable (#38263).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22119 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-02-27 09:43:37 +00:00
Go MAEDA
1481c721a2 Use require_relative instead of require File.expand_path(..., __FILE__) (#38093).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22016 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 07:13:39 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Marius Balteanu
9c4df39c7d Setting @--no-permission-check@ in the mail receiver should not allow creating issues in closed and archived projects (#37187).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21641 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-06-16 21:32:02 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
578e367c8c Allow addition/removal of subtasks to show in parent's history (#6033).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21273 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-08 14:22:06 +00:00
Go MAEDA
cbd5f2ce8c Mail handler bypasses add_issue_notes permission (#35045).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20970 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-25 13:02:13 +00:00
Go MAEDA
ccd00df71c MailHandler raises NameError exception when generating error message (#35100).
Patch by Dmitry Makurin and Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20959 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-22 03:07:42 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
76cab94d10 fix source indent of test/unit/mail_handler_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20552 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-03 13:19:25 +00:00
Toshi MARUYAMA
51625172d9 fix source indent of test/unit/mail_handler_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-29 12:48:01 +00:00
Toshi MARUYAMA
faaf13aa6a shorten long line of MailHandlerTest#test_email_with_long_subject_line
git-svn-id: http://svn.redmine.org/redmine/trunk@20496 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-26 14:46:05 +00:00
Toshi MARUYAMA
c866eb56fb fix source indent of MailHandlerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@20210 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-27 15:18:41 +00:00
Toshi MARUYAMA
f435e1993d remove spaces inside {} of MailHandlerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@19963 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-09 15:56:31 +00:00
Toshi MARUYAMA
c77b108279 add space after comma to MailHandlerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@19962 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-09 15:56:23 +00:00
Toshi MARUYAMA
6b1fe6a2b4 add S/MIME signature mail test (#31593)
git-svn-id: http://svn.redmine.org/redmine/trunk@19808 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-03 16:17:03 +00:00
Toshi MARUYAMA
e2a8c53938 remove unneeded literal interpolation from MailHandlerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@19807 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-03 16:16:52 +00:00
Toshi MARUYAMA
040b473e55 use "assert_not" instead of "refute" at MailHandlerTest#test_add_issue_with_private_keyword
git-svn-id: http://svn.redmine.org/redmine/trunk@19806 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-03 16:11:04 +00:00
Toshi MARUYAMA
6d2cc2fbd7 add parentheses to nested method call in MailHandlerTest#test_safe_receive_should_rescue_exceptions_and_return_false
git-svn-id: http://svn.redmine.org/redmine/trunk@19805 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-03 16:08:47 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
1bd403015a cleanup: rubocop: fix Layout/AlignArguments in test/unit/mail_handler_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18901 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-05 14:08:03 +00:00
Toshi MARUYAMA
91c56e2cbd code cleanup: rubocop: fix Style/AsciiComments in test/unit/mail_handler_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-09 02:05:25 +00:00
Go MAEDA
5ce4a363a9 Fix test failure due to missing call to set_tmp_attachments_directory (#32122).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18593 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-04 11:17:33 +00:00
Toshi MARUYAMA
004b1e35f5 add missing fixtures to MailHandlerTest (#31946)
git-svn-id: http://svn.redmine.org/redmine/trunk@18509 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 04:48:14 +00:00
Go MAEDA
75df6ead3b Log info messages when MailHandler ignored a reply to a nonexistent issue, journal, or message (#31946).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 09:38:39 +00:00
Go MAEDA
5755bed4e1 Change textfield to textarea for "Exclude attachments by name" (#19903).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18476 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-18 01:25:47 +00:00
Go MAEDA
959b55779f Fix hard-coded string "no subject" in app/models/mail_handler.rb (#5820).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 00:09:10 +00:00
Go MAEDA
db3ee07a55 Reverts r18245 (#31582, #31365).
Issue subjets are truncated in some cases when they are created via email.


git-svn-id: http://svn.redmine.org/redmine/trunk@18269 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 06:57:45 +00:00
Jean-Philippe Lang
7a66b3b1da Issue subject may be broken if the subject field is split into multiple lines (#31365).
Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18245 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-10 11:40:48 +00:00
Go MAEDA
7bb8ab5e24 Fix "Undefined local variable sender_email" error in MailHandler#receive_message_reply when receiving a reply to a locked topic (#31503).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18239 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-10 00:54:28 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
b0e17e8199 Don't rescue Exception class (#31387).
Patch by Go MAEDA and Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 06:50:25 +00:00
Go MAEDA
143c359d90 Allows setting the private flag via mail keyword (#31324).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@18150 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-09 22:30:29 +00:00
Go MAEDA
b900ae6107 Support frozen_string_literal in test/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17996 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-21 03:27:53 +00:00
Go MAEDA
26509e7f4c Decode hexadecimal-encoded literals in order to be frozen string literals friendly (#31004).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17991 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-19 15:43:55 +00:00
Go MAEDA
e70c283a22 Remove unnecessary encoding magic comment (#31034).
The default script encoding is UTF-8 in Ruby 2.0 or later.

Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 06:26:33 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
472ea47808 Test for r17914 (#17699).
git-svn-id: http://svn.redmine.org/redmine/trunk@17915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-03 13:00:07 +00:00
Go MAEDA
77f35cb818 Option to parse HTML part of multipart (HTML) emails first (#30838).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17913 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-03 08:17:59 +00:00
Go MAEDA
b41c5c89d4 Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name (#30785).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-18 13:21:18 +00:00
Jean-Philippe Lang
7145e6d09a Test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17731 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-13 17:54:40 +00:00
Jean-Philippe Lang
b97770dc5c Test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17730 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-13 17:53:47 +00:00
Go MAEDA
f743d2356f Fix: Attachments are added even if validation fails when updating an issue via email (#28576).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@17630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-23 06:07:32 +00:00
Go MAEDA
facb44cb03 Ensure that vendor-defined characters in ISO-2022-JP email subject don't break issue's subject (#29442).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-15 10:00:18 +00:00
Jean-Philippe Lang
0c78056a69 Send emails asynchronously (#26791).
Custom async_* delivery methods are removed in favor of ActiveJob (Async by default).

git-svn-id: http://svn.redmine.org/redmine/trunk@17588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-10 17:13:09 +00:00
Jean-Philippe Lang
015ca36634 Send individual emails for each mail recipient (#26791).
We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.

We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:

We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.

By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.

Patch by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:08:52 +00:00