Commit Graph

77 Commits

Author SHA1 Message Date
Toshi MARUYAMA
e8785b7ac2 use "do end" instead of {} at ActiveRecord scope lambda of app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20345 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-12 12:31:43 +00:00
Toshi MARUYAMA
3a0b7d6a2f remove spaces inside {} of app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20324 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-10 11:09:54 +00:00
Toshi MARUYAMA
3c10f4bece use "do end" instead of {} at app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20298 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-08 13:01:55 +00:00
Toshi MARUYAMA
3758b91e54 add empty line after guard clause to app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20260 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-05 13:42:00 +00:00
Toshi MARUYAMA
fb251df344 fix source indent of app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20089 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-26 15:02:50 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
47a71c8011 Reverts r19478 (#32897).
git-svn-id: http://svn.redmine.org/redmine/trunk@19479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-30 05:27:52 +00:00
Go MAEDA
10bb12e09f Fix 'DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1.' (#32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-28 09:49:14 +00:00
Toshi MARUYAMA
ea859aedca cleanup: rubocop: fix Layout/AlignArguments in app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 06:26:33 +00:00
Toshi MARUYAMA
40f1b0f3f3 code layout clean up app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18830 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:53:48 +00:00
Toshi MARUYAMA
e079d49dd7 code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:53:37 +00:00
Toshi MARUYAMA
9cf1621083 code cleanup: rubocop: fix Style/WhenThen in app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18724 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 16:40:43 +00:00
Toshi MARUYAMA
c32277a42b fix Role#find_or_create_system_role is not private
git-svn-id: http://svn.redmine.org/redmine/trunk@18693 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-16 14:36:20 +00:00
Jean-Philippe Lang
3ddab944d5 Increase maximum size for role name (#27625).
Patch by Aleksandar Pavic.

git-svn-id: http://svn.redmine.org/redmine/trunk@18296 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 13:59:16 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
e159928e6b Use find_by instead of where.first to remove unnecessary sorting (#26747).
Patch by  Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 16:03:26 +00:00
Jean-Philippe Lang
c1e7146498 Removes deprecated methods.
git-svn-id: http://svn.redmine.org/redmine/trunk@16871 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 16:18:27 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
44c748f968 Use regular instance methods instead of association extensions.
Rails 5.1 seems to mess things up in this particular case (role.workflow_rules.copy calls the extension declare in Tracker model).

git-svn-id: http://svn.redmine.org/redmine/trunk@16597 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-03 08:04:13 +00:00
Toshi MARUYAMA
74b09be185 remove trailing white space from app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16074 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-14 10:53:15 +00:00
Jean-Philippe Lang
3e86a2ab52 Use .unscoped when querying and creating builtin objects (#24156).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@16049 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-03 08:57:01 +00:00
Jean-Philippe Lang
d8df8c8bcb Role#copy_from should copy managed roles.
git-svn-id: http://svn.redmine.org/redmine/trunk@15913 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-20 17:00:04 +00:00
Jean-Philippe Lang
a2b17dae6e Fixed that r15668 prevents from setting managed roles.
git-svn-id: http://svn.redmine.org/redmine/trunk@15912 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-20 16:57:15 +00:00
Jean-Philippe Lang
adde498b33 Use safe_attributes.
git-svn-id: http://svn.redmine.org/redmine/trunk@15668 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-16 09:30:09 +00:00
Jean-Philippe Lang
83777f727a Assignable users should not include users that cannot view the tracker (#23172).
git-svn-id: http://svn.redmine.org/redmine/trunk@15586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-28 20:31:08 +00:00
Jean-Philippe Lang
79df68e17f Limit trackers for new issue to certain roles (#7839).
git-svn-id: http://svn.redmine.org/redmine/trunk@15464 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-05 10:06:17 +00:00
Jean-Philippe Lang
64afa24a7f Replaces acts_as_list with an implementation that handles #position= (#12909).
Objects are reordered using the regular attribute writer #position= and AR callbacks.

git-svn-id: http://svn.redmine.org/redmine/trunk@15335 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-04-17 06:57:20 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
ed9f00178c Ability to limit member management to certain roles (#19707).
git-svn-id: http://svn.redmine.org/redmine/trunk@14293 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-05-31 07:16:23 +00:00
Jean-Philippe Lang
6659aad3ef Adds a role setting that viewing all or own time entries (#8929).
git-svn-id: http://svn.redmine.org/redmine/trunk@14275 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-05-30 07:40:57 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
0eda7765fa Skip validation if attribute did not change.
git-svn-id: http://svn.redmine.org/redmine/trunk@13851 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-07 22:51:45 +00:00
Jean-Philippe Lang
2a6692248b Replaced "can't" with "cannot" in error messages.
git-svn-id: http://svn.redmine.org/redmine/trunk@13781 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-21 12:39:48 +00:00
Jean-Philippe Lang
453803c68f Don't consider roles without issue add/edit permissions for determining fields permissions (#15988).
git-svn-id: http://svn.redmine.org/redmine/trunk@13747 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-13 14:31:58 +00:00
Jean-Philippe Lang
bdd3ccf8e5 Adds a role setting for controlling visibility of users: all or members of visible projects (#11724).
git-svn-id: http://svn.redmine.org/redmine/trunk@13584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-11 13:08:52 +00:00
Jean-Philippe Lang
522bebe5ed Order scopes cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@13526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-29 21:49:33 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00
Jean-Philippe Lang
628d05629b Role-based issue custom field visibility (#5037).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 09:20:11 +00:00
Toshi MARUYAMA
36120d17e7 remove trailing white-space from app/models/role.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11715 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-04-12 01:50:01 +00:00
Jean-Philippe Lang
e396a0eebe Copyright for 2013 (#12788).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:29:31 +00:00
Jean-Baptiste Barth
4896d5c7e8 Use lambda form in model scopes (#12499)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10949 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-07 10:12:47 +00:00
Jean-Philippe Lang
5328c4adcb Anonymous users should always see public issues only (#11872).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10437 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-09-20 19:26:58 +00:00
Jean-Philippe Lang
ca7498c2d6 Create role by copy (#9258).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10285 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-09-03 17:04:28 +00:00
Jean-Philippe Lang
d7b669e50b Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-15 14:12:17 +00:00
Jean-Philippe Lang
a1f17b982c Perf: use a custom decoder for Role#permissions instead of YAML.load.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9916 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-05 13:04:38 +00:00
Jean-Philippe Lang
aa18cd54c7 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9715 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-05-25 20:43:18 +00:00