Commit Graph

77 Commits

Author SHA1 Message Date
Toshi MARUYAMA
bad4654b78 use "do end" instead of {} at ActiveRecord scope lambda of app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20319 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-09 13:25:27 +00:00
Toshi MARUYAMA
f4aa4b0f87 shorten long line of app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20159 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-22 14:17:43 +00:00
Go MAEDA
e48ff48820 Evaluate acts_as_activity_provider's scope lazily (#33664).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-17 02:02:50 +00:00
Toshi MARUYAMA
04206e70d4 remove spaces inside {} of app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19881 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 01:21:35 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
1cca05ecf3 cleanup: rubocop: fix Layout/ClosingParenthesisIndentation in app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:30:01 +00:00
Toshi MARUYAMA
3ccbfd9ec1 cleanup: rubocop: fix Layout/IndentFirstArgument in app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19307 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 18:58:05 +00:00
Toshi MARUYAMA
466a5bd3a8 cleanup: rubocop: fix Layout/EmptyLineAfterGuardClause in app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19171 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 14:54:54 +00:00
Toshi MARUYAMA
12fbc3a817 cleanup: rubocop: fix Layout/AlignArguments in app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18936 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 00:46:13 +00:00
Go MAEDA
16c580a2f8 Option to send email notification on "Target version updated" (#17840).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 09:46:05 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
d4daf4e23b Support frozen_string_literal in issue, journal, and query (#26561).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17980 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 00:29:58 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
0c78056a69 Send emails asynchronously (#26791).
Custom async_* delivery methods are removed in favor of ActiveJob (Async by default).

git-svn-id: http://svn.redmine.org/redmine/trunk@17588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-10 17:13:09 +00:00
Jean-Philippe Lang
5416ed1022 Cleanup: Remove Issue#each_notification and Journal#each_notification (#26791).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@17584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:09:38 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
9439cae70f Send journal notification after commit (#25794).
git-svn-id: http://svn.redmine.org/redmine/trunk@16573 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-05-27 08:44:24 +00:00
Jean-Philippe Lang
151a215ea4 Adds updated_by and last_updated_by filters on issues (#17720).
git-svn-id: http://svn.redmine.org/redmine/trunk@16228 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-19 20:16:49 +00:00
Jean-Philippe Lang
7b32a0371d Let user always see his private notes (#17632).
git-svn-id: http://svn.redmine.org/redmine/trunk@16181 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-14 09:50:28 +00:00
Jean-Philippe Lang
fcbd06e090 Allow Journal to return empty Array instead nil in Journal#attachments (#24308).
Patch by Roman Shipiev.

git-svn-id: http://svn.redmine.org/redmine/trunk@15957 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-11-18 08:41:56 +00:00
Jean-Philippe Lang
55be3ef172 Journalize values that are cleared after project or tracker change (#21623).
git-svn-id: http://svn.redmine.org/redmine/trunk@15811 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-09-03 07:26:49 +00:00
Jean-Philippe Lang
d2f7e31951 Use .distinct instead of .uniq.
git-svn-id: http://svn.redmine.org/redmine/trunk@15654 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 07:15:13 +00:00
Jean-Philippe Lang
1f9bbd6b42 Wrap journal attributes with a journal parameter and use safe_attributes (#22575).
git-svn-id: http://svn.redmine.org/redmine/trunk@15621 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-10 10:58:00 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
cb9d405db3 Fixed that journals are shown multiple times in activity (#19168).
git-svn-id: http://svn.redmine.org/redmine/trunk@14163 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-04-12 07:55:30 +00:00
Jean-Philippe Lang
726a9aa809 Set :inverse_of on details association.
git-svn-id: http://svn.redmine.org/redmine/trunk@13936 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-24 10:23:53 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
2462a8581d Don't create a journal when creating an issue.
git-svn-id: http://svn.redmine.org/redmine/trunk@13732 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-08 17:18:28 +00:00
Jean-Philippe Lang
7673910a2d Moved journal details generation to Journal model.
git-svn-id: http://svn.redmine.org/redmine/trunk@13703 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 08:03:32 +00:00
Toshi MARUYAMA
6f92548b38 remove unneeded "references" of joins
"references" is needed for includes, but not needed for joins.

git-svn-id: http://svn.redmine.org/redmine/trunk@13501 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-24 02:18:45 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Jean-Philippe Lang
4bf18a697c Adds an option to send email on "Assignee updated" in application settings (#16362).
git-svn-id: http://svn.redmine.org/redmine/trunk@12975 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-03-17 08:20:27 +00:00
Jean-Philippe Lang
b695878193 Adds an option to send email on "Assignee updated" in application settings (#16362).
git-svn-id: http://svn.redmine.org/redmine/trunk@12974 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-03-17 08:19:45 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00
Toshi MARUYAMA
3b3a7c50a9 remove unneeded Relation#all from Journal model
git-svn-id: http://svn.redmine.org/redmine/trunk@12727 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-27 02:17:57 +00:00
Toshi MARUYAMA
89b5518e0b Rails4: replace deprecated find_all_by_* at Journal model
git-svn-id: http://svn.redmine.org/redmine/trunk@12499 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-07 15:55:03 +00:00
Jean-Philippe Lang
7bea176cdb Avoid lots of CustomField.find_by_id calls when displaying an issue history with custom fields (#15072).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12217 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-13 10:04:59 +00:00
Toshi MARUYAMA
15ab64488a remove trailing white-space from app/models/journal.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12121 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-05 11:14:30 +00:00
Jean-Philippe Lang
205eda8b33 Use AR callbacks instead of observers (removed in Rails4) for notifications.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12021 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-14 14:26:27 +00:00
Jean-Philippe Lang
0087d237f7 Don't notify users about relations that are not visible (#1005).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12015 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 10:32:48 +00:00
Jean-Philippe Lang
7509dda1ff Fixed that relations to issues that are not visible are displayed in the issue history (#1005).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12014 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 09:56:58 +00:00
Jean-Philippe Lang
628d05629b Role-based issue custom field visibility (#5037).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 09:20:11 +00:00
Jean-Philippe Lang
e396a0eebe Copyright for 2013 (#12788).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:29:31 +00:00
Jean-Philippe Lang
0e30724d66 Group events in the activity view (#12542).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10951 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-08 08:24:01 +00:00
Jean-Philippe Lang
c8b722456c Fixed that watchers receive notifications for private comments without permission (#12286).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10789 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-11-05 15:49:07 +00:00
Jean-Philippe Lang
0178b5a2fe Private issue notes (#1554).
Adds 2 new permissions for viewing/adding private comments to issues.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10547 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-10-03 21:36:19 +00:00
Jean-Philippe Lang
ba5a052c8c Copyright update.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9636 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-05-05 12:56:53 +00:00
Toshi MARUYAMA
d0d01d4e70 model: replace Rails2 "named_scope" to Rails3 "scope"
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9537 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-26 23:51:10 +00:00
Toshi MARUYAMA
f58c2f87c2 remove trailing white-spaces from app/models/journal.rb.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6855 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-08-31 07:04:22 +00:00