Commit Graph

129 Commits

Author SHA1 Message Date
Go MAEDA
ddde0ff47d Fix RuboCop offense Rails/ActiveRecordCallbacksOrder (#39889).
git-svn-id: https://svn.redmine.org/redmine/trunk@22879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 03:11:08 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
13aeb797cf Use ApplicationRecord instead of ActiveRecord::Base (#38975).
Patch by Minoru Maeda (@maeda-m).

git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-23 11:52:38 +00:00
Go MAEDA
70ef2a3db1 Fix RuboCop offense Performance/ConstantRegexp (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:26:31 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
f186e614ee Ruby 3.2: Changeset.normalize_comments raises Encoding::CompatibilityError if the string contains an invalid UTF-8 byte sequence (#38099, #38100).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22000 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-12-26 01:36:44 +00:00
Go MAEDA
ee1476f802 Fix RuboCop offense Rails/Pluck (#37248).
git-svn-id: https://svn.redmine.org/redmine/trunk@21928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-28 07:50:11 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
2a564a1376 DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. (#29914, #32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20880 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:32:23 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
818e813ef2 remove redundant 'return' from app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20676 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-19 17:32:49 +00:00
Toshi MARUYAMA
027af9e7b5 shorten long line of app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20611 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-10 13:34:16 +00:00
Toshi MARUYAMA
f34777ff57 remove spaces inside {} of app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20410 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-17 12:41:26 +00:00
Toshi MARUYAMA
f227d898d4 use "do end" instead of {} at ActiveRecord scope lambda of app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20340 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-12 12:31:04 +00:00
Go MAEDA
e48ff48820 Evaluate acts_as_activity_provider's scope lazily (#33664).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-17 02:02:50 +00:00
Toshi MARUYAMA
07fc4b1634 fix source indent of app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20084 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-26 15:02:10 +00:00
Toshi MARUYAMA
4261101ae5 fix source indent of app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20021 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-12 12:57:42 +00:00
Toshi MARUYAMA
87d7949892 add empty line after guard clause to app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-21 13:40:44 +00:00
Toshi MARUYAMA
3068b378f8 remove spaces inside {} of app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19924 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-21 13:40:11 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
777704249f Fix logging time via a commit message for project specific activities (#29838).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@19512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-11 13:33:22 +00:00
Go MAEDA
47a71c8011 Reverts r19478 (#32897).
git-svn-id: http://svn.redmine.org/redmine/trunk@19479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-30 05:27:52 +00:00
Go MAEDA
10bb12e09f Fix 'DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1.' (#32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-28 09:49:14 +00:00
Toshi MARUYAMA
7ba233469f code cleanup: rubocop: fix Layout/ElseAlignment in app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18633 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-09 02:16:59 +00:00
Toshi MARUYAMA
557f045e42 code cleanup: fix source code comment in r18607
git-svn-id: http://svn.redmine.org/redmine/trunk@18613 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:34:22 +00:00
Toshi MARUYAMA
af67ade563 code cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18607 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:26 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
1870a2e4fb Make sure that the journal is not created if issue is saved.
git-svn-id: http://svn.redmine.org/redmine/trunk@16599 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-03 08:10:20 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
1919f7233f find_referenced_issue_by_id fails with RangeError for large numbers (#21071).
git-svn-id: http://svn.redmine.org/redmine/trunk@14758 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-29 13:47:28 +00:00
Jean-Philippe Lang
78153cacdf Keywords in commit messages: journal entries are created even if nothing was changed (#19538).
git-svn-id: http://svn.redmine.org/redmine/trunk@14164 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-04-12 09:16:54 +00:00
Toshi MARUYAMA
86c6afb545 revert r13896 (#14534)
git-svn-id: http://svn.redmine.org/redmine/trunk@14136 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-03-20 07:26:34 +00:00
Jean-Philippe Lang
0bcd5be0a5 Use attribute writers instead of before_create callback to normalize comments and committer (#14534).
Unlike other adapters, SQLite raises Encoding::UndefinedConversionError before the callback that reencodes attributes is called.

git-svn-id: http://svn.redmine.org/redmine/trunk@13896 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-18 11:43:58 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
2fe806a4a4 Rewrites search engine to properly paginate results (#18631).
Instead of counting and retrieving results based on their timestamps, we now load all result ids then load the appropriate results by their ids. This also brings a 2x performance improvement as we search tokens in one of the 2 queries only.

git-svn-id: http://svn.redmine.org/redmine/trunk@13739 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-12 20:49:31 +00:00
Jean-Philippe Lang
c0f082ad02 Code cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@13508 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-25 09:35:17 +00:00
Toshi MARUYAMA
6f92548b38 remove unneeded "references" of joins
"references" is needed for includes, but not needed for joins.

git-svn-id: http://svn.redmine.org/redmine/trunk@13501 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-24 02:18:45 +00:00
Jean-Philippe Lang
116eb8bcc7 Fixed an SQL error with SQLServer (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13490 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 19:34:00 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Jean-Philippe Lang
a567546335 Don't link multiple changesets from the same commit multiple times (#17931).
git-svn-id: http://svn.redmine.org/redmine/trunk@13427 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-05 12:10:33 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00
Jean-Philippe Lang
5df064ed85 Fixed Changeset#text_tag for changeset with hash and repository identifier (#13544).
git-svn-id: http://svn.redmine.org/redmine/trunk@12660 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-12 09:19:47 +00:00
Toshi MARUYAMA
3ace0292c2 Rails4: replace deprecated find_by_id at Changeset class
git-svn-id: http://svn.redmine.org/redmine/trunk@12473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-29 13:49:09 +00:00
Toshi MARUYAMA
3109ed9320 code format cleanup app/models/changeset.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-24 05:40:32 +00:00
Jean-Philippe Lang
b6cb7aa8e3 Ability to define commit keywords per tracker (#7590).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12208 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-13 07:37:49 +00:00
Jean-Philippe Lang
7b1b605ae8 Don't update issues nor log time when importing old changesets (#4823).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12199 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-05 10:33:03 +00:00