Commit Graph

57 Commits

Author SHA1 Message Date
Go MAEDA
2fe36c4128 Fix RuboCop offense Style/RedundantInterpolationUnfreeze (#39887).
Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant.


git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-01 00:38:01 +00:00
Go MAEDA
b3d1deeece Fix RuboCop offense Layout/SpaceInsideParens, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22954 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 08:45:54 +00:00
Go MAEDA
6e21ae7209 Fix RuboCop offense Layout/SpaceAfterComma, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22953 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 08:36:05 +00:00
Go MAEDA
5b77092be4 Replace regular expression matches with String#start_with? / end_with? (#40010).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22605 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-11 11:27:25 +00:00
Marius Balteanu
1f7f1a2db7 Allow consecutive footnote references inTextile (#39884).
Patch by @hjust.

git-svn-id: https://svn.redmine.org/redmine/trunk@22546 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-22 01:44:02 +00:00
Go MAEDA
380444f085 Fix RuboCop offense Performance/StringIdentifierArgument (#39888).
git-svn-id: https://svn.redmine.org/redmine/trunk@22535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 09:23:05 +00:00
Go MAEDA
303abf0783 Use uri_with_link_safe_scheme? in Redcloth3 (#38807).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22303 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-09-18 07:55:40 +00:00
Go MAEDA
ba181c7328 HTML-escape the entire tag content of escaped HTML tags in textile (#38807).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22302 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-09-18 07:45:03 +00:00
Go MAEDA
0befc3a23c Fix RuboCop offense Style/RedundantSelfAssignmentBranch (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22263 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 01:37:24 +00:00
Go MAEDA
e0e751f5bc Fix RuboCop offense Style/RedundantRegexpArgument (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22262 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 00:39:58 +00:00
Go MAEDA
95f3b5cf38 Revert the change made in error in r22197 (#38435).
git-svn-id: https://svn.redmine.org/redmine/trunk@22198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-04-16 08:31:50 +00:00
Go MAEDA
0f6507a607 Change the notation of "contains any of" filter operator to "*~" (#38435).
git-svn-id: https://svn.redmine.org/redmine/trunk@22197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-04-16 08:02:30 +00:00
Go MAEDA
e010d90207 Fix RuboCop offense Performance/RedundantSplitRegexpArgument (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22033 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:33:32 +00:00
Go MAEDA
62a930cc65 Fix RuboCop offense Performance/RedundantMatch (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22032 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:31:57 +00:00
Go MAEDA
70ef2a3db1 Fix RuboCop offense Performance/ConstantRegexp (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:26:31 +00:00
Go MAEDA
1d9f5c6742 Escape tags that start with pre (#37767).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21902 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-17 13:35:20 +00:00
Marius Balteanu
ba635eace9 Escape blockquote citation in textile formatting (#37751).
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21894 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-04 18:58:37 +00:00
Go MAEDA
b51d40fe38 Comments for Textile text formatting (#20511).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-17 03:55:24 +00:00
Go MAEDA
f5ac84a516 Inline image in Textile is not displayed if the image URL contains ampersands (#35441).
Contributed by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21101 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-28 08:25:15 +00:00
Go MAEDA
78dfef0978 Replace gsub with tr, delete, or squeeze (#34161).
git-svn-id: http://svn.redmine.org/redmine/trunk@20176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-24 06:46:50 +00:00
Go MAEDA
fdba424d77 Use match? instead of =~ when MatchData is not used (#34150).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20168 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-23 00:13:38 +00:00
Toshi MARUYAMA
a830a23d7b fix source indent of lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19850 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-03 11:45:37 +00:00
Jean-Philippe Lang
895fc12d56 XSS vulnerabilities in textile links (#32934).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19672 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 14:41:33 +00:00
Jean-Philippe Lang
d257990868 Reverts r19489 (#32934).
git-svn-id: http://svn.redmine.org/redmine/trunk@19671 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 14:35:44 +00:00
Go MAEDA
0ba13a0bd3 Fix a RuboCop offence Style/NegatedWhile (#32971).
git-svn-id: http://svn.redmine.org/redmine/trunk@19542 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-29 11:18:18 +00:00
Go MAEDA
2253032ebc Newline between list items break a list (#32971).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19536 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-29 04:21:53 +00:00
Jean-Philippe Lang
e9d5b0b8dc White list protocols allowed for Textile links (#32934).
git-svn-id: http://svn.redmine.org/redmine/trunk@19489 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 10:19:16 +00:00
Toshi MARUYAMA
9908565bde cleanup: rubocop: fix Layout/AlignArguments in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18925 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-06 12:03:47 +00:00
Toshi MARUYAMA
adff3bcb7e code cleanup: rubocop: fix Layout/CommentIndentation in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18773 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 12:25:46 +00:00
Toshi MARUYAMA
57a66e950c code cleanup: rubocop: fix Layout/EmptyLines in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18742 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 07:27:46 +00:00
Toshi MARUYAMA
e3397db933 code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18738 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 07:26:59 +00:00
Toshi MARUYAMA
30964255f1 code cleanup: rubocop: fix Style/UnlessElse in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18737 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 07:26:45 +00:00
Toshi MARUYAMA
18442d568a code layout clean up lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18721 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 16:40:08 +00:00
Toshi MARUYAMA
8bac080b8c code cleanup: rubocop: fix Style/CharacterLiteral and Style/ParenthesesAroundCondition in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18720 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 16:39:55 +00:00
Toshi MARUYAMA
e8b06af277 code cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18696 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-16 14:36:55 +00:00
Toshi MARUYAMA
3f691ee4c2 code cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18690 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-16 13:00:41 +00:00
Toshi MARUYAMA
38bf3f5024 code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 17:25:31 +00:00
Toshi MARUYAMA
d7d85cd85f code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18684 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 17:25:19 +00:00
Toshi MARUYAMA
c82054a651 code cleanup: rubocop: fix Style/IfWithSemicolon in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18680 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 11:48:37 +00:00
Toshi MARUYAMA
695a03b3eb code cleanup: rubocop: fix Layout/IndentAssignment in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18679 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 11:48:25 +00:00
Toshi MARUYAMA
76be6f712f code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18678 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 11:48:13 +00:00
Go MAEDA
31e8e736f3 Code cleanup: RuboCop: Layout/TrailingBlankLines
git-svn-id: http://svn.redmine.org/redmine/trunk@18367 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-14 03:02:20 +00:00
Jean-Philippe Lang
29bd7edca4 Fix html encoding (#31520).
git-svn-id: http://svn.redmine.org/redmine/trunk@18247 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-10 11:47:24 +00:00
Go MAEDA
9eafc3e9a2 Remove trailing whitespaces from lib (#31506).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-06 14:50:14 +00:00
Go MAEDA
30e341db69 Support frozen_string_literal in lib/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 16:36:34 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
019b640d81 Reverts r17891 (#30099).
git-svn-id: http://svn.redmine.org/redmine/trunk@17939 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-10 23:37:57 +00:00
Go MAEDA
193b02567b URLs end with "-" are rendered incorrectly in Textile (#30259).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-03 15:18:04 +00:00
Go MAEDA
ef9c879718 Multiple blank lines in pre tags are not preserved in Textile (#30099).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@17891 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-20 10:31:30 +00:00
Go MAEDA
7fbcb8c908 Tags start with 'pre' are handled as 'pre' tag in Textile (#8395).
Patch by Takenori TAKAKI and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17636 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-26 04:40:09 +00:00