Commit Graph

117 Commits

Author SHA1 Message Date
Go MAEDA
93645a279e Use anonymous block forwarding introduced in Ruby 3.1 (#38585).
git-svn-id: https://svn.redmine.org/redmine/trunk@22973 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-21 00:46:15 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Go MAEDA
ed0644d151 Fix ScmData.binary? method not to consider UTF-8 text as binary (#40020).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22664 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-30 01:41:38 +00:00
Go MAEDA
5b77092be4 Replace regular expression matches with String#start_with? / end_with? (#40010).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22605 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-11 11:27:25 +00:00
Marius Balteanu
b7a190399f Remove deprecated methods in Repository and AbstractAdapter (#39558).
Patch by Go MAEDA.

git-svn-id: https://svn.redmine.org/redmine/trunk@22457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-18 12:58:19 +00:00
Go MAEDA
d97beec1d4 Add "View annotation prior to this change" button in the annotate view of Git (#35432).
Patch by Takenori TAKAKI.


git-svn-id: https://svn.redmine.org/redmine/trunk@22217 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-04-30 04:00:57 +00:00
Go MAEDA
18275bd028 Fix RuboCop offense Rails/Presence in lib/redmine/scm/adapters/abstract_adapter.rb (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22150 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-24 23:17:35 +00:00
Go MAEDA
fe71cb5bbe Fix RuboCop offense Lint/MissingSuper (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22147 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-24 09:34:40 +00:00
Go MAEDA
0b6f4c6811 Ruby 2.7: Fix RuboCop offense Performance/MapCompact (#38134).
git-svn-id: https://svn.redmine.org/redmine/trunk@22055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-17 01:38:27 +00:00
Go MAEDA
3942177f49 Fix RuboCop offense Performance/BlockGivenWithExplicitBlock (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22027 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:20:52 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
45fafc7e44 Fix RuboCop offense Layout/LineLength due to r21785 (#37586).
git-svn-id: https://svn.redmine.org/redmine/trunk@21791 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-01 04:53:28 +00:00
Go MAEDA
c7c24cb6e2 Typo in method names: s/trailling/trailing/ (#37586).
git-svn-id: https://svn.redmine.org/redmine/trunk@21785 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-08-28 07:32:24 +00:00
Go MAEDA
80b7a83940 Use start_with? or end_with? to check the first or last character of a string (#37591).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21774 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-08-24 13:45:20 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
b6a26a60f3 Fixes for Performance/StringIdentifierArgument introduced in RuboCop Performance 1.13.0 (#35142).
git-svn-id: http://svn.redmine.org/redmine/trunk@21330 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-29 06:12:27 +00:00
Go MAEDA
4db7397d2a Use File.exist? instead of deprecated File.exists? (#36358).
git-svn-id: http://svn.redmine.org/redmine/trunk@21327 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-27 03:20:31 +00:00
Go MAEDA
1cf427ee63 Stricter validation of given revisions of repositories (#35085).
Patch by Holger Just.


git-svn-id: http://svn.redmine.org/redmine/trunk@20962 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-23 00:46:45 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
8ddbbcf4a6 fix source indent of lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20213 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-27 15:19:05 +00:00
Toshi MARUYAMA
da3b237706 remove space inside parentheses from lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20100 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-02 12:58:35 +00:00
Toshi MARUYAMA
76c38c4abf use "do end" instead of {} at lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19970 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-09 15:57:28 +00:00
Toshi MARUYAMA
b5680f4456 add space after comma to lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19961 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-09 15:56:15 +00:00
Toshi MARUYAMA
b8057a88ec add empty line after guard clause to lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19959 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-09 15:55:59 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
aa352d57a4 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19117 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:05:52 +00:00
Toshi MARUYAMA
319eeae14d code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18820 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:41:09 +00:00
Toshi MARUYAMA
7738078717 code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18777 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:33:10 +00:00
Toshi MARUYAMA
0ea9e05b68 fix stderr_log_file and strip_credential of Redmine::Scm::Adapters::AbstractAdapter are not private
git-svn-id: http://svn.redmine.org/redmine/trunk@18757 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 11:15:30 +00:00
Toshi MARUYAMA
118fff34aa rubocop: fix Style/YodaCondition of lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18351 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-04 17:05:24 +00:00
Toshi MARUYAMA
00d3fa02e2 rubocop: fix Layout/AccessModifierIndentation of scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18331 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-07-29 05:38:30 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
b0e17e8199 Don't rescue Exception class (#31387).
Patch by Go MAEDA and Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 06:50:25 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
30e341db69 Support frozen_string_literal in lib/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 16:36:34 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
bff0fbce8b Remove RDoc tags (#28943).
Patch by Sho HASHIMOTO.


git-svn-id: http://svn.redmine.org/redmine/trunk@17370 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-08 00:55:41 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
5744bfc2c6 Removes duplicate shell_quote method (#26149).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16667 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-17 07:42:54 +00:00
Toshi MARUYAMA
06babbec7e remove is_binary_data? from String (#25563)
git-svn-id: http://svn.redmine.org/redmine/trunk@16644 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-10 04:29:15 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
9915962356 Make sure that #scm_iconv returns a string with the target encoding (#14534).
filechanges.find_by_revision_and_path fails with SQLite if arguments are not UTF-8 encoded.

git-svn-id: http://svn.redmine.org/redmine/trunk@13902 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-18 16:16:23 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Toshi MARUYAMA
7c56ed6004 fix source indent of Redmine::Scm::Adapters::AbstractAdapter#without_trailling_slash
git-svn-id: http://svn.redmine.org/redmine/trunk@12741 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-31 09:38:43 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00
Jean-Philippe Lang
a657a12450 Don't load redcarpet with JRuby.
git-svn-id: http://svn.redmine.org/redmine/trunk@12453 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-23 17:07:51 +00:00
Jean-Philippe Lang
a22242ed20 Fixed uninitialized constant Redmine::Scm::Adapters::CommandFailed error when reloading in development mode.
git-svn-id: http://svn.redmine.org/redmine/trunk@12273 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-11-11 22:02:21 +00:00
Jean-Philippe Lang
633e4a00e6 Check that the SCM log file is writable before using it (#13541).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11698 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-04-03 20:01:41 +00:00
Jean-Philippe Lang
d8769cb27c Log SCM stderr when log level is set to debug only (#13541).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11680 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-22 07:50:28 +00:00