Commit Graph

431 Commits

Author SHA1 Message Date
Go MAEDA
d480067439 Optimize IssuesController#show by skipping time tracking queries when disabled (#42144).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23463 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-25 08:18:26 +00:00
Go MAEDA
9fccf787a4 Remove navigation parameters from issue detail URLs after updates (#42073).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23433 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-07 07:18:32 +00:00
Go MAEDA
6c8b04d6d5 Add configurable setting for copying attachments when copying an issue (#36197).
Patch by Yuichi HARADA (user:yui.har).


git-svn-id: https://svn.redmine.org/redmine/trunk@22926 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-14 01:49:53 +00:00
Go MAEDA
47d7dd0187 Fix RuboCop offense Style/CollectionCompact (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22921 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-11 09:35:32 +00:00
Go MAEDA
b803bddb1f Fix "ArgumentError: Invalid response name: unprocessable_entity" with Rack 3.1.0+ in assert_response (#39889).
Rack 3.1.0 changed the symbol for HTTP status code 422 from `:unprocessable_entity` to `:unprocessable_content`.
Due to the change, `assert_response(:unprocessable_entity, ...)` raises ArgumentError with Rack 3.1.0+.

This fix is a follow-up to r22837.


git-svn-id: https://svn.redmine.org/redmine/trunk@22876 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-12 16:09:37 +00:00
Go MAEDA
c19176a5c4 Reduce an extra SQL query in IssuesController#retrieve_default_query (#40775).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 09:37:34 +00:00
Go MAEDA
a9518e28b8 Fix RuboCop offense Rails/HttpStatus (#39889).
git-svn-id: https://svn.redmine.org/redmine/trunk@22837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-18 05:56:55 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Go MAEDA
63391766a9 Remove unnecessary use of instance variables in CSV and Atom response handlers (#32985).
Contributed by Ko Nagase (@sanak).


git-svn-id: https://svn.redmine.org/redmine/trunk@22622 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-24 02:49:38 +00:00
Go MAEDA
06f9567415 Optimize loading of journals, relations, and allowed_statuses in IssuesController#show for API requests (#39993).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22582 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-01 11:28:48 +00:00
Go MAEDA
63188014b0 Replace hardcoded issues count check with limit variable in IssuesController#retrieve_previous_and_next_issue_ids (#39380).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22415 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-10-31 13:02:09 +00:00
Go MAEDA
555acea780 Check if the user has the permission to add notes or edit an issue when adding an issue attachments (#38297).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22122 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-02 04:32:34 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
f8033a069f Use query name as the file name when exporting queries (#16207).
Patch by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21773 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-08-24 13:21:50 +00:00
Go MAEDA
6ee209843e Don't load changesets when IssuesController#show processes API requests without "include=changesets" (#37528).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-07-31 13:00:25 +00:00
Marius Balteanu
1d32a44afa Only check for @set_filter@ param when retriving the default query (#7360, 35795, #36389).
git-svn-id: http://svn.redmine.org/redmine/trunk@21481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-20 21:49:57 +00:00
Marius Balteanu
f286a6044b Deprecate and rename rss_* methods to atom_* methods (#15118).
Patch by Mischa The Evil and Marius BĂLTEANU


git-svn-id: http://svn.redmine.org/redmine/trunk@21467 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-19 09:56:46 +00:00
Go MAEDA
a5785c8ee6 Display source project for cross-project associated revisions for issues (#5242).
Contributed by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@21368 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-18 15:03:29 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Marius Balteanu
e9b94a19de Adds button to "Create and follow" when adding a subtask from the parent issue. Now the user have the following options:
* Create: redirects the user to the parent task (existing behaviour)
* Create and follow: redirects the user to the newly created subtask (new behaviour)
* Create and add another: redirects the user to new subtask (existing behaviour).

(#29076).

git-svn-id: http://svn.redmine.org/redmine/trunk@21269 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-06 09:11:58 +00:00
Marius Balteanu
7e2f3352db Fix that updating an issue from context menu to a none value do not set the field to blank (#33521).
Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@21139 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-05 23:41:01 +00:00
Go MAEDA
7f965286ed Default issue query (#7360).
Patch by Katsuya HIDAKA (the author of https://github.com/hidakatsuya/redmine_default_custom_query), Takenori TAKAKI, Olivier Chabert, and Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@21061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-06 06:01:50 +00:00
Go MAEDA
e2c08c7b36 Add total estimated hours, spent hours, total spent hours for issues to issue list API (#34857).
Patch by Felix Schäfer and Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@21051 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-06-27 07:18:58 +00:00
Go MAEDA
66fc9f463d Gracefully handle invalid query parameters for custom fields (#35312).
Patch by Holger Just.


git-svn-id: http://svn.redmine.org/redmine/trunk@21012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-28 03:58:01 +00:00
Go MAEDA
9055e5dfe5 Include new statuses allowed by workflow in Issues REST API (#24976).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20951 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-19 09:04:24 +00:00
Go MAEDA
e74cc0b923 Fix detach attachments when a conflict occurs (#29914, #32923).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20894 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 15:25:40 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
7ad9065c01 use "do end" instead of {} at IssuesController
git-svn-id: http://svn.redmine.org/redmine/trunk@20310 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-09 13:24:14 +00:00
Go MAEDA
b46953247d Replace Hash#merge! with Hash#[]= (#34160).
git-svn-id: http://svn.redmine.org/redmine/trunk@20175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-24 05:33:23 +00:00
Toshi MARUYAMA
69e0e04676 fix source indent of IssuesController#destroy
git-svn-id: http://svn.redmine.org/redmine/trunk@19916 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-19 14:05:53 +00:00
Jean-Philippe Lang
31c8e71d8e Set time entry author in controller (#32774).
git-svn-id: http://svn.redmine.org/redmine/trunk@19677 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 19:24:32 +00:00
Go MAEDA
6e781f6479 Fix that "Successful deletion" notice is not displayed after deleting some types of content (#33116).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19641 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-04 00:43:28 +00:00
Go MAEDA
af36d450e4 Reverts r19569 (#33071).
404 error after deleting an attachment.


git-svn-id: http://svn.redmine.org/redmine/trunk@19579 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-14 03:49:44 +00:00
Go MAEDA
463e8163fc Require sudo mode for actions to delete contents (#33071).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19569 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-10 03:26:23 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
677dfdc883 replace multi line block "{}" to "do end" in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19319 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:31:04 +00:00
Toshi MARUYAMA
e27dc4d547 cleanup: rubocop: fix Layout/SpaceInsideBlockBraces in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19318 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:30:53 +00:00
Toshi MARUYAMA
8ee394e97a cleanup: rubocop: fix Layout/SpaceInsideHashLiteralBraces in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19317 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:30:42 +00:00
Toshi MARUYAMA
4a9d5faaf1 cleanup: rubocop: fix Layout/EmptyLineAfterGuardClause in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19178 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 16:50:04 +00:00
Toshi MARUYAMA
e82fcb3fc5 cleanup: rubocop: fix Layout/SpaceAfterComma in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19177 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 16:49:53 +00:00
Toshi MARUYAMA
f50d50f7b8 code layout clean up app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 16:49:43 +00:00
Toshi MARUYAMA
5b1bd277f8 code layout clean up IssuesController#build_new_issue_from_params
git-svn-id: http://svn.redmine.org/redmine/trunk@19153 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:25:36 +00:00
Toshi MARUYAMA
3b71b71710 code layout clean up IssuesController#update_issue_from_params
git-svn-id: http://svn.redmine.org/redmine/trunk@19152 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:25:25 +00:00
Toshi MARUYAMA
b5574321f9 code layout clean up IssuesController#bulk_edit
git-svn-id: http://svn.redmine.org/redmine/trunk@19151 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:25:14 +00:00
Toshi MARUYAMA
e8343c1f9d code layout clean up IssuesController#create
git-svn-id: http://svn.redmine.org/redmine/trunk@19150 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:25:03 +00:00
Toshi MARUYAMA
b63b388d8a code layout clean up IssuesController#show
git-svn-id: http://svn.redmine.org/redmine/trunk@19149 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:24:53 +00:00
Toshi MARUYAMA
32dd182e25 code layout clean up IssuesController#index
git-svn-id: http://svn.redmine.org/redmine/trunk@19148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:24:42 +00:00
Toshi MARUYAMA
bee8063f46 code layout clean up IssuesController#update
git-svn-id: http://svn.redmine.org/redmine/trunk@19146 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:24:21 +00:00
Toshi MARUYAMA
c611a585ad cleanup: rubocop: fix Layout/AlignArguments in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18940 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 01:37:14 +00:00
Toshi MARUYAMA
f891a28152 code layout clean up app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18718 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 16:39:31 +00:00