Commit Graph

2129 Commits

Author SHA1 Message Date
Go MAEDA
f7bb9f93a4 Show images and thumbnails in their natural orientation (#28616).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17420 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-27 08:04:28 +00:00
Jean-Philippe Lang
d8a2024715 Dangerous query method deprecation warnings (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@17411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-23 05:19:07 +00:00
Go MAEDA
157a291b66 Redmine::VERSION::revision should take subversion_command_setting into account (#28920).
Patch by Yuichi Harada.


git-svn-id: http://svn.redmine.org/redmine/trunk@17407 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-22 05:30:05 +00:00
Jean-Philippe Lang
f748296121 Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address (#27968).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17394 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-17 06:00:21 +00:00
Jean-Philippe Lang
b1b89ff0ac "attachment:filename" link syntax would not work if the file name contains "@" (#26507).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17393 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-17 05:57:39 +00:00
Jean-Philippe Lang
270b6c4d7e User link syntax (user:login) doesn't work for logins consisting of an email adress (#26443).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17392 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-17 05:45:17 +00:00
Jean-Philippe Lang
794a2a0180 Enable and add underline button to the toolbar for Markdown formatting (#28169).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17385 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-16 10:56:52 +00:00
Jean-Philippe Lang
6a2867a701 Updates for 3.4.6 release.
git-svn-id: http://svn.redmine.org/redmine/trunk@17377 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-10 06:14:03 +00:00
Go MAEDA
bff0fbce8b Remove RDoc tags (#28943).
Patch by Sho HASHIMOTO.


git-svn-id: http://svn.redmine.org/redmine/trunk@17370 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-08 00:55:41 +00:00
Go MAEDA
db8afc99e1 Support of default ActiveRecord I18n scopes in LabelledFormBuilder (#26618).
Patch by Dmitry Lisichkin.


git-svn-id: http://svn.redmine.org/redmine/trunk@17365 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-04 02:26:48 +00:00
Go MAEDA
795bdb9ee5 Fix: Irrelevant permission is required to access some tabs in project settings page (#28693).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17359 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-03 00:48:11 +00:00
Go MAEDA
eafe8a9f9e Mercurial 4.6 compatibility (#28725).
Patch by Marc Schlaich and Frédéric Fondement.


git-svn-id: http://svn.redmine.org/redmine/trunk@17351 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-28 09:40:15 +00:00
Go MAEDA
37d1fcf8a4 Adds previews for audio / video attachments (#27336).
Patch by Jens Kraemer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17340 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-17 13:09:43 +00:00
Go MAEDA
ca2875fab2 Allow switching the encoding to UTF-8 when exporting to CSV (#26279).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17328 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-07 01:13:12 +00:00
Go MAEDA
c9a216b816 Fix: redmine_plugin_controller generates camelcase filename (#28668).
Patch by Toru Takahashi.


git-svn-id: http://svn.redmine.org/redmine/trunk@17325 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-05 02:55:33 +00:00
Go MAEDA
00b85dc8d9 Fix: Syntax highlighter does not work if language name is single-quoted (#28469).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17322 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-02 02:27:10 +00:00
Go MAEDA
b178150761 Show renames in diff preview (#28295).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-27 09:14:36 +00:00
Go MAEDA
8b0bfbbc8b Gantt bars with start date and end date on the same day don't become red by overdue (#13521).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17294 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-09 13:00:41 +00:00
Jean-Philippe Lang
784b9f4aca Rails 5: "Page not found" error when accessing a page of a plugin in production mode (#26636).
Patch by Akiko Takano.

git-svn-id: http://svn.redmine.org/redmine/trunk@17293 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-08 13:45:27 +00:00
Jean-Philippe Lang
56d4dc1973 Updates for 3.4.5 release.
git-svn-id: http://svn.redmine.org/redmine/trunk@17286 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-07 12:25:45 +00:00
Jean-Philippe Lang
040f31d867 Markdown pre-block could derive incorrect wiki sections (#25299).
Patch by Kiichi Ozaki.

git-svn-id: http://svn.redmine.org/redmine/trunk@17266 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-07 07:34:43 +00:00
Go MAEDA
241e4cbb68 Enable lax_spacing for markdown formatting (#28119).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-16 05:01:14 +00:00
Go MAEDA
c1f92c7f06 Fix: "project_from_subbaddress" option is not listed in the help of "rake redmine:email:receive_imap" (#28026).
Patch by Go Maeda.


git-svn-id: http://svn.redmine.org/redmine/trunk@17185 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-24 12:10:19 +00:00
Go MAEDA
e4142a8338 Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textile (#26552).
Patch by Michael Gerz and Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17173 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-11 01:32:18 +00:00
Jean-Philippe Lang
054f3bb424 Updates for 3.4.4 release.
git-svn-id: http://svn.redmine.org/redmine/trunk@17162 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 17:58:39 +00:00
Jean-Philippe Lang
ce066b0567 Removes 'unloadable' from plugin templates (#20513).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17160 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 17:53:50 +00:00
Go MAEDA
89de01076a Replace Minitest.rake_run with Rails::TestUnit::Runner.rake_run for compatibility with Rails 5.1.4 (#27871).
Patch by Tatsuya Saito.


git-svn-id: http://svn.redmine.org/redmine/trunk@17139 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-01 10:28:56 +00:00
Go MAEDA
c35433ad01 Links for custom field value don't have "external" class (#27024).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-01 06:18:01 +00:00
Go MAEDA
14e0a6bdba Use reverse_each instead of reverse.each (#27671).
Patch by Timur Tarasenko.


git-svn-id: http://svn.redmine.org/redmine/trunk@17137 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-31 01:34:39 +00:00
Toshi MARUYAMA
a1c2eb61df replace plugin generator USAGE "script/rails" which are removed by r16868
git-svn-id: http://svn.redmine.org/redmine/trunk@17132 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-27 16:59:13 +00:00
Toshi MARUYAMA
9d797400ea mercurial: work around faulty parsing of early command options (#27516)
Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:47 +00:00
Toshi MARUYAMA
58ed865513 mercurial: separate command options and positional arguments with "--" (#27516)
We don't have much problems here thanks to hgtarget(path) and CGI.escape(),
which prepends a repository path and encodes "=" character respectively, but
it's better to not rely on the side effect of these functions.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:35 +00:00
Toshi MARUYAMA
ca87bf766c mercurial: reject malicious command argument (#27516)
We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.

https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314

This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.

This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:23 +00:00
Go MAEDA
d6d2d23365 Fix: Round floats to 2 digits when rendering an issue list to PDF (#12510).
Patch by Holger Just and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 14:25:35 +00:00
Jean-Philippe Lang
62d6dfe1cc Fixes visibility checks for version.fixed_issues in Gantt (#27676).
Like the version page - the Gantt chart featured a "percent done" info
for each version, which wasn't properly limited to visible issues.

Patch by Gregor Schmidt.

git-svn-id: http://svn.redmine.org/redmine/trunk@17053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 19:38:44 +00:00
Go MAEDA
9ae7bc8152 Make robust Redmine::Helpers::URL#uri_with_safe_scheme? (#27114)
Patch by okkez.


git-svn-id: http://svn.redmine.org/redmine/trunk@17035 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-26 03:44:37 +00:00
Go MAEDA
a92b92e501 Add right-click context menu to gantt bars (#10485).
Contributed by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17031 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-25 16:31:50 +00:00
Go MAEDA
fc93f14d64 Add right-click context menu to gantt subjects (#10485).
Contributed by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17030 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-25 16:30:23 +00:00
Go MAEDA
4b30e7a90e Fix: Gravatar icon is misaligned in gantt (#26410).
Contributed by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17027 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-25 15:29:52 +00:00
Jean-Philippe Lang
2fd2c1a31f Updates for 3.4.3 release.
git-svn-id: http://svn.redmine.org/redmine/trunk@17003 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-10-15 19:46:27 +00:00
Toshi MARUYAMA
6455e0431f fix "schema_migrations_table_name is deprecated" warning during redmine:plugins:migrate (#26615)
Contributed by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16962 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-31 15:57:43 +00:00
Toshi MARUYAMA
432cf42b47 git: remove "--no-color" option from "git --version" for git 2.14 compatibility (#26645)
git-svn-id: http://svn.redmine.org/redmine/trunk@16948 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-08 05:10:32 +00:00
Jean-Philippe Lang
fe3d4d7e0c Set migration version in the plugin migration template (#26610).
git-svn-id: http://svn.redmine.org/redmine/trunk@16945 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-02 16:52:46 +00:00
Toshi MARUYAMA
7ab8bee653 remove empty lines with trailing white spaces at lib/redmine/search.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16941 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-01 04:46:00 +00:00
Toshi MARUYAMA
63217014ff remove trailing white spaces from lib/redmine/subclass_factory.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16937 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-31 06:21:35 +00:00
Toshi MARUYAMA
a9aac23343 remove trailing white space from lib/redmine/themes.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16935 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-31 04:30:42 +00:00
Jean-Philippe Lang
3a3ecb3dce Removed unused date calculations.
git-svn-id: http://svn.redmine.org/redmine/trunk@16934 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 21:22:57 +00:00
Jean-Philippe Lang
fac02579cb Removes test:ui rake task replaced by rails test:system.
git-svn-id: http://svn.redmine.org/redmine/trunk@16929 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 17:19:20 +00:00
Jean-Philippe Lang
e930ee8e98 Adds a checkbox to set a page as the wiki start page (#26579).
git-svn-id: http://svn.redmine.org/redmine/trunk@16915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 07:38:48 +00:00
Jean-Philippe Lang
71423af0b2 Get rid of acts_as_versioned.
WikiContent::Version becomes WikiContentVersion.

git-svn-id: http://svn.redmine.org/redmine/trunk@16889 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-26 16:41:06 +00:00