Commit Graph

2646 Commits

Author SHA1 Message Date
Toshi MARUYAMA
6b5991b34e use "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids
WikiPage#deleted_attachment_ids is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18617 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:45:22 +00:00
Toshi MARUYAMA
1c0b6075ee use "attr_writer" instead of "attr_accessor" for QueryColumn#sortable
QueryColumn#sortable is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18616 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:45:11 +00:00
Toshi MARUYAMA
21cc761b53 use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value
CustomFieldValue#value= is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:44:54 +00:00
Toshi MARUYAMA
557f045e42 code cleanup: fix source code comment in r18607
git-svn-id: http://svn.redmine.org/redmine/trunk@18613 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:34:22 +00:00
Toshi MARUYAMA
af67ade563 code cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18607 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:26 +00:00
Go MAEDA
16c580a2f8 Option to send email notification on "Target version updated" (#17840).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 09:46:05 +00:00
Go MAEDA
7763902629 Use Redmine::MimeType.of instead of regexp to check if the attachment is Textile (#29752).
git-svn-id: http://svn.redmine.org/redmine/trunk@18586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 09:30:43 +00:00
Go MAEDA
3ce678510e Render Textile and Markdown attachments on the preview page (#29752).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 00:09:28 +00:00
Toshi MARUYAMA
c343588fa7 fix Watcher#prune_single_user is not private
git-svn-id: http://svn.redmine.org/redmine/trunk@18577 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-01 05:07:16 +00:00
Go MAEDA
b0f1175e3e Add support for "start with" and "end with" operators to "Files" filter (#31879).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18570 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 13:15:45 +00:00
Toshi MARUYAMA
0779cd6e53 code cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours method
git-svn-id: http://svn.redmine.org/redmine/trunk@18567 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:48 +00:00
Toshi MARUYAMA
91d7916f38 code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method
git-svn-id: http://svn.redmine.org/redmine/trunk@18566 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:36 +00:00
Toshi MARUYAMA
edc94dabb3 code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition method
git-svn-id: http://svn.redmine.org/redmine/trunk@18565 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:26 +00:00
Toshi MARUYAMA
ca411ddca7 code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18559 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 09:00:06 +00:00
Toshi MARUYAMA
a8c1fc77ef code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/attachment.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18558 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:54 +00:00
Toshi MARUYAMA
ad110b965f code cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18556 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:26 +00:00
Toshi MARUYAMA
612221d36a svn propdel svn:executable app/models/mail_handler.rb
It was added by r16609 accidentally.



git-svn-id: http://svn.redmine.org/redmine/trunk@18539 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-26 02:38:50 +00:00
Go MAEDA
b3baa5c1ce "starts with" and "ends with" filter operators for string values (#31879).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 16:24:08 +00:00
Toshi MARUYAMA
591d0eae79 code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18523 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:56:51 +00:00
Toshi MARUYAMA
2829ddcc33 code cleanup: rubocop: fix Layout/BlockEndNewline in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18517 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:54:53 +00:00
Toshi MARUYAMA
4c9bef2ace code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/repository/bazaar.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:13:46 +00:00
Toshi MARUYAMA
fb221e8069 code cleanup: rubocop: fix Layout/SpaceInsideRangeLiteral in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18507 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 02:34:43 +00:00
Toshi MARUYAMA
fd51a4fe58 code cleanup: rubocop: fix Style/CommentedKeyword in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 17:54:54 +00:00
Toshi MARUYAMA
d6701ab40f remove "attr_reader :current_journal" from Issue class
Issue#current_journal is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:48 +00:00
Toshi MARUYAMA
3be589df24 use "attr_writer" instead of "attr_accessor" for Issue#deleted_attachment_ids
Issue#deleted_attachment_ids is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:37 +00:00
Toshi MARUYAMA
4074ca0771 code clean up app/models/repository.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 13:58:41 +00:00
Toshi MARUYAMA
7fb47e4b5e code cleanup: rubocop: fix Layout/LeadingCommentSpace in app/models/repository.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18485 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 13:58:30 +00:00
Go MAEDA
75df6ead3b Log info messages when MailHandler ignored a reply to a nonexistent issue, journal, or message (#31946).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 09:38:39 +00:00
Go MAEDA
59968110a3 Add additional mail headers for issue tracker (#31910).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18459 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-12 21:52:21 +00:00
Go MAEDA
35e6a532f5 Force passwords to contain specified character classes (#4221).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-29 01:35:09 +00:00
Go MAEDA
fe0a89d7d1 CodeCleanup: RuboCop: Fix Style/RaiseArgs in app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18405 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 16:08:44 +00:00
Go MAEDA
e9d74c01d0 Improve MailHandler logging for unauthorized attempts (#31899).
Patch by Gustavo Regal.


git-svn-id: http://svn.redmine.org/redmine/trunk@18404 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 15:42:05 +00:00
Go MAEDA
c37d1b43a4 Reject version custom field values not visible for the user (#31954, #23997).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18402 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 10:44:39 +00:00
Go MAEDA
ce831ae5e4 Reject project custom field values not visible for the user (#31954, #31925).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18401 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 10:20:09 +00:00
Go MAEDA
26774d09e9 Code cleanup: RuboCop: Fix Style/UnneededCondition in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18397 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-26 07:16:55 +00:00
Go MAEDA
47dd2083f7 Reject setting RFC non-compliant emission email addresses (#31154).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18396 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-26 04:18:18 +00:00
Go MAEDA
331dcfbadc Code cleanup: RuboCop: Fix Style/RedundantReturn in app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18394 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 16:15:36 +00:00
Go MAEDA
0553e8375c Code cleanup: RuboCop: Fix Lint/UnneededRequireStatement in app/models/wiki_page.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18392 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 05:04:48 +00:00
Go MAEDA
959b55779f Fix hard-coded string "no subject" in app/models/mail_handler.rb (#5820).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 00:09:10 +00:00
Go MAEDA
22165fd071 Per role visibility settings for version custom fields (#23997).
Patch by Jens Krämer and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18386 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-24 08:50:17 +00:00
Go MAEDA
024f2aef6c Code cleanup: RuboCop: Fix Style/IdenticalConditionalBranches in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18380 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-20 03:27:15 +00:00
Go MAEDA
3495cba92b Per role visibility settings for project custom fields (#31925).
Patch by Jens Krämer and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18379 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-20 01:44:44 +00:00
Go MAEDA
0d4ed12388 Code cleanup: RuboCop: Rails/ActiveRecordAliases
update_attributes is deprecated in Rails 6.0 and will be removed in Rails 6.1 (#29914).


git-svn-id: http://svn.redmine.org/redmine/trunk@18375 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-17 08:14:36 +00:00
Go MAEDA
31e8e736f3 Code cleanup: RuboCop: Layout/TrailingBlankLines
git-svn-id: http://svn.redmine.org/redmine/trunk@18367 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-14 03:02:20 +00:00
Go MAEDA
3c91a3d5b2 Per role visibility settings for spent time custom fields (#31859).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18358 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-09 09:31:16 +00:00
Go MAEDA
8a9123de04 Limit total_estimated_hours to visible issues (#31778).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@18356 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-07 04:44:19 +00:00
Jean-Philippe Lang
3ddab944d5 Increase maximum size for role name (#27625).
Patch by Aleksandar Pavic.

git-svn-id: http://svn.redmine.org/redmine/trunk@18296 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 13:59:16 +00:00
Jean-Philippe Lang
638dbbea95 Support external ID when importing issues (#28213).
Patch by Gregor Schmidt and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18285 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 08:17:19 +00:00
Jean-Philippe Lang
04b8be1d5b User preference for issue history default tab (#3058).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18277 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 07:13:54 +00:00
Jean-Philippe Lang
001853ef79 Groups are incorrect when grouping by date without user timezone set.
git-svn-id: http://svn.redmine.org/redmine/trunk@18264 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 06:23:48 +00:00