Commit Graph

353 Commits

Author SHA1 Message Date
Go MAEDA
945a82b5c0 <=> operator should return nil when invoked with an incomparable object (#38772).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22269 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 14:42:54 +00:00
Go MAEDA
0befc3a23c Fix RuboCop offense Style/RedundantSelfAssignmentBranch (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22263 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 01:37:24 +00:00
Go MAEDA
53f2aca3ef "Cannot delete enumeration" error may occur when attempting to delete a project with time entries (#38286).
Patch by Holger Just and Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22155 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-25 05:09:56 +00:00
Go MAEDA
0558568257 Improve index usability for Project#project_condition (#38198).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22069 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-21 08:50:12 +00:00
Go MAEDA
eb8916bc87 Introduce permission to set a project public (#38048).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22038 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-12 02:59:54 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
361b285250 Do not break when setting enabled_module_names on a project without a default_member_role (#38064).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21994 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-12-21 02:25:47 +00:00
Marius Balteanu
883aa3b5cc Background job for project deletion (#36691).
Due to the deletion of dependent objects (issues etc), project deletion may take a long time.

This patch moves the actual project deletion into an ActiveJob job. It also introduces a new project status (SCHEDULED_FOR_DELETION) that is used to effectively hide the project that is about to be deleted (and any potential descendant projects) from the system immediately.

A security notification is sent out to the user that deleted the project, informing about success / failure.

The projects list is extended to be able to filter for the new status, so in case of a failure, the project can still be accessed for examination.

Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21591 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-05-17 20:45:41 +00:00
Marius Balteanu
81575e7291 Skip validation of required custom fields when creating a project if user does not have permissions to see those custom fields (#36593).
Patch by mathieu-mbru.


git-svn-id: https://svn.redmine.org/redmine/trunk@21488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-21 22:13:19 +00:00
Go MAEDA
2d6f552599 Replace Member.find_or_new with ActiveRecord's find_or_initialize_by (#36730).
git-svn-id: http://svn.redmine.org/redmine/trunk@21456 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-14 14:25:24 +00:00
Marius Balteanu
96d32a5226 Destroy overridden time entry activities and rows from the habtm join table @queries_roles@ on project deletion (#36416).
Patch by Holger Just.
 


git-svn-id: http://svn.redmine.org/redmine/trunk@21437 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-02-24 19:44:36 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Marius Balteanu
6cbf1f2015 Explicitly specify escape character using an ESCAPE on SQLite (#35073).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@21240 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-09 06:35:47 +00:00
Marius Balteanu
05e9d7883b Use sanitize_sql_like in like scopes (#35073).
Patch Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:44:39 +00:00
Go MAEDA
da4303a961 Locked users should not be displayed in the members box of the project overview page (#35606).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21090 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-27 04:55:08 +00:00
Go MAEDA
7f965286ed Default issue query (#7360).
Patch by Katsuya HIDAKA (the author of https://github.com/hidakatsuya/redmine_default_custom_query), Takenori TAKAKI, Olivier Chabert, and Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@21061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-06 06:01:50 +00:00
Go MAEDA
a9aae29708 Remove deprecated Project#members_by_role (#35031).
git-svn-id: http://svn.redmine.org/redmine/trunk@21003 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-15 05:52:58 +00:00
Go MAEDA
2a564a1376 DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. (#29914, #32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20880 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:32:23 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
06ac3473e0 Reverts r20653.
git-svn-id: http://svn.redmine.org/redmine/trunk@20815 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-18 00:59:01 +00:00
Toshi MARUYAMA
ee877f6c2e place the '.' on the previous line of the method call at app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20653 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-17 13:09:41 +00:00
Toshi MARUYAMA
fd112cb766 shorten long line of app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20639 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-12 15:49:36 +00:00
Toshi MARUYAMA
42b05f85ea shorten long line of app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20589 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-09 14:11:30 +00:00
Go MAEDA
f43b3685ff Use sum { ... } instead of map { ... }.sum (#34399).
git-svn-id: http://svn.redmine.org/redmine/trunk@20581 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-06 01:36:39 +00:00
Toshi MARUYAMA
0ba5cd4fea use "do end" instead of {} at ActiveRecord scope lambda of app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20341 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-12 12:31:12 +00:00
Toshi MARUYAMA
8fa5b6051f add empty line after guard clause to app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20237 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-03 14:55:57 +00:00
Toshi MARUYAMA
ec488e6379 use "do end" instead of {} at app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20079 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-26 15:01:28 +00:00
Toshi MARUYAMA
b8575166d8 remove spaces inside {} of app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20075 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-24 16:07:04 +00:00
Go MAEDA
dbe76a23b3 Allow normal users to delete a project (#33945).
Patch by Holger Just.


git-svn-id: http://svn.redmine.org/redmine/trunk@20034 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-15 04:15:13 +00:00
Go MAEDA
f19c291b59 Show groups in members box on project overview page (#33174).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19718 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-22 14:52:58 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
777704249f Fix logging time via a commit message for project specific activities (#29838).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@19512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-11 13:33:22 +00:00
Go MAEDA
47a71c8011 Reverts r19478 (#32897).
git-svn-id: http://svn.redmine.org/redmine/trunk@19479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-30 05:27:52 +00:00
Go MAEDA
10bb12e09f Fix 'DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1.' (#32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-28 09:49:14 +00:00
Toshi MARUYAMA
1bc6d701c9 cleanup: rubocop: fix Layout/SpaceInsidePercentLiteralDelimiters in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19280 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-24 16:46:37 +00:00
Toshi MARUYAMA
82c0eaadc3 cleanup: rubocop: fix Layout/IndentFirstArrayElement in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19049 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 17:57:24 +00:00
Toshi MARUYAMA
b31b57f82d cleanup: rubocop: fix Layout/BlockAlignment in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19009 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 11:53:48 +00:00
Toshi MARUYAMA
8688fd10eb cleanup: rubocop: fix Layout/AlignArguments in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18998 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 09:18:07 +00:00
Toshi MARUYAMA
790d2bae70 code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18832 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:54:12 +00:00
Toshi MARUYAMA
0fdaa963aa code cleanup: rubocop: fix Style/WhileUntilModifier in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18758 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 11:15:43 +00:00
Go MAEDA
ce831ae5e4 Reject project custom field values not visible for the user (#31954, #31925).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18401 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 10:20:09 +00:00
Go MAEDA
024f2aef6c Code cleanup: RuboCop: Fix Style/IdenticalConditionalBranches in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18380 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-20 03:27:15 +00:00
Go MAEDA
3495cba92b Per role visibility settings for project custom fields (#31925).
Patch by Jens Krämer and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18379 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-20 01:44:44 +00:00
Go MAEDA
0d4ed12388 Code cleanup: RuboCop: Rails/ActiveRecordAliases
update_attributes is deprecated in Rails 6.0 and will be removed in Rails 6.1 (#29914).


git-svn-id: http://svn.redmine.org/redmine/trunk@18375 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-17 08:14:36 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
bd5977d97e Support frozen_string_literal in app/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17987 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 13:36:03 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
6a639cdf0f Translation missing error in "Project's Status" filter options (#30718).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17869 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-15 23:44:20 +00:00
Jean-Philippe Lang
12d1372ae5 Let admin users unarchive subprojects of archived projects (#29993).
git-svn-id: http://svn.redmine.org/redmine/trunk@17681 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-02 11:13:28 +00:00