Commit Graph

7100 Commits

Author SHA1 Message Date
Toshi MARUYAMA
fd51a4fe58 code cleanup: rubocop: fix Style/CommentedKeyword in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 17:54:54 +00:00
Toshi MARUYAMA
d6701ab40f remove "attr_reader :current_journal" from Issue class
Issue#current_journal is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:48 +00:00
Toshi MARUYAMA
3be589df24 use "attr_writer" instead of "attr_accessor" for Issue#deleted_attachment_ids
Issue#deleted_attachment_ids is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:37 +00:00
Toshi MARUYAMA
4074ca0771 code clean up app/models/repository.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 13:58:41 +00:00
Toshi MARUYAMA
7fb47e4b5e code cleanup: rubocop: fix Layout/LeadingCommentSpace in app/models/repository.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18485 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 13:58:30 +00:00
Toshi MARUYAMA
0c416338dd code cleanup: rubocop: fix Style/StringLiteralsInInterpolation in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 12:59:24 +00:00
Go MAEDA
75df6ead3b Log info messages when MailHandler ignored a reply to a nonexistent issue, journal, or message (#31946).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 09:38:39 +00:00
Toshi MARUYAMA
aa8c59a389 code cleanup: rubocop: fix Layout/IndentAssignment in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 06:11:15 +00:00
Go MAEDA
5755bed4e1 Change textfield to textarea for "Exclude attachments by name" (#19903).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18476 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-18 01:25:47 +00:00
Go MAEDA
61554d9004 Add wiki toolbar to "Email header" and "Email footer" in "Email notifications" admin tab (#8343).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-17 05:58:36 +00:00
Toshi MARUYAMA
217b091143 code cleanup: rubocop: fix Layout/LeadingCommentSpace in app/controllers/repositories_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-15 15:08:49 +00:00
Toshi MARUYAMA
881c99f162 code cleanup: rubocop: fix Layout/IndentAssignment in app/helpers/repositories_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-15 15:08:38 +00:00
Go MAEDA
0d4fbfe340 Add clear query icon next to selected query in sidebar (#31640).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18468 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-14 00:33:05 +00:00
Go MAEDA
59968110a3 Add additional mail headers for issue tracker (#31910).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18459 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-12 21:52:21 +00:00
Go MAEDA
e54f1b23ec Code cleanup: RuboCop: Fix Performance/RedundantMatch and Rails/DynamicFindBy in app/controllers/auto_completes_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18451 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-11 08:08:38 +00:00
Go MAEDA
a679b8a5ca Remove 'app/views/auto_completes/issues.html.erb' which is not used (#31994).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18450 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-11 07:18:16 +00:00
Go MAEDA
3ba5e04f5e Issue auto complete should return last 10 issues (#31994).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-11 06:39:00 +00:00
Go MAEDA
5ca458864e Inline auto complete for issue (#) in wiki-edit fields (#31989).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18444 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-09 21:49:48 +00:00
Go MAEDA
89739876d1 REST API for updating news (#13468).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18443 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-09 09:03:41 +00:00
Go MAEDA
780e64a100 REST API for deleting news (#13468).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18442 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-09 08:57:29 +00:00
Go MAEDA
3ca75647df REST API for retrieving news (#13468).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18441 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-09 08:55:43 +00:00
Go MAEDA
c22469838d REST API for creating news (#13468).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18440 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-09 08:52:13 +00:00
Go MAEDA
2782d4b9f9 Add inherit_members to projects API response (#32002).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18431 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-05 04:08:30 +00:00
Go MAEDA
3432357a45 Footer is not placed at the bottom on pages with little content (#30467).
Patch by Bernhard Rohloff.


git-svn-id: http://svn.redmine.org/redmine/trunk@18427 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-04 07:38:31 +00:00
Go MAEDA
35e6a532f5 Force passwords to contain specified character classes (#4221).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-29 01:35:09 +00:00
Go MAEDA
fe0a89d7d1 CodeCleanup: RuboCop: Fix Style/RaiseArgs in app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18405 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 16:08:44 +00:00
Go MAEDA
e9d74c01d0 Improve MailHandler logging for unauthorized attempts (#31899).
Patch by Gustavo Regal.


git-svn-id: http://svn.redmine.org/redmine/trunk@18404 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 15:42:05 +00:00
Go MAEDA
217bf46029 Add CSS class to "journal" and "reply" headers (#31950).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18403 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 10:54:44 +00:00
Go MAEDA
c37d1b43a4 Reject version custom field values not visible for the user (#31954, #23997).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18402 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 10:44:39 +00:00
Go MAEDA
ce831ae5e4 Reject project custom field values not visible for the user (#31954, #31925).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18401 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 10:20:09 +00:00
Go MAEDA
26774d09e9 Code cleanup: RuboCop: Fix Style/UnneededCondition in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18397 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-26 07:16:55 +00:00
Go MAEDA
47dd2083f7 Reject setting RFC non-compliant emission email addresses (#31154).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18396 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-26 04:18:18 +00:00
Go MAEDA
331dcfbadc Code cleanup: RuboCop: Fix Style/RedundantReturn in app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18394 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 16:15:36 +00:00
Go MAEDA
0553e8375c Code cleanup: RuboCop: Fix Lint/UnneededRequireStatement in app/models/wiki_page.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18392 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 05:04:48 +00:00
Go MAEDA
959b55779f Fix hard-coded string "no subject" in app/models/mail_handler.rb (#5820).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 00:09:10 +00:00
Go MAEDA
22165fd071 Per role visibility settings for version custom fields (#23997).
Patch by Jens Krämer and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18386 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-24 08:50:17 +00:00
Go MAEDA
880883229f Add different style for group names in the New member modal window (#6831).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18385 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-24 07:30:41 +00:00
Go MAEDA
024f2aef6c Code cleanup: RuboCop: Fix Style/IdenticalConditionalBranches in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18380 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-20 03:27:15 +00:00
Go MAEDA
3495cba92b Per role visibility settings for project custom fields (#31925).
Patch by Jens Krämer and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18379 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-20 01:44:44 +00:00
Go MAEDA
79a47823b2 Refactor custom fields form (#31859).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18376 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-18 03:26:19 +00:00
Go MAEDA
0d4ed12388 Code cleanup: RuboCop: Rails/ActiveRecordAliases
update_attributes is deprecated in Rails 6.0 and will be removed in Rails 6.1 (#29914).


git-svn-id: http://svn.redmine.org/redmine/trunk@18375 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-17 08:14:36 +00:00
Go MAEDA
78d3d6c223 Speed up workflow edit page rendering (#31855).
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@18373 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-17 02:23:51 +00:00
Go MAEDA
6a871fdcfc Fix that "New custom field" button does not work if there are no custom fields (#31896, #31320).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18372 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-17 02:01:19 +00:00
Go MAEDA
31e8e736f3 Code cleanup: RuboCop: Layout/TrailingBlankLines
git-svn-id: http://svn.redmine.org/redmine/trunk@18367 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-14 03:02:20 +00:00
Go MAEDA
beeacb2c2a Replace RMagick with MiniMagick (#30492).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18366 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-14 02:40:56 +00:00
Go MAEDA
3bf7956ce0 Fix jQuery.fn.attr('selected') might use property instead of attribute (#31894, #31196).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18365 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-13 23:28:36 +00:00
Go MAEDA
e2a00d2dc8 Fix JQMIGRATE: jQuery.fn.load() is deprecated (#31884, #31196).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18364 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-13 14:23:46 +00:00
Go MAEDA
49090c5889 Updates jQuery to 2.2.4 and adds jQuery Migrate library to find APIs and features that have been or will be removed from jQuery core (#31196).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18363 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-13 14:18:41 +00:00
Go MAEDA
3c91a3d5b2 Per role visibility settings for spent time custom fields (#31859).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18358 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-09 09:31:16 +00:00
Go MAEDA
8a9123de04 Limit total_estimated_hours to visible issues (#31778).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@18356 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-07 04:44:19 +00:00