Commit Graph

2065 Commits

Author SHA1 Message Date
Go MAEDA
6b0afdc9ca "Role" dropdown in Workflow page is unexpectedly expanded when selecting "all" (#33059).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19538 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-29 04:59:48 +00:00
Go MAEDA
cc900c0e07 Diff view for .js files in repositories is broken (#32449).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19531 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-27 01:19:11 +00:00
Go MAEDA
efbfc76161 Auto select fields mapping in import based on the internal field name (ex: estimared_hours, fixed_version, spent_on) or field label (Estimated hours, Version, Date) (#22913).
* mappings are case insensitive
* a field is auto mapped only if there is no mapping setting present for that field
* "Current user" default value for User field when the user has permission to log time for other users is override by the auto mapped column

Patch by Haihan Ji, Yuichi HARADA, and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19524 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-19 14:52:02 +00:00
Go MAEDA
dec5f98112 Include attachments in forum post notifications (#16006).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19506 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-11 02:34:25 +00:00
Go MAEDA
b995014c49 Allow adding user groups as watchers for issues (#4511).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19498 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-06 08:19:13 +00:00
Go MAEDA
a0b909d523 Repository browser does not render previews for audio/video files (#32153).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-04 05:32:04 +00:00
Jean-Philippe Lang
0cd14b3a4b Validate back_url everywhere (#32850).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 08:39:22 +00:00
Jean-Philippe Lang
b3cda4fd61 Expose validate_back_url as helper method (#32850).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 08:38:47 +00:00
Jean-Philippe Lang
914f57fefc Move duplicated back_url method from ApplicationHelper to ApplicationController (#32850).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 08:38:01 +00:00
Jean-Philippe Lang
13da124b16 CSV import does not keep the project it was clicked from (#21766).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@19381 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-12-20 08:07:57 +00:00
Go MAEDA
92232cc602 Fix "Couldn't find template for digesting" error in the log when sending an attachment or thumbnail (#20277).
Patch by Olivier Houdas.


git-svn-id: http://svn.redmine.org/redmine/trunk@19365 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-12-12 14:32:25 +00:00
Go MAEDA
f7fcd111e9 Ruby 2.7: Regexp#match and Regexp#match? with a nil argument are deprecated (#32527, #31500).
git-svn-id: http://svn.redmine.org/redmine/trunk@19324 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-30 05:40:40 +00:00
Go MAEDA
f33d6177fe Add buttons to save/edit/delete a custom query to calendar view (#32194).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19322 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-30 00:58:45 +00:00
Toshi MARUYAMA
677dfdc883 replace multi line block "{}" to "do end" in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19319 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:31:04 +00:00
Toshi MARUYAMA
e27dc4d547 cleanup: rubocop: fix Layout/SpaceInsideBlockBraces in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19318 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:30:53 +00:00
Toshi MARUYAMA
8ee394e97a cleanup: rubocop: fix Layout/SpaceInsideHashLiteralBraces in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19317 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:30:42 +00:00
Toshi MARUYAMA
52d8b21f8d code layout clean up app/controllers/workflows_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19287 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 06:33:00 +00:00
Toshi MARUYAMA
cb591d0af6 code layout clean up app/controllers/application_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 06:32:28 +00:00
Toshi MARUYAMA
d81846ccc9 cleanup: rubocop: fix Layout/SpaceAfterComma in app/controllers/documents_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19272 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-24 16:45:12 +00:00
Toshi MARUYAMA
4a60ebd848 cleanup: rubocop: fix Layout/SpaceInsideParens in app/controllers/application_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19253 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-24 13:18:21 +00:00
Toshi MARUYAMA
4a9d5faaf1 cleanup: rubocop: fix Layout/EmptyLineAfterGuardClause in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19178 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 16:50:04 +00:00
Toshi MARUYAMA
e82fcb3fc5 cleanup: rubocop: fix Layout/SpaceAfterComma in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19177 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 16:49:53 +00:00
Toshi MARUYAMA
f50d50f7b8 code layout clean up app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 16:49:43 +00:00
Toshi MARUYAMA
5b1bd277f8 code layout clean up IssuesController#build_new_issue_from_params
git-svn-id: http://svn.redmine.org/redmine/trunk@19153 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:25:36 +00:00
Toshi MARUYAMA
3b71b71710 code layout clean up IssuesController#update_issue_from_params
git-svn-id: http://svn.redmine.org/redmine/trunk@19152 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:25:25 +00:00
Toshi MARUYAMA
b5574321f9 code layout clean up IssuesController#bulk_edit
git-svn-id: http://svn.redmine.org/redmine/trunk@19151 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:25:14 +00:00
Toshi MARUYAMA
e8343c1f9d code layout clean up IssuesController#create
git-svn-id: http://svn.redmine.org/redmine/trunk@19150 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:25:03 +00:00
Toshi MARUYAMA
b63b388d8a code layout clean up IssuesController#show
git-svn-id: http://svn.redmine.org/redmine/trunk@19149 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:24:53 +00:00
Toshi MARUYAMA
32dd182e25 code layout clean up IssuesController#index
git-svn-id: http://svn.redmine.org/redmine/trunk@19148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:24:42 +00:00
Toshi MARUYAMA
bee8063f46 code layout clean up IssuesController#update
git-svn-id: http://svn.redmine.org/redmine/trunk@19146 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 04:24:21 +00:00
Toshi MARUYAMA
2a1b08f2e8 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/controllers/previews_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19095 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:00:05 +00:00
Jean-Philippe Lang
977bbea725 Only admin users should be able to manage public queries on the project list (#29482).
Like for issues, project members with the "Manage public" queries are allowed to manage public queries inside their projects, not public global queries that are proposed on /issues.

git-svn-id: http://svn.redmine.org/redmine/trunk@19091 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 15:01:24 +00:00
Toshi MARUYAMA
05d9791e69 cleanup: rubocop: fix Layout/MultilineBlockLayout in app/controllers/auto_completes_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19045 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 17:11:06 +00:00
Toshi MARUYAMA
520fd7dd00 cleanup: rubocop: fix Layout/EmptyLinesAroundAccessModifier in app/controllers/previews_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19044 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 17:10:54 +00:00
Toshi MARUYAMA
97d1bafb93 cleanup: rubocop: fix Layout/BlockEndNewline in app/controllers/files_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19010 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 11:53:59 +00:00
Toshi MARUYAMA
2575805d3e cleanup: rubocop: fix Layout/BlockEndNewline in app/controllers/auth_sources_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19004 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 09:19:02 +00:00
Toshi MARUYAMA
2fc0555713 cleanup: rubocop: fix Layout/AlignArguments in app/controllers/attachments_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18941 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 01:37:25 +00:00
Toshi MARUYAMA
c611a585ad cleanup: rubocop: fix Layout/AlignArguments in app/controllers/issues_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18940 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 01:37:14 +00:00
Jean-Philippe Lang
5a72c19e5d Don't paginate the board view for now (#29482).
Subprojects may appear as root projects if their parents are on a previous page.

git-svn-id: http://svn.redmine.org/redmine/trunk@18866 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-26 07:09:52 +00:00
Jean-Philippe Lang
b4138257f0 Specific action for updating role permissions.
git-svn-id: http://svn.redmine.org/redmine/trunk@18862 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-25 16:31:57 +00:00
Jean-Philippe Lang
0dc7269c88 Add roles filter on permissions report (#32343).
git-svn-id: http://svn.redmine.org/redmine/trunk@18861 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-25 15:53:27 +00:00
Toshi MARUYAMA
f4522aeba7 code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/controllers/wiki_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18831 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:54:00 +00:00
Toshi MARUYAMA
a8b6e805a7 code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/timelog_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18825 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 13:44:15 +00:00
Toshi MARUYAMA
26db7fa6bf code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/messages_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18824 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 13:44:04 +00:00
Toshi MARUYAMA
facc6e9bff code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/boards_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18823 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 13:43:52 +00:00
Toshi MARUYAMA
252450b44c code cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/application_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18821 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:41:21 +00:00
Toshi MARUYAMA
0365bd552e code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/controllers/context_menus_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18774 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:32:37 +00:00
Jean-Philippe Lang
95188f26c3 Set default columns for the projects list (#29482).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18766 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 11:43:23 +00:00
Jean-Philippe Lang
45f039187d Option to switch between table list and board list (#29482).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18765 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 11:42:20 +00:00
Jean-Philippe Lang
6c5440a21b Filters for Projects page (#29482).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18761 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 11:36:13 +00:00