Commit Graph

95 Commits

Author SHA1 Message Date
Go MAEDA
5b77092be4 Replace regular expression matches with String#start_with? / end_with? (#40010).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22605 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-11 11:27:25 +00:00
Go MAEDA
e0e751f5bc Fix RuboCop offense Style/RedundantRegexpArgument (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22262 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 00:39:58 +00:00
Go MAEDA
fe71cb5bbe Fix RuboCop offense Lint/MissingSuper (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22147 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-24 09:34:40 +00:00
Go MAEDA
70ef2a3db1 Fix RuboCop offense Performance/ConstantRegexp (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:26:31 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
2e67986a92 remove redundant 'return' from lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20645 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-12 15:50:21 +00:00
Toshi MARUYAMA
6fb4728536 fix source indent of lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20641 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-12 15:49:51 +00:00
Toshi MARUYAMA
3788d6365c add empty line after guard clause to lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20530 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-30 15:49:36 +00:00
Toshi MARUYAMA
2132ce2618 remove spaces inside {} of lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20446 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-20 11:36:14 +00:00
Toshi MARUYAMA
f91b5bf3da fix source indent of lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20443 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-20 11:35:52 +00:00
Go MAEDA
fdba424d77 Use match? instead of =~ when MatchData is not used (#34150).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20168 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-23 00:13:38 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
947fdf100d code cleanup: rubocop: fix Rails/Presence in lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18518 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:41:39 +00:00
Toshi MARUYAMA
3b379c076d code cleanup: rubocop: fix Style/EmptyLiteral in lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18506 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 02:34:32 +00:00
Toshi MARUYAMA
188c560edc code cleanup: rubocop: fix Style/CommentAnnotation in lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18491 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 17:54:42 +00:00
Toshi MARUYAMA
9f26eac4f0 code cleanup: rubocop: fix Style/ClassCheck in lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18490 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 17:54:30 +00:00
Toshi MARUYAMA
9d2c39009d code cleanup: scm: cvs: remove unused branchPoint method from CvsRevisionHelper class
git-svn-id: http://svn.redmine.org/redmine/trunk@18453 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-12 05:27:10 +00:00
Toshi MARUYAMA
7e323965d7 code cleanup lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18418 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-31 05:53:42 +00:00
Toshi MARUYAMA
d5764a2537 code cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18417 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-31 05:53:32 +00:00
Toshi MARUYAMA
37cde69d50 rubocop: fix Layout/EmptyLinesAroundAccessModifier of lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18340 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-03 05:34:20 +00:00
Go MAEDA
c2b30f5d3d Code cleanup: RuboCop: Style/DefWithParentheses
git-svn-id: http://svn.redmine.org/redmine/trunk@18290 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 12:15:28 +00:00
Go MAEDA
97f05de373 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18199 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 22:42:47 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
606e75d12d Use #b shortcut instead of #force_encoding (#31059).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17992 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-20 01:36:44 +00:00
Go MAEDA
30e341db69 Support frozen_string_literal in lib/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 16:36:34 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
ad8cfe1887 Newlines stripped from CVS commit messages (#19835).
git-svn-id: http://svn.redmine.org/redmine/trunk@14301 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-06-13 06:38:26 +00:00
Toshi MARUYAMA
a9298224b1 fix Ruby 2.2 warning at lib/redmine/scm/adapters/cvs_adapter.rb
On ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-linux]:

<pre>
lib/redmine/scm/adapters/cvs_adapter.rb:342:
  warning: Comparable#== will no more rescue exceptions of #<=> in the next release.
lib/redmine/scm/adapters/cvs_adapter.rb:342:
  warning: Return nil in #<=> if the comparison is inappropriate or avoid such comparison.
</pre>

git-svn-id: http://svn.redmine.org/redmine/trunk@13831 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-03 17:31:01 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Jean-Philippe Lang
01a9e17c49 CVS root_url not recognized when connection string does not include port (#14422).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12027 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-15 21:06:54 +00:00
Jean-Philippe Lang
5e57a1a9d9 Merged rails-3.2 branch.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9528 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-25 17:17:49 +00:00
Toshi MARUYAMA
e748e37053 scm: cvs: use self.class.sq_bin for command name at adpter scm_cmd() (#8825).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6277 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-07-15 16:30:38 +00:00
Toshi MARUYAMA
7d15b2853a scm: cvs: use "shell_quote_command" method at adapter for JRuby + Windows command name (#8825).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6276 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-07-15 16:30:07 +00:00
Toshi MARUYAMA
d57910c39e scm: move ScmCommandAborted class from git and cvs adapter to abstract adapter.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5901 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-05-25 16:14:15 +00:00
Toshi MARUYAMA
0840ad69ea scm: cvs: override "path_encoding" method in adapter (#3462).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5866 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-05-21 02:18:53 +00:00
Toshi MARUYAMA
905a809774 scm: add "options" parameter in adapter entries().
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5638 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-05-04 14:11:25 +00:00
Toshi MARUYAMA
956e8af591 scm: cvs: fix loss non ASCII paths if path_encoding is '' (#3462).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-05-04 05:02:44 +00:00
Toshi MARUYAMA
da2c511cd1 scm: cvs: convert encoding paths in entries() of adapter (#3462).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5464 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-15 07:17:26 +00:00
Toshi MARUYAMA
c84d2e6699 scm: cvs: convert encoding paths in revisions() of adapter (#3462).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5463 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-15 07:16:48 +00:00
Toshi MARUYAMA
991d39a9ac scm: cvs: convert encoding of command line arguments (#3462).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5462 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-15 07:16:04 +00:00
Toshi MARUYAMA
eae0620e3a scm: cvs: set path encoding instance value (#3462).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5461 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-15 07:15:25 +00:00
Toshi MARUYAMA
50fe1ecc18 scm: cvs: strict string type and timezone in cvstime.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5460 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-15 04:23:42 +00:00
Toshi MARUYAMA
04a22fa757 scm: cvs: convert author encoding with log encoding setting.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5456 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-14 15:39:00 +00:00
Toshi MARUYAMA
7e5bc046d6 scm: cvs: add comment of author regexp fails in some non UTF-8 chars on Ruby 1.8.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5454 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-14 15:01:10 +00:00
Toshi MARUYAMA
12c856124b scm: cvs: code clean up adapter.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-13 11:54:06 +00:00
Toshi MARUYAMA
bc6b219fc9 scm: cvs: refactor adapter.
create new method path_with_proj() for calling cvs command.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5438 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-12 10:31:33 +00:00
Toshi MARUYAMA
df04f56891 scm: cvs: remove adapter root_url() and url() methods which are implemented in abstract class.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5437 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-12 08:04:12 +00:00
Toshi MARUYAMA
d09e496a57 scm: cvs: code clean up adapter.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5436 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-12 06:53:08 +00:00