Commit Graph

67 Commits

Author SHA1 Message Date
Go MAEDA
61e223f698 Fix RuntimeError on reload! in the Rails console (#38155).
Patch by Thomas Löber (@tloeber).


git-svn-id: https://svn.redmine.org/redmine/trunk@22681 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-05 13:39:02 +00:00
Go MAEDA
c452f00763 Fix RuboCop offense Style/ArgumentsForwarding (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22612 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-18 01:31:55 +00:00
Go MAEDA
c51e4937e7 Fix RuboCop offense Style/SuperWithArgsParentheses (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22530 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 07:15:11 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
ab5f93ae49 Fix RuboCop offense Style/RedundantCondition in lib/redmine/menu_manager.rb (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@21630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-06-14 02:36:58 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
2027b8750a Prevent hash type URLs from being namespaced in MenuManager (#35076).
Patch by Jan Schulz-Hofen.


git-svn-id: http://svn.redmine.org/redmine/trunk@20945 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-15 01:03:18 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
80f9312178 add empty line after guard clause to lib/redmine/menu_manager.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20573 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-04 13:59:44 +00:00
Toshi MARUYAMA
470558cf19 remove spaces inside {} of lib/redmine/menu_manager.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-22 13:43:43 +00:00
Toshi MARUYAMA
1286ee29d9 shorten long line of lib/redmine/menu_manager.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20416 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-18 16:15:19 +00:00
Go MAEDA
84a4a4f8ed Fix a RuboCop offence Style/MethodDefParentheses (#32530).
git-svn-id: http://svn.redmine.org/redmine/trunk@20152 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-20 14:44:12 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
ec91e38010 cleanup: rubocop: fix Layout/AlignArguments in lib/redmine/menu_manager.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19041 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 17:10:29 +00:00
Toshi MARUYAMA
5d77985f14 code cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/menu_manager.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18726 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 16:45:42 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
bff0fbce8b Remove RDoc tags (#28943).
Patch by Sho HASHIMOTO.


git-svn-id: http://svn.redmine.org/redmine/trunk@17370 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-08 00:55:41 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
2734eaffd8 Adds a link to all projects in the jump drop down (#23310).
git-svn-id: http://svn.redmine.org/redmine/trunk@16172 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-10 18:33:36 +00:00
Jean-Philippe Lang
124a459d55 Use the main menu for project related actions that support cross-project display.
git-svn-id: http://svn.redmine.org/redmine/trunk@15983 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-11-19 10:30:02 +00:00
Jean-Philippe Lang
893c96a990 Don't skip condition if defined (#15880).
git-svn-id: http://svn.redmine.org/redmine/trunk@15507 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-11 07:06:10 +00:00
Jean-Philippe Lang
53710d80fc Introduce virtual MenuNodes (#15880).
They are characterized by having a blank url. they will only be rendered if the user is authorized to see at least one of its children. they render as links which do nothing when clicked.
 
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@15501 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-11 06:21:52 +00:00
Jean-Philippe Lang
8cbfeddeb0 Child nodes should only be rendered if the user is actually authorized to see them (#15880).
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@15393 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-05-08 06:48:36 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
2ec87100a9 Tab left/right buttons for project menu (#20632).
Patch by Felix Gliesche.

git-svn-id: http://svn.redmine.org/redmine/trunk@15067 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-01-16 09:14:02 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
64fea07aff Support for named route in project menu and a new :permission option (#6426).
git-svn-id: http://svn.redmine.org/redmine/trunk@13765 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-14 21:46:53 +00:00
Jean-Philippe Lang
cb3676a553 Code cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@13764 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-14 21:01:51 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00
Jean-Baptiste Barth
953e4b4abf Add missing tests for Redmine::MenuManager::Mapper#initialize.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11772 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-03 00:40:41 +00:00
Jean-Philippe Lang
e396a0eebe Copyright for 2013 (#12788).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:29:31 +00:00
Jean-Philippe Lang
9c698157f4 Check permissions before the extra condition for displaying a menu item (#12721).
Patch by Daniel Ritz.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11112 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 08:21:33 +00:00
Jean-Philippe Lang
ba5a052c8c Copyright update.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9636 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-05-05 12:56:53 +00:00
Jean-Philippe Lang
38843eb7aa Missing html_safe.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8390 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-26 22:26:27 +00:00
Jean-Philippe Lang
f6dd3c5484 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8229 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-15 10:57:59 +00:00
Jean-Philippe Lang
77e8a76af3 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8228 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-15 10:43:31 +00:00
Jean-Philippe Lang
6c91e1420a Removed dependency with monkey-patched rubytree.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8214 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-14 22:51:18 +00:00
Jean-Philippe Lang
a756103b10 Use controller instead of instance variable.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7896 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-23 18:28:11 +00:00
Jean-Philippe Lang
4f907d5c9e Initialize @childrenHash.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7895 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-23 18:25:30 +00:00
Toshi MARUYAMA
a970118755 Rails3: use String#html_safe for render_menu_node() at lib/redmine/menu_manager.rb.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6471 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-08-20 06:52:25 +00:00
Toshi MARUYAMA
75ce76cd74 remove trailing white-spaces from lib/redmine/menu_manager.rb.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6468 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-08-20 06:50:09 +00:00
Jean-Philippe Lang
2ee45e8cac Use Object#tap instead of #returning (#6887).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4406 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-11-14 16:24:21 +00:00
Eric Davis
7514e12d33 Hide the main menu div if there isn't any items for it. #3259
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3539 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 06:01:05 +00:00
Eric Davis
28e9bc5d82 Fix an IndexError if all the :last menu items are deleted from a menu. #4718
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3447 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 05:01:39 +00:00
Eric Davis
b75e038255 Updated menus from JPL's feedback.
* Updated Mapper#push documentation
* Renamed :parent_menu to :parent
* Renamed the external API for :child_menus to :children.  Internally it needs
  to stay :child_menus because Tree::TreeNode already defines a children
  method for another purpose

  #4250

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3092 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-25 05:36:56 +00:00
Eric Davis
b0999e3764 Add support for unattached menus (generated dynamically)
A MenuItem can define a :child_menus option with a Proc.  When the menus
are rendered, the Proc will be run and the resulting MenuItems will be
added to the page as child menus

  #4250

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3091 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-25 05:36:50 +00:00
Eric Davis
1f06cf8899 Converted Menus to a Tree structure to allow submenus.
* Bundle the rubytree gem
* Patched RubyTree's TreeNode to add some additional methods.
* Converted the menu rendering to walk the Tree of MenuItems to render
  each item
* Added a menu option for :parent_menu to make this menu a child of the parent
* Added a bunch of tests
* Made MenuItem a subclass of Tree::TreeNode in order to use it's methods
  directly
* Changed the exceptions in MenuItem#new to be ArgumentErrors instead of the
  generic RuntimeError

  #4250

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3090 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-25 05:36:44 +00:00