Commit Graph

198 Commits

Author SHA1 Message Date
Go MAEDA
70bd44395d Optimize gantt chart rendering for issues without subtasks (#40000).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22589 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-03 12:14:04 +00:00
Go MAEDA
380444f085 Fix RuboCop offense Performance/StringIdentifierArgument (#39888).
git-svn-id: https://svn.redmine.org/redmine/trunk@22535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 09:23:05 +00:00
Go MAEDA
949f57f521 Correctly escape issue text in Gantt PNG export for ImageMagick convert (#38728).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22314 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-09-21 00:35:13 +00:00
Go MAEDA
4e0bb4990c Display calendar in vertical list layout on mobile screens (#33682).
Patch by Takashi Kato.


git-svn-id: https://svn.redmine.org/redmine/trunk@22283 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-08-27 06:40:59 +00:00
Go MAEDA
0b6f4c6811 Ruby 2.7: Fix RuboCop offense Performance/MapCompact (#38134).
git-svn-id: https://svn.redmine.org/redmine/trunk@22055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-17 01:38:27 +00:00
Go MAEDA
21ca0e3d0a Fix RuboCop offense Style/MinMaxComparison (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22019 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-02 06:10:53 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
ee1476f802 Fix RuboCop offense Rails/Pluck (#37248).
git-svn-id: https://svn.redmine.org/redmine/trunk@21928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-28 07:50:11 +00:00
Marius Balteanu
1b09f5e4a3 Fix gantt PNG export ignores imagemagick_convert_command (#35027).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21427 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-02-20 19:05:49 +00:00
Go MAEDA
f2ae2b9936 Duplicate activities in time entry report when project-specific activies exist (#20018).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21371 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-19 13:33:11 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Marius Balteanu
1245708ba7 Fix typo in class 'icon-expended' (#36149).
Patch by Bernhard Rohloff.

git-svn-id: http://svn.redmine.org/redmine/trunk@21275 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-08 20:14:49 +00:00
Marius Balteanu
243c110265 Move @lib/diff.rb@ to @lib/redmine/string_array_diff@ and extract @Diffable@ class to its own file (#29914, #32938).
git-svn-id: http://svn.redmine.org/redmine/trunk@21262 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-27 20:42:10 +00:00
Go MAEDA
ee64cb5cb1 Remove unused argument from Redmine::Helpers::TimeReport (#33079).
Patch by Kevin Fischer.


git-svn-id: http://svn.redmine.org/redmine/trunk@21196 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-19 13:13:26 +00:00
Marius Balteanu
e8c911577f Relax allowed protocols in links by denying specific protocols for CommonMark text formatting (#32424).
Patch by Martin Cizek.

git-svn-id: http://svn.redmine.org/redmine/trunk@21161 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-11 21:49:27 +00:00
Go MAEDA
0c8fcd1a51 Progress bar for a shared version on gantt disappears when the tree is collapsed and then expanded (#34694).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21115 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-31 06:21:35 +00:00
Go MAEDA
d4fcebaee7 Possible double includes in issue query in gantt helper (#33381).
Contributed by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@21028 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-06-06 04:48:24 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
4ae14210ea shorten long line of lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-09 14:12:15 +00:00
Toshi MARUYAMA
73b25dd2b4 add empty line after guard clause to lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20571 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-04 13:59:29 +00:00
Toshi MARUYAMA
d55971f613 remove spaces inside {} of lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20450 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-20 11:36:44 +00:00
Go MAEDA
1712ff0785 Starting or ending marker is not displayed if they are on the leftmost or rightmost boundary of the gantt (#33175).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-12 04:21:32 +00:00
Toshi MARUYAMA
e8980ad770 fix source indent of lib/redmine/helpers/time_report.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19953 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-07 12:43:24 +00:00
Go MAEDA
e93febfda2 Gantt bar is not displayed if the due date is the leftmost date or the start date is the rightmost date (#33140).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19935 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-25 08:17:49 +00:00
Toshi MARUYAMA
7055dcd767 gantt: simplify week day logic in to_pdf() at lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19797 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-27 02:25:06 +00:00
Toshi MARUYAMA
0f8df77744 gantt: simplify week day logic in to_image() at lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19796 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-27 02:24:56 +00:00
Toshi MARUYAMA
f0fdf13d1b remove unneeded () from to_pdf() at lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19788 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-27 01:56:27 +00:00
Go MAEDA
0f3cece5bb Fix that viewing gantt causes SQL error with SQL Server (#32737).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@19637 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-02 07:52:04 +00:00
Go MAEDA
795ebcc17c Use field_activity rather than label_activity in the context of time tracking (#33186).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-26 05:58:47 +00:00
Go MAEDA
0a9b72ab9c Fix that end markers in gantt PDF are misaligned (#19248).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-20 06:19:19 +00:00
Go MAEDA
94777d40b0 Gantt bars for single-day tasks may be rendered wrongly in PDF (#23645).
Patch by Daniel Ritz.


git-svn-id: http://svn.redmine.org/redmine/trunk@19592 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-20 04:48:15 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
0bc794965f cleanup: rubocop: fix Style/MethodCallWithoutArgsParentheses in lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19255 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-24 13:18:43 +00:00
Toshi MARUYAMA
b686959042 cleanup: rubocop: fix Layout/AlignArguments in lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19039 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 17:10:17 +00:00
Toshi MARUYAMA
05ef773897 code cleanup: rubocop: fix Style/ParenthesesAroundCondition in lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:55:11 +00:00
Toshi MARUYAMA
cb2d4068e8 code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18776 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:32:59 +00:00
Toshi MARUYAMA
2140c49042 code cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18727 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 16:45:54 +00:00
Go MAEDA
beeacb2c2a Replace RMagick with MiniMagick (#30492).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18366 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-14 02:40:56 +00:00
Go MAEDA
9eafc3e9a2 Remove trailing whitespaces from lib (#31506).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-06 14:50:14 +00:00
Go MAEDA
53e2cf16bb Use "icon icon-*" classes for expandable elements (#31433).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18209 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-30 07:35:46 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
6d6ea928c8 Custom Exception classes should inherit StandardError instead of Exception (#31387).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18187 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-21 23:53:10 +00:00
Go MAEDA
f992df684f Small refactorization of avatar methods (#31391).
* move existing methods from ApplicationHelper to a new helper file (AvatarsHelper)
* change default avatar size from 50 to 24 because most of the avatars are using the  size 24
* class 'gravatar' is always added and all custom classes are appended
* added user name as default title for avatar images
* added two new methods: @assignee_avatar@ and @author_avatar@

Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-19 22:27:41 +00:00
Go MAEDA
0328b5671a Show selected columns in gantt chart (#27672).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18171 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-16 21:54:33 +00:00
Go MAEDA
391a9469d1 Allow a bigger range for the gantt timeline (#14654).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18136 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-08 08:57:31 +00:00
Go MAEDA
30e341db69 Support frozen_string_literal in lib/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 16:36:34 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
bdcadb8ced Allow collapse/expand in gantt chart (#6417).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17929 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-05 14:52:09 +00:00
Go MAEDA
54bffb5ed6 Reverted r17925 (#6417). The change breaks GanttHelperTest.
git-svn-id: http://svn.redmine.org/redmine/trunk@17926 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-04 12:47:07 +00:00