Commit Graph

379 Commits

Author SHA1 Message Date
Jean-Philippe Lang
8667505e23 Don't validate custom fields that are not editable (#19193).
git-svn-id: http://svn.redmine.org/redmine/trunk@14045 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-03-01 13:23:52 +00:00
Jean-Philippe Lang
3da7b1bc28 Implements /issues/new form for creating issues outside a project (#1003).
git-svn-id: http://svn.redmine.org/redmine/trunk@13999 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-02-14 08:03:51 +00:00
Jean-Philippe Lang
37aa016740 Added Issue#attributes_editable?
git-svn-id: http://svn.redmine.org/redmine/trunk@13996 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-02-13 19:30:15 +00:00
Jean-Philippe Lang
c3c7d9a4d2 Adds a :copy_issues permission (#18855).
When copy is allowed, target projects are those on which the user has the :add_issues permission.

git-svn-id: http://svn.redmine.org/redmine/trunk@13985 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-02-08 12:07:00 +00:00
Jean-Philippe Lang
01f673be08 Removed :move_issues permission (#18855).
This permission was wrongly used to allow bulk issue copy. To prevent user from moving an issue to another project, the project field should now be set to read-only in the workflow permissions. A migration does this automatically for roles that have the edit_issues permission without having the move_issues permission.

git-svn-id: http://svn.redmine.org/redmine/trunk@13981 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-02-08 10:20:53 +00:00
Jean-Philippe Lang
6f661d40b3 Set :inverse_of option on journals association.
git-svn-id: http://svn.redmine.org/redmine/trunk@13923 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-21 08:27:46 +00:00
Jean-Philippe Lang
d85f73a30d Upgrade to Rails 4.2.0 (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13892 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-17 17:02:55 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
0ed895388b Option to search open issues only (#10734).
git-svn-id: http://svn.redmine.org/redmine/trunk@13858 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-10 10:09:34 +00:00
Jean-Philippe Lang
742895183a Search custom fields and journals with different queries to take advantage of indexes on text columns if present.
git-svn-id: http://svn.redmine.org/redmine/trunk@13855 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-08 22:04:00 +00:00
Jean-Philippe Lang
1a851318fd Replaces awesome_nested_set gem with a simple and more robust implementation of nested sets.
The concurrency tests added in this commit trigger dead locks and/or nested set inconsistency with awesome_nested_set.

git-svn-id: http://svn.redmine.org/redmine/trunk@13841 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-07 20:19:49 +00:00
Jean-Philippe Lang
453803c68f Don't consider roles without issue add/edit permissions for determining fields permissions (#15988).
git-svn-id: http://svn.redmine.org/redmine/trunk@13747 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-13 14:31:58 +00:00
Jean-Philippe Lang
07b44a4662 Droped legacy behaviour that allows a user to edit a few attributes of an issue without the edit_issues permission if a status transition is allowed (#15988).
Now that we can control permission on each field, this behaviour is no longer needed. The edit_issues permission is now required, which is consistent with the current requirements for bulk edition.

git-svn-id: http://svn.redmine.org/redmine/trunk@13746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-13 14:01:56 +00:00
Jean-Philippe Lang
2fe806a4a4 Rewrites search engine to properly paginate results (#18631).
Instead of counting and retrieving results based on their timestamps, we now load all result ids then load the appropriate results by their ids. This also brings a 2x performance improvement as we search tokens in one of the 2 queries only.

git-svn-id: http://svn.redmine.org/redmine/trunk@13739 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-12 20:49:31 +00:00
Jean-Philippe Lang
e09f48e459 Skip some validations if attribute did not change.
git-svn-id: http://svn.redmine.org/redmine/trunk@13723 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-06 11:23:05 +00:00
Jean-Philippe Lang
934e3c7de1 Typo.
git-svn-id: http://svn.redmine.org/redmine/trunk@13712 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 09:05:03 +00:00
Jean-Philippe Lang
84eee82209 Removed unused and deprecated Issue#move_to_project method.
git-svn-id: http://svn.redmine.org/redmine/trunk@13711 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 08:58:42 +00:00
Jean-Philippe Lang
7673910a2d Moved journal details generation to Journal model.
git-svn-id: http://svn.redmine.org/redmine/trunk@13703 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 08:03:32 +00:00
Toshi MARUYAMA
d1982d8156 replace tab to space at app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@13639 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-22 11:59:33 +00:00
Jean-Philippe Lang
65a62431dd Clear @spent_hours on reload (#18410).
Patch by Ondřej Ezr.

git-svn-id: http://svn.redmine.org/redmine/trunk@13625 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-22 09:39:10 +00:00
Jean-Philippe Lang
84d380c677 Prevents a status load in #status_was when status is not changed (#18290).
git-svn-id: http://svn.redmine.org/redmine/trunk@13577 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-08 11:17:45 +00:00
Jean-Philippe Lang
f095633f2f Prevents author load (#18290).
Patch by Ondřej Ezr.

git-svn-id: http://svn.redmine.org/redmine/trunk@13576 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-08 11:09:42 +00:00
Jean-Philippe Lang
4cd67587ce Fixed that a disabled field which is required by workflow rules blocks issue creation/update (#17744).
git-svn-id: http://svn.redmine.org/redmine/trunk@13557 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-04 20:49:46 +00:00
Jean-Philippe Lang
dfc594c337 Default status per tracker (#5991).
git-svn-id: http://svn.redmine.org/redmine/trunk@13535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-02 19:45:14 +00:00
Jean-Philippe Lang
32b79b6fd4 Fixed that IssueRelation should not be responsible for calling Issue#init_journal (#18237).
git-svn-id: http://svn.redmine.org/redmine/trunk@13534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-02 15:38:11 +00:00
Jean-Philippe Lang
f33dfe9243 Code cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@13515 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-26 22:33:33 +00:00
Jean-Philippe Lang
05462a145f Prevents useless COUNT queries.
git-svn-id: http://svn.redmine.org/redmine/trunk@13514 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-26 22:20:10 +00:00
Jean-Philippe Lang
46d4d75ccd Code cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@13513 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-26 14:44:11 +00:00
Jean-Philippe Lang
2d64a22dd9 Makes Project#assignable_users return a scope that prevents 2*n queries.
git-svn-id: http://svn.redmine.org/redmine/trunk@13509 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-25 11:14:16 +00:00
Jean-Philippe Lang
c0f082ad02 Code cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@13508 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-25 09:35:17 +00:00
Jean-Philippe Lang
d62574badb Code cleanup, use safer #closed?
git-svn-id: http://svn.redmine.org/redmine/trunk@13505 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-24 21:40:26 +00:00
Jean-Philippe Lang
67c4936908 Restores commits reverted when rails-4.1 branch was merged (#18174).
Patch by Mischa The Evil.

git-svn-id: http://svn.redmine.org/redmine/trunk@13504 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-24 18:41:35 +00:00
Toshi MARUYAMA
6f92548b38 remove unneeded "references" of joins
"references" is needed for includes, but not needed for joins.

git-svn-id: http://svn.redmine.org/redmine/trunk@13501 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-24 02:18:45 +00:00
Toshi MARUYAMA
374f4dd52e use includes instead of joins at Issue#visible
"rake test" passes all test, but following test fails on command line.

<pre>
$ ruby test/unit/issue_test.rb -n test_visible_scope_for_member_with_groups_should_return_assigned_issues

  1) Failure:
IssueTest#test_visible_scope_for_member_with_groups_should_return_assigned_issues [test/unit/issue_test.rb:321]:
Failed assertion, no message given.
</pre>

git-svn-id: http://svn.redmine.org/redmine/trunk@13500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-24 02:18:28 +00:00
Jean-Philippe Lang
498a34403a Removed unneeded :foreign_key option on belongs_to associations.
git-svn-id: http://svn.redmine.org/redmine/trunk@13484 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 18:41:03 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Jean-Philippe Lang
b01c740980 Fixed test failure with MySQL introduced by r13467.
git-svn-id: http://svn.redmine.org/redmine/trunk@13468 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-21 18:44:33 +00:00
Jean-Philippe Lang
51508f67d0 Fixed test failure with SQLServer introduced by r13461.
git-svn-id: http://svn.redmine.org/redmine/trunk@13467 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-21 17:47:18 +00:00
Jean-Philippe Lang
78120536b1 Fixed tests broken by r13461.
git-svn-id: http://svn.redmine.org/redmine/trunk@13466 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-20 21:47:43 +00:00
Jean-Philippe Lang
cac6ebb6c5 Code cleanup, removed raw SQL queries.
git-svn-id: http://svn.redmine.org/redmine/trunk@13461 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-20 19:16:09 +00:00
Jean-Philippe Lang
51db15ac61 Parent issue autocomplete does not follow to the "Allow cross-project subtasks" setting (#14281).
git-svn-id: http://svn.redmine.org/redmine/trunk@13400 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-09-14 10:42:31 +00:00
Toshi MARUYAMA
64255dc663 remove unneeded setting self[left_column_name] and self[right_column_name] from Issue#update_nested_set_attributes_on_parent_change (#6579)
git-svn-id: http://svn.redmine.org/redmine/trunk@13345 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-08-23 05:45:49 +00:00
Toshi MARUYAMA
d29799712f remove unneeded statement from Issue#parent_issue_id=
git-svn-id: http://svn.redmine.org/redmine/trunk@13303 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-07-13 00:04:23 +00:00
Jean-Philippe Lang
382ca5055a Field set as read-only still available in the issues list context menu (#16755).
git-svn-id: http://svn.redmine.org/redmine/trunk@13124 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-05-02 07:32:41 +00:00
Toshi MARUYAMA
ce2b12957f remove trailing white-spaces from Issue#count_and_group_by SQL
git-svn-id: http://svn.redmine.org/redmine/trunk@13084 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-04-08 11:23:05 +00:00
Toshi MARUYAMA
05d24e64f7 remove trailing white-spaces from Issue#by_subproject SQL
git-svn-id: http://svn.redmine.org/redmine/trunk@13083 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-04-08 11:22:49 +00:00
Toshi MARUYAMA
3c6d46beec remove trailing white-spaces from app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@13082 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-04-08 11:22:33 +00:00
Toshi MARUYAMA
20496b516f code format clean up Issue#update_versions_from_hierarchy_change
git-svn-id: http://svn.redmine.org/redmine/trunk@13081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-04-08 11:22:17 +00:00
Toshi MARUYAMA
66f0a5c2ef fix typos of source comments at Issue model
git-svn-id: http://svn.redmine.org/redmine/trunk@13073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-04-07 08:07:08 +00:00
Toshi MARUYAMA
2ec3b3694f fix race condition of highest rgt at Issue#update_nested_set_attributes_on_parent_change (#6579)
git-svn-id: http://svn.redmine.org/redmine/trunk@13011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-03-26 01:48:20 +00:00