Commit Graph

549 Commits

Author SHA1 Message Date
Go MAEDA
00b85dc8d9 Fix: Syntax highlighter does not work if language name is single-quoted (#28469).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17322 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-02 02:27:10 +00:00
Go MAEDA
b178150761 Show renames in diff preview (#28295).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-27 09:14:36 +00:00
Go MAEDA
8b0bfbbc8b Gantt bars with start date and end date on the same day don't become red by overdue (#13521).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17294 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-09 13:00:41 +00:00
Jean-Philippe Lang
040f31d867 Markdown pre-block could derive incorrect wiki sections (#25299).
Patch by Kiichi Ozaki.

git-svn-id: http://svn.redmine.org/redmine/trunk@17266 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-07 07:34:43 +00:00
Go MAEDA
e9fb90856f Move textile footnotes test to TextileFormatterTest (#28207).
Patch by Mischa The Evil.


git-svn-id: http://svn.redmine.org/redmine/trunk@17222 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-02 04:58:52 +00:00
Go MAEDA
8d033d08d0 Add footnotes test for markdown formatter (#28207).
Patch by Mischa The Evil.


git-svn-id: http://svn.redmine.org/redmine/trunk@17221 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-02 04:55:52 +00:00
Go MAEDA
5ed4031b64 Add minimal fixture for issues_pdf_test (#12510).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17212 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-24 09:26:26 +00:00
Go MAEDA
241e4cbb68 Enable lax_spacing for markdown formatting (#28119).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-16 05:01:14 +00:00
Go MAEDA
f496402634 Add tests for "height" and "max-height" (#26552).
git-svn-id: http://svn.redmine.org/redmine/trunk@17175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-13 00:32:53 +00:00
Go MAEDA
e4142a8338 Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textile (#26552).
Patch by Michael Gerz and Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17173 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-11 01:32:18 +00:00
Jean-Philippe Lang
4c0638c5f9 Unable to download file if custom field is not defined as visible to any users (#26705).
git-svn-id: http://svn.redmine.org/redmine/trunk@17158 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 17:43:31 +00:00
Go MAEDA
c35433ad01 Links for custom field value don't have "external" class (#27024).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-01 06:18:01 +00:00
Toshi MARUYAMA
4e7ae640b9 add copyright header to test/unit/lib/redmine/helpers/url_test.rb (#12510)
git-svn-id: http://svn.redmine.org/redmine/trunk@17077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 14:28:41 +00:00
Toshi MARUYAMA
93d8204b8a code clean up IssuesPdfHelperTest (#12510)
* remove extra empty lines
* remove trailing white space
* replace tab to two spaces

git-svn-id: http://svn.redmine.org/redmine/trunk@17065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 12:03:08 +00:00
Toshi MARUYAMA
9d797400ea mercurial: work around faulty parsing of early command options (#27516)
Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:47 +00:00
Toshi MARUYAMA
ca87bf766c mercurial: reject malicious command argument (#27516)
We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.

https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314

This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.

This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:23 +00:00
Go MAEDA
d6d2d23365 Fix: Round floats to 2 digits when rendering an issue list to PDF (#12510).
Patch by Holger Just and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 14:25:35 +00:00
Jean-Philippe Lang
62d6dfe1cc Fixes visibility checks for version.fixed_issues in Gantt (#27676).
Like the version page - the Gantt chart featured a "percent done" info
for each version, which wasn't properly limited to visible issues.

Patch by Gregor Schmidt.

git-svn-id: http://svn.redmine.org/redmine/trunk@17053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 19:38:44 +00:00
Go MAEDA
9ae7bc8152 Make robust Redmine::Helpers::URL#uri_with_safe_scheme? (#27114)
Patch by okkez.


git-svn-id: http://svn.redmine.org/redmine/trunk@17035 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-26 03:44:37 +00:00
Jean-Philippe Lang
0910b2bdbe Drop Darcs support (#26391).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-25 17:32:53 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
85a0e96ad6 Set a default size for macro thumbnails different from the preview thumbnails.
git-svn-id: http://svn.redmine.org/redmine/trunk@16829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-19 07:00:27 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
24c2416ffe Tests for Redmine::SyntaxHighlighting::CodeRay.retrieve_supported_languages (#26055).
Patch by Mischa The Evil.

git-svn-id: http://svn.redmine.org/redmine/trunk@16625 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-06 21:56:56 +00:00
Jean-Philippe Lang
4f2c5a9945 Filter arbitrary class names and ids in rendered HTML output (#25503).
* Disallow setting arbitrary classes and ids via Textile syntax
* Only allow valid/supported languages for syntax highlighted code blocks

Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@16502 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-06 16:41:52 +00:00
Jean-Philippe Lang
99fa41011f Add kbd to ALLOWED_TAGS (#25503).
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@16500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-06 16:34:52 +00:00
Toshi MARUYAMA
6139e0033a spelling fixes (#25495)
git-svn-id: http://svn.redmine.org/redmine/trunk@16445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-02 03:34:44 +00:00
Jean-Philippe Lang
f338fe9075 Allow to set multiple values in emails for list custom fields (#16549).
git-svn-id: http://svn.redmine.org/redmine/trunk@16380 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-08 19:55:56 +00:00
Jean-Philippe Lang
3faa3693d1 Test failures.
git-svn-id: http://svn.redmine.org/redmine/trunk@16359 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-03 17:17:50 +00:00
Toshi MARUYAMA
b2c0ea2c3e do not replace all invalid utf8 (#24616)
git-svn-id: http://svn.redmine.org/redmine/trunk@16273 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-28 06:24:51 +00:00
Toshi MARUYAMA
3e2d20ad91 add more tests (#24616)
git-svn-id: http://svn.redmine.org/redmine/trunk@16271 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-28 05:43:22 +00:00
Jean-Philippe Lang
9206d077d4 Group versions by status in version custom field filter (#23265).
git-svn-id: http://svn.redmine.org/redmine/trunk@16194 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-14 11:30:00 +00:00
Jean-Philippe Lang
309c6cec86 Don't preload custom field filter values (#24787).
git-svn-id: http://svn.redmine.org/redmine/trunk@16173 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-12 20:19:45 +00:00
Jean-Philippe Lang
5a77904a91 Don't use assert_equal nil.
git-svn-id: http://svn.redmine.org/redmine/trunk@16072 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-13 20:12:34 +00:00
Jean-Philippe Lang
3186130966 Don't use assert_equal nil.
git-svn-id: http://svn.redmine.org/redmine/trunk@16064 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-12 21:36:14 +00:00
Jean-Philippe Lang
bf5dade8df Use assert_nil instead of assert_equal.
git-svn-id: http://svn.redmine.org/redmine/trunk@16060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-11 15:26:41 +00:00
Jean-Philippe Lang
af29408e83 Add "Table of contents" heading to toc macro (#23179).
git-svn-id: http://svn.redmine.org/redmine/trunk@15992 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-11-19 13:50:30 +00:00
Jean-Philippe Lang
cbe5e02203 Adds tests for #hours_field (#23996).
git-svn-id: http://svn.redmine.org/redmine/trunk@15974 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-11-18 16:00:27 +00:00
Jean-Philippe Lang
ef45304817 Adds file custom field format (#6719).
git-svn-id: http://svn.redmine.org/redmine/trunk@15917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-23 09:16:14 +00:00
Jean-Philippe Lang
7abb92d813 Encode values, not full URL (#23841).
git-svn-id: http://svn.redmine.org/redmine/trunk@15846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-01 07:39:53 +00:00
Jean-Philippe Lang
ff50094d3e Include url helpers in helper tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@15686 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-16 16:17:14 +00:00
Jean-Philippe Lang
91517ec67c Passing arguments to assert_nothing_raised is deprecated in Rails 5.
git-svn-id: http://svn.redmine.org/redmine/trunk@15680 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-16 11:05:34 +00:00
Jean-Philippe Lang
4c2fcb0865 Fixed that empty Markdown image tag raises en error (#23246).
git-svn-id: http://svn.redmine.org/redmine/trunk@15607 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-06 18:18:27 +00:00
Jean-Philippe Lang
bbd24fe350 Custom field List Link values to URL breaks on entries with spaces (#23067).
git-svn-id: http://svn.redmine.org/redmine/trunk@15539 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-18 06:17:34 +00:00
Jean-Philippe Lang
adb9980728 Allow global versions to be shown outside of a project for version custom fields (#23083).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@15536 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-18 05:59:20 +00:00
Jean-Philippe Lang
53710d80fc Introduce virtual MenuNodes (#15880).
They are characterized by having a blank url. they will only be rendered if the user is authorized to see at least one of its children. they render as links which do nothing when clicked.
 
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@15501 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-11 06:21:52 +00:00
Jean-Philippe Lang
91e991e951 Limits the schemes that custom field URL patterns can use (#22925).
git-svn-id: http://svn.redmine.org/redmine/trunk@15435 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-01 19:27:09 +00:00
Jean-Philippe Lang
fad71f8b4b NoMethodError: undefined method `id' error on EnumerationFormat#value_from_keyword (#22911).
Patch by Haihan Ji.

git-svn-id: http://svn.redmine.org/redmine/trunk@15429 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-05-28 11:37:28 +00:00
Jean-Philippe Lang
8cbfeddeb0 Child nodes should only be rendered if the user is actually authorized to see them (#15880).
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@15393 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-05-08 06:48:36 +00:00
Jean-Philippe Lang
64afa24a7f Replaces acts_as_list with an implementation that handles #position= (#12909).
Objects are reordered using the regular attribute writer #position= and AR callbacks.

git-svn-id: http://svn.redmine.org/redmine/trunk@15335 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-04-17 06:57:20 +00:00